danger-yajp 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28f5c1b87c4924673bd6bfe7d00ec01bf94b4ea9520b43fd3002eb5944141e7c
-  data.tar.gz: a13caf1147682bdd71e048c848be6cb53cc7a5f5cd489310883d0ab797d76913
+  metadata.gz: 1f67dc7849b79110482c02fa779ac8e3622a7e9c82d7ff1ae84fb1a898bcb022
+  data.tar.gz: f9faa4baac94dd08416a34c783708334a502e15e48a5cff6fc3db98a35131bfd
 SHA512:
-  metadata.gz: 2007d092a1f920d1ca505de0695b26680629dbc082314e9ba9531894df830822383a372d3bd3b606917242ff30f161bb7d83164feaef43f6d01784908738eaf6
-  data.tar.gz: 4b37f4e6098bb8bb594da8bcf3f433500cf53107fc510169ec75760b7fb0c3137e0150fb8f64f2f53880cf0db55c618602db2e038edd22fa1c2292c0bae12452
+  metadata.gz: f580d3fc39375dfd017c6824b6900c667abd73304346f86bfc4f8b43c841b23a0c2a12806c621b0ad54b9a925f73b66223202117851e7f9cfdaee578e13b327e
+  data.tar.gz: 12cf1174e25d554a0058aecf3261c2c87104d0f30fb351f38ea902519a34aa9f8d920320db9500fb1bafdc231c126754628efbe568262b2edc77eefee4532d81

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-yajp (0.1.1)
+    danger-yajp (0.1.2)
       danger-plugin-api
       jira-ruby
 
@@ -30,7 +30,7 @@ GEM
     cork (0.3.0)
       colored2 (~> 3.1)
     crack (0.4.4)
-    danger (8.2.0)
+    danger (8.2.1)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -82,7 +82,7 @@ GEM
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    listen (3.2.1)
+    listen (3.3.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
@@ -100,7 +100,7 @@ GEM
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parallel (1.19.2)
+    parallel (1.20.0)
     parser (2.7.2.0)
       ast (~> 2.4.1)
     pry (0.13.1)
@@ -128,13 +128,13 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.0)
-    rubocop (1.2.0)
+    rubocop (1.3.0)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 1.0.1)
+      rubocop-ast (>= 1.1.1)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (1.1.1)
@@ -149,10 +149,10 @@ GEM
       unicode-display_width (~> 1.1, >= 1.1.1)
     thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.7)
+    tzinfo (1.2.8)
       thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
-    webmock (3.9.4)
+    webmock (3.10.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)

data/README.md

@@ -18,12 +18,12 @@ gem 'danger-yajp'
 
 ## Usage
 
-You first need to define the environment variables `DANGER_JIRA_URL`, `DANGER_JIRA_USER` and `DANGER_JIRA_PASSWORD` in your CI environment, for example:
+You first need to define the environment variables `DANGER_JIRA_URL`, `DANGER_JIRA_USER` and `DANGER_JIRA_API_TOKEN` in your CI environment, for example:
 
 ```
 DANGER_JIRA_URL: https://jira.company.com/jira
 DANGER_JIRA_USER: username
-DANGER_JIRA_PASSWORD: abcd12345
+DANGER_JIRA_API_TOKEN: abcd12345
 ```
 
 ### Find issues

data/lib/yajp/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yajp
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/lib/yajp/plugin.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'jira-ruby'
-require 'json'
 
 module Danger
   # Yet Another Jira Plugin (in short: yajp) provides methods to easily find and manipulate issues from within the Dangerfile.
@@ -85,7 +84,7 @@ module Danger
       jira_issues.concat(search_branch(regexp)) if search_branch
       jira_issues.concat(search_pr_body(regexp)) if jira_issues.empty?
 
-      jira_issues.uniq.map { |issue_key| @api.Issue.find(issue_key) }
+      jira_issues.uniq(&:downcase).map { |issue_key| @api.Issue.find(issue_key) }
     end
 
     # Transition the given Jira issue(s) using the ID of the transition. Transition IDs can be found in Jira under Project Workflow > Edit Workflow in Text Mode.
@@ -247,7 +246,7 @@ module Danger
 
     def build_regexp_from_key(key)
       keys = key.kind_of?(Array) ? key.join('|') : key
-      return /((?:#{keys})-[0-9]+)/
+      return /((?:#{keys})-[0-9]+)/i
     end
 
     def search_title(regexp)

data/spec/yajp_spec.rb

@@ -47,9 +47,9 @@ module Danger
       end
 
       it 'can find jira issues via branch name' do
-        allow(plugin).to receive_message_chain('github.branch_for_head').and_return('bugfix/WEB-126')
+        allow(plugin).to receive_message_chain('github.branch_for_head').and_return('bugfix/web-126')
         issues = plugin.search_branch(plugin.build_regexp_from_key('WEB'))
-        expect(issues).to eq(['WEB-126'])
+        expect(issues).to eq(['web-126'])
       end
 
       it 'can find jira issues in pr body' do
@@ -62,13 +62,14 @@ module Danger
         issue = Object.new
 
         def issue.find(key)
-          return key
+          # The find method in jira-ruby plugin is not case sensitive, hence the upcase.
+          return key.upcase
         end
 
         allow_any_instance_of(JIRA::Client).to receive(:Issue).and_return(issue)
 
         allow(plugin).to receive_message_chain('github.pr_title').and_return('Fix for WEB-128 and WEB-129')
-        allow(plugin).to receive_message_chain('github.branch_for_head').and_return('bugfix/WEB-128')
+        allow(plugin).to receive_message_chain('github.branch_for_head').and_return('bugfix/web-128')
         issues = plugin.find_issues('WEB', search_branch: true)
         expect(issues).to eq(['WEB-128', 'WEB-129'])
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-yajp
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - juliendms
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-06 00:00:00.000000000 Z
+date: 2020-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api