danger-yajp 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66916c1769e7fecc6c05f5eb549e5775ae7bc8a98eac77bcf0efa727fdc5ec13
-  data.tar.gz: 24cca5f396eda224b143d326a152960a6dab5281634f02891d51ed0dfedfc97e
+  metadata.gz: 17ad66f844e895f7e409c0576a5acb92cc040e19ae1aa1c5bb0e2cf2905bb144
+  data.tar.gz: 4f0f8c655b370ecfbdf3f180400a63ec4b1beff3e1acd48f9737381f88c0a096
 SHA512:
-  metadata.gz: 622b3ed1ff1e2168b1666861adfc20255a83573166a38ccf4edb352b9eaaf5e8d83e7eea900a3ce1d6e5954312ea3c6352ef89b23666b6b2f222c4079eaf5c9a
-  data.tar.gz: 5efc4d116c9c8e053c89086bde433515e09cfa11da105fe48f51ec76da0280281b90caefd8e7bb79a5c8da7e6590e47df3b66e5714dd2883af187f47fbc36740
+  metadata.gz: b07a845fb824464a06a159419cf72580c7cd25867d18db56d61348dd097c42becfac016a9cc306648e42891d09a9ef66759a8c573dabf91fc92eb744f55f2b8f
+  data.tar.gz: 48363be1c7b1d43659268b0447c81d1ed0c994a8445f319f6c4cc3544862c98f5ef76e4413e4d39ad0eaf0cd1d333ba382d5d085c12f1162ec7623411178c3c7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-yajp (0.0.1)
+    danger-yajp (0.0.2)
       danger-plugin-api
       jira-ruby
 
@@ -115,19 +115,19 @@ GEM
     rchardet (1.8.0)
     regexp_parser (1.8.2)
     rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.3)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.3)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.4)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
     rubocop (1.0.0)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
@@ -137,7 +137,7 @@ GEM
       rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.1.0)
+    rubocop-ast (1.1.1)
       parser (>= 2.7.1.5)
     ruby-progressbar (1.10.1)
     ruby2_keywords (0.0.2)

data/README.md

@@ -84,7 +84,7 @@ else
   issues.each do |issue|
     message "<a href='#{jira.issue_link(issue)}'>#{issue.key} - #{issue.summary}</a>"
 
-    case issue.status
+    case issue.status.name
     when 'In Progress'
       jira.transition_and_update(issue, 10, assignee: { name: 'username' }, customfield_11005: 'example')
     when 'To Do', 'Blocked'

data/lib/yajp/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yajp
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/yajp/plugin.rb

@@ -20,7 +20,7 @@ module Danger
   #     issues.each do |issue|
   #       message "<a href='#{jira.issue_link(issue)}'>#{issue.key} - #{issue.summary}</a>"
   #
-  #       case issue.status
+  #       case issue.status.name
   #       when 'In Progress'
   #         jira.transition_and_update(issue, 10, assignee: { name: 'username' }, customfield_11005: 'example')
   #       when 'To Do', 'Blocked'
@@ -129,8 +129,10 @@ module Danger
       result = true
 
       issues.each do |key|
-        result &= key.save(fields)
+        result &= key.save({ fields: fields })
       end
+
+      return result
     end
 
     # Utility to split the given fields into fields that can be updated on the transition screen corresponding to the `transition_id` of the given `issue`.

data/spec/yajp_spec.rb

@@ -1,9 +1,15 @@
 # frozen_string_literal: true
 
-require File.expand_path('spec_helper', __dir__)
+require_relative 'spec_helper'
 
 module Danger
   describe Danger::DangerYajp do
+    before do
+      ENV['DANGER_JIRA_URL'] = 'https://jira.company.com/jira'
+      ENV['DANGER_JIRA_USER'] = 'username'
+      ENV['DANGER_JIRA_PASSWORD'] = 'password'
+    end
+
     it 'should be a plugin' do
       expect(Danger::DangerYajp.new(nil)).to be_a Danger::Plugin
     end
@@ -13,9 +19,6 @@ module Danger
       let(:plugin) { dangerfile.jira }
 
       before do
-        ENV['DANGER_JIRA_URL'] = 'https://jira.company.com/jira'
-        ENV['DANGER_JIRA_USER'] = 'username'
-        ENV['DANGER_JIRA_PASSWORD'] = 'password'
         DangerYajp.send(:public, *DangerYajp.private_instance_methods)
       end
 
@@ -92,9 +95,26 @@ module Danger
         allow(issue).to receive(:key_value).and_return('WEB-131')
         stub = stub_request(:post, url).
           with(body: expected_json)
-        plugin.transition(issue, 2, assignee: { name: 'username' }, customfield_11005: 'example')
+        result = plugin.transition(issue, 2, assignee: { name: 'username' }, customfield_11005: 'example')
 
         expect(stub).to have_been_requested.once
+        expect(result).to be true
+      end
+
+      it 'can update issues' do
+        expected_json = '{"fields":{"assignee":{"name":"username"},"customfield_11005":"example"}}'
+        uri_template = Addressable::Template.new "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/{issue}"
+        issue1 = plugin.api.Issue.build
+        issue2 = plugin.api.Issue.build
+
+        allow(issue1).to receive(:key_value).and_return('WEB-132')
+        allow(issue2).to receive(:key_value).and_return('WEB-133')
+        stub = stub_request(:put, uri_template).
+          with(body: expected_json)
+        result = plugin.update([issue1, issue2], assignee: { name: 'username' }, customfield_11005: 'example')
+
+        expect(stub).to have_been_requested.twice
+        expect(result).to be true
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-yajp
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - juliendms
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-02 00:00:00.000000000 Z
+date: 2020-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api