danger-xcprofiler 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5ec600c4eda17f744c354d8ab32a4cfdb85889fa
-  data.tar.gz: 0ef15b2734e12f330543b58335b194cc15e73559
+SHA256:
+  metadata.gz: 98d8b6553f16e8366ff699fadb2a2353f9bb8f6813f3e20a223cba72474cbe5c
+  data.tar.gz: bbb1c70e6efaeffd593cbf7b59d760143493e8cc578dcf16098888905c9c4959
 SHA512:
-  metadata.gz: 26e6c25e956054de19cfabd4678dce6866eed86faf846e544b49d817d4a779bacbbb62d352bf035f059e425d3596d5c89e638a19905a1ccb1ba9986ee571568c
-  data.tar.gz: 0553b0df7713eb1cbd512e5233bd77e3831cc375a2bf49b889a7371b548cd0fcfcd35edafc152129a564b6f3698e7ed0b5a6061f0e761f52fc536915c9327e77
+  metadata.gz: bd7cdd61911169a68b9b0ce7ec7e34da47bfe43ec3e455330623fcaf60a167bb55c64c5f68f78f8df41970a071779381730769dc2d404e11ff04c159dbf5e810
+  data.tar.gz: 22b2ae376946f27b8a13ed8eece85dc81812ab0f304e4f1cb0ecb0794cb9b0d0424fbfc5b4bd12a230b451904a0b9da5c80bc3673ba9787ec77781840abe271b

data/danger-xcprofiler.gemspec

@@ -33,8 +33,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'coveralls'
 
   # Linting code and docs
-  spec.add_development_dependency 'rubocop', '~> 0.41'
-  spec.add_development_dependency 'yard', '~> 0.8'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'yard'
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'

data/lib/xcprofiler/danger_reporter.rb

@@ -3,15 +3,18 @@ require 'pathname'
 
 module Danger
   class DangerReporter < Xcprofiler::AbstractReporter
-    def initialize(dangerfile, thresholds, inline_mode, working_dir)
+    def initialize(dangerfile, thresholds, inline_mode, working_dir, ignored_files)
       super({})
       @dangerfile = dangerfile
       @thresholds = thresholds
       @inline_mode = inline_mode
       @working_dir = working_dir
+      @ignored_files = ignored_files
     end
 
     def report!(executions)
+      executions.reject! { |execution| ignored_files.any? { |pattern| File.fnmatch(pattern, execution.path) } }
+
       if @inline_mode
         inline_report(executions)
       else
@@ -69,5 +72,9 @@ module Danger
 
       message
     end
+
+    def ignored_files
+      [@ignored_files].flatten.compact
+    end
   end
 end

data/lib/xcprofiler/gem_version.rb

@@ -1,3 +1,3 @@
 module DangerXcprofiler
-  VERSION = '0.3.1'.freeze
+  VERSION = '0.4.0'.freeze
 end

data/lib/xcprofiler/plugin.rb

@@ -12,6 +12,10 @@ module Danger
   #          xcprofiler.thresholds = { warn: 100, fail: 500 }
   #          xcprofiler.report 'MyApp'
   #
+  # @example Specify a custom DerivedData directory
+  #
+  #          xcprofiler.report 'MyApp' './DerivedData'
+  #
   # @see  giginet/danger-xcprofiler
   # @tags xcode, ios, danger
   class DangerXcprofiler < Plugin
@@ -33,13 +37,22 @@ module Danger
     # @return   [Boolean]
     attr_accessor :inline_mode
 
+    # A globbed string or array of strings which should match the files
+    # that you want to ignore warnings on. Defaults to nil.
+    # An example would be `'**/Pods/**'` to ignore warnings in Pods that your project uses.
+    #
+    # @param    [String or [String]] value
+    # @return   [[String]]
+    attr_accessor :ignored_files
+
     # Search the latest .xcactivitylog by the passing product_name and profile compilation time
     # @param    [String] product_name Product name for the target project.
+    # @param    [String] derived_data_path Path to the directory containing the DerivedData.
     # @return   [void]
-    def report(product_name)
-      profiler = Xcprofiler::Profiler.by_product_name(product_name)
+    def report(product_name, derived_data_path = nil)
+      profiler = Xcprofiler::Profiler.by_product_name(product_name, derived_data_path)
       profiler.reporters = [
-        DangerReporter.new(@dangerfile, thresholds, inline_mode, working_dir)
+        DangerReporter.new(@dangerfile, thresholds, inline_mode, working_dir, ignored_files)
       ]
       profiler.report!
     rescue Xcprofiler::DerivedDataNotFound, Xcprofiler::BuildFlagIsNotEnabled => e
@@ -58,6 +71,7 @@ module Danger
 
     def inline_mode
       return true if @inline_mode.nil?
+
       !!@inline_mode
     end
   end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ require 'coveralls'
 Coveralls.wear!
 
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+ROOT = Pathname.new(File.expand_path('..', __dir__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)
 $LOAD_PATH.unshift((ROOT + 'spec').to_s)
 

data/spec/xcprofiler_spec.rb

@@ -1,6 +1,7 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 require 'xcprofiler'
 
+# rubocop:disable Metrics/ModuleLength
 module Danger
   describe Danger::DangerXcprofiler do
     it 'should be a plugin' do
@@ -25,7 +26,7 @@ module Danger
         allow(@dangerfile).to receive(:warn)
         allow(@dangerfile).to receive(:fail)
         allow(@dangerfile).to receive(:markdown)
-        allow(Xcprofiler::Profiler).to receive(:by_product_name).with(product_name).and_return(profiler)
+        allow(Xcprofiler::Profiler).to receive(:by_product_name).with(product_name, nil).and_return(profiler)
         allow(derived_data).to receive(:flag_enabled?).and_return(true)
         allow(derived_data).to receive(:executions).and_return([execution0, execution1])
         [execution0, execution1].each do |execution|
@@ -34,6 +35,25 @@ module Danger
         end
       end
 
+      context 'with ignored files' do
+        let(:time0) { 49.9 }
+        let(:time1) { 50 }
+        it 'skips matching warning' do
+          @xcprofiler.ignored_files = ['path/**']
+          @xcprofiler.report(product_name)
+          expect(@dangerfile).to_not have_received(:warn).with('`doSomething()` takes 50.0 ms to build',
+                                                               file: 'path/to/Source.swift',
+                                                               line: 20)
+        end
+        it 'includes non-matching warning' do
+          @xcprofiler.ignored_files = ['other/path/**']
+          @xcprofiler.report(product_name)
+          expect(@dangerfile).to have_received(:warn).with('`doSomething()` takes 50.0 ms to build',
+                                                           file: 'path/to/Source.swift',
+                                                           line: 20)
+        end
+      end
+
       context 'with slow execution' do
         let(:time0) { 49.9 }
         let(:time1) { 50 }
@@ -119,3 +139,4 @@ module Danger
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcprofiler
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - giginet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-15 00:00:00.000000000 Z
+date: 2019-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcprofiler
@@ -98,30 +98,30 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: danger plugin for asserting Swift compilation time.