danger-xcode_summary 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c3c535aacaf5147fbaa8a5bb2d77b54c89b56fd72de75071f16655903b5b95
-  data.tar.gz: 4f1b7450d3f00cf969ddf63a74c4c4917b3dc7399c2bf27f5951bc6759485daf
+  metadata.gz: 5f2fbf0b2b5b627c8f595437c80bfe676cf2f7717a140b24b4b46fa64d0b07cf
+  data.tar.gz: b5dd0539de517d98eb0ac316c78db524c44c880d3d32fc495fed69295a298e09
 SHA512:
-  metadata.gz: c4cdc7816df1c0d50682cd387bce49b47f8fd7a99aff6b0c56dfce0252e9421c4e02be8cfc6c637109abd52b767ca29842c761031e1961ff835dd8ef90d731e0
-  data.tar.gz: 39d7f4bbee347d2f7f7e0f25dbff37dd43b486f1277cf22890d15c11531fed69794e8ce8049828d71924f8ee15f414ce3b15b5cd271a78fda6da4e9abc7ae5f1
+  metadata.gz: 2c5d50b34767978e6ce5b544e9e45bd66234d27351ad96128939d1372830fb8ec61eb0c820e3f4e47bae40849552105bd0849430dd8ec6cc89883de63fac680d
+  data.tar.gz: 50b34884ff63462cb83aaad5b9dc39dbc87ea33b55b6c91031cd72a34774383edce0f8e58258f7eb6b6afa13d0fb78b9f7234b5da36e918a78ecfd71063f0e36

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (1.0.1)
+    danger-xcode_summary (1.1.0)
       danger-plugin-api (~> 1.0)
       xcresult (~> 0.2)
 
@@ -11,7 +11,7 @@ GEM
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
-    claide (1.0.3)
+    claide (1.1.0)
     claide-plugins (0.9.2)
       cork
       nap
@@ -20,7 +20,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (8.4.0)
+    danger (8.4.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -35,17 +35,18 @@ GEM
       terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.4.4)
-    faraday (1.8.0)
+    diff-lcs (1.5.0)
+    faraday (1.9.3)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
-      faraday-httpclient (~> 1.0.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
       faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
+      faraday-net_http_persistent (~> 1.0)
       faraday-patron (~> 1.0)
       faraday-rack (~> 1.0)
-      multipart-post (>= 1.2, < 3)
+      faraday-retry (~> 1.0)
       ruby2_keywords (>= 0.0.4)
     faraday-em_http (1.0.0)
     faraday-em_synchrony (1.0.0)
@@ -53,13 +54,16 @@ GEM
     faraday-http-cache (2.2.0)
       faraday (>= 0.8)
     faraday-httpclient (1.0.1)
+    faraday-multipart (1.0.3)
+      multipart-post (>= 1.2, < 3)
     faraday-net_http (1.0.1)
     faraday-net_http_persistent (1.2.0)
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
-    ffi (1.15.4)
-    formatador (0.3.0)
-    git (1.9.1)
+    faraday-retry (1.0.3)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    git (1.10.2)
       rchardet (~> 1.8)
     guard (2.18.0)
       formatador (>= 0.2.4)
@@ -79,7 +83,7 @@ GEM
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    listen (3.7.0)
+    listen (3.7.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
@@ -91,48 +95,48 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.21.0)
+    octokit (4.22.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.21.0)
-    parser (3.0.2.0)
+    parser (3.1.0.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (4.0.6)
-    rainbow (3.0.0)
+    rainbow (3.1.1)
     rake (13.0.6)
-    rb-fsevent (0.11.0)
+    rb-fsevent (0.11.1)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     rchardet (1.8.0)
-    regexp_parser (2.1.1)
+    regexp_parser (2.2.0)
     rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
       rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
+    rspec-core (3.10.2)
       rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec-expectations (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+    rspec-mocks (3.10.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.22.1)
+    rspec-support (3.10.3)
+    rubocop (1.25.1)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rubocop-ast (>= 1.15.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.12.0)
+    rubocop-ast (1.15.1)
       parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.5)
@@ -142,10 +146,12 @@ GEM
     shellany (0.0.1)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
-    thor (1.1.0)
+    thor (1.2.1)
     unicode-display_width (2.1.0)
+    webrick (1.7.0)
     xcresult (0.2.1)
-    yard (0.9.26)
+    yard (0.9.27)
+      webrick (~> 1.7.0)
 
 PLATFORMS
   ruby
@@ -164,4 +170,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.2.26
+   2.3.0

data/README.md

@@ -106,6 +106,13 @@ xcode_summary.inline_mode = true
 xcode_summary.report 'MyApp.xcresult'
 ```
 
+You can use `strict` to reporting errors as warnings thereby don't block merge PR.
+
+ ```ruby
+ # If value is `false`, then errors will be reporting as warnings
+ xcode_summary.strict = false
+ ```
+
 You can get warning and error number by calling `warning_error_count`. The return will be a JSON string contains warning and error count, e.g `{"warnings":1,"errors":3}`:
 
 ```ruby

data/lib/xcode_summary/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module XcodeSummary
-  VERSION = '1.0.1'
+  VERSION = '1.1.0'
 end

data/lib/xcode_summary/plugin.rb

@@ -55,6 +55,12 @@ module Danger
     # @return   [Boolean]
     attr_accessor :ignores_warnings
 
+    # Defines errors strict. If value is `false`, then errors will be reporting as warnings.
+    # Defaults to `true`
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :strict
+
     # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
@@ -78,8 +84,14 @@ module Danger
       @ignores_warnings || false
     end
 
+    def strict
+      @strict.nil? ? true : @strict
+    end
+
     # Pick a Dangerfile plugin for a chosen request_source and cache it
     # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
+    #
+    # @return   [void]
     def plugin
       plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
       @plugin ||= plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
@@ -130,15 +142,21 @@ module Danger
             warn(result.message, sticky: false)
           end
         end
-        # rubocop:disable Lint/UnreachableLoop
         errors(action).each do |result|
           if inline_mode && result.location
-            fail(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            if strict
+              fail(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            else
+              warn(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            end
           else
-            fail(result.message, sticky: false)
+            if strict
+              fail(result.message, sticky: false)
+            else
+              warn(result.message, sticky: false)
+            end
           end
         end
-        # rubocop:enable Lint/UnreachableLoop
       end
     end
 
@@ -185,7 +203,8 @@ module Danger
       file_name = file_path.split('/').last
       fragment = document_location.url.split('#').last
       params = CGI.parse(fragment).transform_values(&:first)
-      line = params['StartingLineNumber'].to_i + 1 # StartingLineNumber is 0-based, but we need a 1-based value
+      line_number = params['StartingLineNumber']
+      line = line_number.empty? ? -0 : line_number.to_i + 1 # StartingLineNumber is 0-based, but we need a 1-based value
       Location.new(file_name, relative_path(file_path), line)
     end
 

data/spec/xcode_summary_spec.rb

@@ -18,6 +18,13 @@ module Danger
         @xcode_summary.project_root = '/Users/marcelofabri/SwiftLint/'
       end
 
+      it 'test' do
+        params = { 'one' => '10' }
+        line_number = params['StartingLineNumber']
+        line = line_number.empty? ? -0 : line_number.to_i + 1 # StartingLineNumber is 0-based, but we need a 1-based value
+        expect(line).to eq -0
+      end
+
       it 'fail if file does not exist' do
         @xcode_summary.report('spec/fixtures/inexistent_file.xcresult')
         expect(@dangerfile.status_report[:errors]).to eq ['summary file not found']
@@ -172,6 +179,23 @@ module Danger
             expect(result).to eq '{"warnings":19,"errors":1}'
           end
         end
+
+        context 'without strict' do
+          before do
+            @xcode_summary.strict = false
+          end
+
+          it 'shows errors as warnings' do
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
+            expect(@dangerfile.status_report[:warnings].count).to_not eq 0
+            expect(@dangerfile.status_report[:errors]).to eq []
+          end
+
+          it 'report warning and error counts' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+            expect(result).to eq '{"warnings":21,"errors":3}'
+          end
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-11 00:00:00.000000000 Z
+date: 2022-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcresult
@@ -311,7 +311,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings