danger-xcode_summary 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7160cc7c92845abecec316007f22b340e478d388
-  data.tar.gz: ee0d0752692b8ac7b177a1004fb4ac29c9e63ef7
+  metadata.gz: 5ef0a41da411d5fedee16a908c63a787016845a4
+  data.tar.gz: 8c9907a822c190b740071ec03d5ec697165fffb5
 SHA512:
-  metadata.gz: 8384d1ebcfda002f5a9a19b4b8f4594189460fc1d8bde87c2f8b616df68071b61353c20d76ec4ad872e692a25adb097231eb0167c5fd062a380f7f9c9d0fd88b
-  data.tar.gz: 96be4fdf6814c92709af16c0ce74f568dd8465fd56f1c5be90d75c627f0e773719a35c23cc8192faf4da84a091f26923c8d146095bc4761aa7d32d4e2d5fc146
+  metadata.gz: 7fb0cc0bffa225a4e92e0a489502400dc411521f9c315286820262f4473d78d88ee009db84704f6fd33cfb58a1128c9f8b0615d98bb38bca9c8f44777ff9d7b1
+  data.tar.gz: ed3e60b481fc7becd59935525706655b75c27fdfe6c9a3371087d146692fc8b15ac96258b0c77b2c88c4f6edd78803b5f0f9e933e8a10a67ecbb9a5f1295e4c3

data/Gemfile.lock

@@ -1,48 +1,46 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.1.0)
+    danger-xcode_summary (0.1.2)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.4.0)
+    addressable (2.5.0)
+      public_suffix (~> 2.0, >= 2.0.2)
     ast (2.3.0)
-    claide (1.0.0)
-    claide-plugins (0.9.1)
+    claide (1.0.1)
+    claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
     coderay (1.1.1)
     colored (1.2)
+    colored2 (3.1.2)
     cork (0.2.0)
       colored (~> 1.2)
-    danger (3.0.3)
+    danger (4.3.0)
       claide (~> 1.0)
-      claide-plugins (> 0.9.0)
-      colored (~> 1.2)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
       faraday-http-cache (~> 1.0)
       git (~> 1)
-      gitlab (~> 3.7.0)
       kramdown (~> 1.5)
       octokit (~> 4.2)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.2.5)
-    faraday (0.9.2)
+    faraday (0.11.0)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
     ffi (1.9.14)
     formatador (0.2.5)
     git (1.3.0)
-    gitlab (3.7.0)
-      httparty (~> 0.13.0)
-      terminal-table
     guard (2.14.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -57,25 +55,20 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    httparty (0.13.7)
-      json (~> 1.8)
-      multi_xml (>= 0.5.2)
-    json (1.8.3)
-    kramdown (1.12.0)
+    kramdown (1.13.2)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
     lumberjack (1.0.10)
     method_source (0.8.2)
-    multi_xml (0.5.5)
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
     notiffany (0.1.0)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.3.0)
-      sawyer (~> 0.7.0, >= 0.5.3)
+    octokit (4.6.2)
+      sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parser (2.3.1.2)
       ast (~> 2.2)
@@ -84,6 +77,7 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    public_suffix (2.0.5)
     rainbow (2.1.0)
     rake (10.5.0)
     rb-fsevent (0.9.7)
@@ -109,12 +103,13 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.8.1)
-    sawyer (0.7.0)
-      addressable (>= 2.3.5, < 2.5)
-      faraday (~> 0.8, < 0.10)
+    sawyer (0.8.1)
+      addressable (>= 2.3.5, < 2.6)
+      faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.6.0)
+    terminal-table (1.7.0)
+      unicode-display_width (~> 1.1)
     thor (0.19.1)
     unicode-display_width (1.1.0)
     yard (0.9.1)
@@ -136,4 +131,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   1.13.1
+   1.14.3

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,3 @@
 module XcodeSummary
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.2'.freeze
 end

data/lib/xcode_summary/plugin.rb

@@ -38,6 +38,12 @@ module Danger
     # @return   [Boolean]
     attr_accessor :sticky_summary
 
+    # Defines if the build summary is shown or not.
+    # Defaults to `true`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :test_summary
+
     def project_root
       root = @project_root || Dir.pwd
       root += '/' unless root.end_with? '/'
@@ -52,6 +58,10 @@ module Danger
       @sticky_summary || false
     end
 
+    def test_summary
+      @test_summary .nil? ? true : @test_summary
+    end
+
     # Reads a file with JSON Xcode summary and reports it.
     #
     # @param    [String] file_path Path for Xcode summary in JSON format.
@@ -74,9 +84,13 @@ module Danger
     end
 
     def messages(xcode_summary)
-      [
-        xcode_summary[:tests_summary_messages]
-      ].flatten.uniq.compact.map(&:strip)
+      if test_summary
+        [
+          xcode_summary[:tests_summary_messages]
+        ].flatten.uniq.compact.map(&:strip)
+      else
+        []
+      end
     end
 
     def warnings(xcode_summary)

data/spec/fixtures/pr_json.json

@@ -0,0 +1,8 @@
+{
+  "head": {
+    "repo": {
+      "html_url": "https://github.com/diogot/danger-xcode_summary"
+    },
+    "sha": "129jef029jf029fj2039fj203f92"
+  }
+}

data/spec/xcode_summary_spec.rb

@@ -13,14 +13,7 @@ module Danger
       before do
         @dangerfile = testing_dangerfile
         @xcode_summary = @dangerfile.xcode_summary
-        @xcode_summary.env.request_source.pr_json = {
-          head: {
-            repo: {
-              html_url: 'https://github.com/diogot/danger-xcode_summary'
-            },
-            sha: '129jef029jf029fj2039fj203f92'
-          }
-        }
+        @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/pr_json.json'))
         @xcode_summary.project_root = '/Users/diogo/src/MyWeight'
       end
 
@@ -28,17 +21,32 @@ module Danger
         expect(@xcode_summary.sticky_summary).to eq false
       end
 
+      it 'sets test_summary to true as default' do
+        expect(@xcode_summary.test_summary).to eq true
+      end
+
       it 'fail if file does not exist' do
         @xcode_summary.report('spec/fixtures/inexistent_file.json')
         expect(@dangerfile.status_report[:errors]).to eq ['summary file not found']
       end
 
       describe 'summary' do
-        it 'formats summary messages' do
-          @xcode_summary.report('spec/fixtures/summary_messages.json')
-          expect(@dangerfile.status_report[:messages]).to eq [
-            'Executed 4 tests, with 0 failures (0 unexpected) in 0.012 (0.017) seconds'
-          ]
+        context 'enabled' do
+          it 'formats summary messages' do
+            @xcode_summary.test_summary = true
+            @xcode_summary.report('spec/fixtures/summary_messages.json')
+            expect(@dangerfile.status_report[:messages]).to eq [
+              'Executed 4 tests, with 0 failures (0 unexpected) in 0.012 (0.017) seconds'
+            ]
+          end
+        end
+
+        context 'disabled' do
+          it 'shows no summary messages' do
+            @xcode_summary.test_summary = false
+            @xcode_summary.report('spec/fixtures/summary_messages.json')
+            expect(@dangerfile.status_report[:messages]).to eq []
+          end
         end
 
         it 'formats compile warnings' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-24 00:00:00.000000000 Z
+date: 2017-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -145,6 +145,7 @@ files:
 - lib/danger_xcode_summary.rb
 - lib/xcode_summary/gem_version.rb
 - lib/xcode_summary/plugin.rb
+- spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
@@ -171,12 +172,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings
   and unit tests results generated from `xcodebuild`.
 test_files:
+- spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json