danger-wcc 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dad1e51611091d1975c1e79440afed906f5d2119
-  data.tar.gz: 608950050d3e357cbd078ac47e2fb1afa89e1086
+  metadata.gz: 2559417d0fc17cc5432a264afe84b98076248c88
+  data.tar.gz: 7bd3382415a0414c6b48214c28806f13356f822f
 SHA512:
-  metadata.gz: e8bb8cd98d97f1664c34e54c893dc8995171317094602fc7034fe37adeca823230ced817c6fd7fd47247edbda6c1de250ab953c74a8f61dc0f3d2dc91ce7e31e
-  data.tar.gz: 48b2f49e8a642e049e2ae34ff85bf3053aea695c4ad3404de4db4c3f828921941dbc929fe1f7cc2dfe82be656cf1c18f8de5aff7198b0bf1025566287e9a9d06
+  metadata.gz: fee811c11bdb726932f1964379bade0ce0a4e61ff6d26acb34734155bd2048abfa707c15188c0e9dae2251a9ae77e53eb5f958433a1cf7c032caab6cc116edf9
+  data.tar.gz: 512a9dba219287d1640e7bf7c4f57c9399e82760e31c0efab9cf6c7692f6af853e285588cc35384056fd95d0acce3e3f23e5d258a39b3fac5d55213e983520e5

data/.rubocop.yml

@@ -2,6 +2,7 @@ AllCops:
   DisplayCopNames: true
   TargetRubyVersion: 2.3
   Exclude:
+    - 'spec/fixtures/**/*'
     # generated by rails/binstubs
     - 'bin/**/*'
 
@@ -46,9 +47,11 @@ Metrics/ModuleLength:
    - 'lib/wcc/utils.rb'
    - 'spec/**/*.rb'
 
-Performance/HashEachMethods:
-  Exclude:
-    - 'spec/**/*.rb'
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
 
 Performance/UnfreezeString:
   Exclude:
@@ -124,10 +127,6 @@ Layout/MultilineAssignmentLayout:
   StyleGuide: '#indent-conditional-assignment'
   Enabled: true
 
-Lint/UnneededDisable:
-  Exclude:
-    - 'spec/fixtures/**/*'
-
 Lint/MissingCopEnableDirective:
   Exclude:
     - 'spec/fixtures/**/*'

data/danger-wcc.gemspec

@@ -1,7 +1,6 @@
-
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'version'
 

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DangerWCC
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/lib/wcc/commit_lint/commit_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class CommitCheck

data/lib/wcc/commit_lint/empty_line_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class EmptyLineCheck < CommitCheck

data/lib/wcc/commit_lint/subject_cap_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class SubjectCapCheck < CommitCheck

data/lib/wcc/commit_lint/subject_length_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class SubjectLengthCheck < CommitCheck

data/lib/wcc/commit_lint/subject_period_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class SubjectPeriodCheck < CommitCheck

data/lib/wcc/commit_lint/subject_words_check.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class SubjectWordsCheck < CommitCheck

data/lib/wcc/defaults.reek

@@ -23,10 +23,10 @@ DuplicateMethodCall:
   allow_calls: []
 FeatureEnvy:
   enabled: true
-  exclude: []
+  exclude: ["Helper"]
 InstanceVariableAssumption:
   enabled: true
-  exclude: []
+  exclude: ["Controller"]
 IrresponsibleModule:
   enabled: false
   exclude: []
@@ -54,7 +54,7 @@ NestedIterators:
   ignore_iterators:
   - tap
 NilCheck:
-  enabled: true
+  enabled: false
   exclude: []
 PrimaDonnaMethod:
   enabled: true
@@ -70,15 +70,15 @@ Syntax:
   enabled: true
   exclude: []
 TooManyConstants:
-  enabled: false
+  enabled: true
   exclude: []
   max_constants: 5
 TooManyInstanceVariables:
-  enabled: false
+  enabled: true
   exclude: []
   max_instance_variables: 5
 TooManyMethods:
-  enabled: false
+  enabled: true
   exclude: []
   max_methods: 15
 TooManyStatements:
@@ -127,5 +127,5 @@ UnusedPrivateMethod:
   exclude: []
 UtilityFunction:
   enabled: true
-  exclude: []
-  public_methods_only: false
+  exclude: ["Helper", "util"]
+  public_methods_only: true

data/lib/wcc/utils.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 require 'git_diff'
@@ -102,12 +101,10 @@ module Utils
   def with_revision(revision)
     Dir.mktmpdir do |dir|
       logger.debug "Checking out revision #{revision} into #{dir}"
-      system "git worktree add #{dir} #{revision.strip}"
+      system "git --work-tree=#{dir} checkout #{revision.strip} -- ."
 
       yield(dir)
     end
-  ensure
-    system 'git worktree prune'
   end
 
   # Creates a git-format diff of the two strings by writing them to temp files

data/spec/fixtures_helper.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 module FixturesHelper

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+ROOT = Pathname.new(File.expand_path('..', __dir__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)
 $LOAD_PATH.unshift((ROOT + 'spec').to_s)
 

data/spec/wcc/commit_lint_spec.rb

@@ -4,7 +4,7 @@
 # https://github.com/jonallured/danger-commit_lint
 # which is licensed under the MIT License
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 TEST_MESSAGES = {
   subject_cap: 'this subject needs a capital',
@@ -24,8 +24,6 @@ NOOP_MESSAGE = Danger::DangerWCC::CommitLint::NOOP_MESSAGE
 SUBJECT_LENGTH_CHECK_MESSAGE = 'Please limit commit subject line to 50 '\
   'characters.'
 
-# rubocop:enable Metrics/LineLength
-
 def report_counts(status_report)
   status_report.values.flatten.count
 end
@@ -388,5 +386,3 @@ module Danger
     end
   end
 end
-
-# rubocop:enable Metrics/ClassLength

data/spec/wcc/github_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 require 'webmock'
 
 module Danger

data/spec/wcc/jshint_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/plugin_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/reek_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/rubocop_exceptions_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/todos_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/utils_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-wcc
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Watermark Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-26 00:00:00.000000000 Z
+date: 2018-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: brakeman