danger-warnings_next_generation 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca8908ac2dbb49d19073752e2f3080d18619db630da9458e4f3cf5754c0e5e10
-  data.tar.gz: 46682178b08d1c87e250bbe9a8910603efcea9f23abb5d3f6ca7ddb31fc66be4
+  metadata.gz: 376645863b3395fb2236750da8d2ea8eccee50a8e99dc805d41f577cd68aa9f6
+  data.tar.gz: 3be7c4925398bcc80ce75690cc78a961cc6466c928e1e8cfd93dc64c9e13ba7c
 SHA512:
-  metadata.gz: 42b11cee07c972faacb608b1dac054dc2f7cec481b693179e74e139045cf5e8f8ae6d874c8b6fa55e0b49be6291856950bea4aaef714dd2142dcb414d75f891a
-  data.tar.gz: 48c2a489c9681d53ca4fe04c3382f955583ab26fc6dc144dc431f56056f3ab6bcf12868f577a709ea74db222f3f55dc7e76aa632db7f961c0cee05155309b137
+  metadata.gz: cb291593edf3dc7001d57bc585e31e1cc61e9ab95dcd79b7ad5cbc65ad70d53fd91fc215d1330170ea8ed7338ba49f65f25e59052df4f5c9c469e6f0a39988de
+  data.tar.gz: bee9338b11923f09d46e5ba11d1be3ee42d3d8e99f4102f6a6c28e8ee27d5f87c2e6d9af2aa66ddb1330cf9b8c8eda970e6832d0228c40a46b8d27b03692e935

data/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.3] - 2019-5-28
+### Fixed
+- Target files not initialized
+- Ignore warning type dash "-"
+
 ## [0.1.2] - 2019-5-27
 ### Fixed
 - Do not post empty tool report

data/lib/warnings_next_generation/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WarningsNextGeneration
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/warnings_next_generation/plugin.rb

@@ -36,7 +36,7 @@ module Danger
     WNG_OVERVIEW_TITLE = "### Warnings Next Generation Overview"
 
     def initialize(dangerfile)
-      @target_files = []
+      @target_files = nil
       @auth = nil
       super(dangerfile)
     end
@@ -200,16 +200,26 @@ module Danger
       type = issue["type"]
       result = ""
 
-      if (category && !category.empty?) || (type && !type.empty?)
+      category_valid_ = category_valid?(category)
+      type_valid_ = type_valid?(type)
+      if category_valid_ || type_valid_
         result = +"["
-        result << category.to_s unless category&.empty?
-        result << " - " if (category && !category.empty?) && (type && !type.empty?)
-        result << type.to_s unless type&.empty?
+        result << category.to_s if category_valid_
+        result << " - " if category_valid_ && type_valid_
+        result << type.to_s if type_valid_
         result << "]"
       end
       result
     end
 
+    def category_valid?(category)
+      category && !category.empty?
+    end
+
+    def type_valid?(type)
+      type && !type.empty? && !type.eql?("-")
+    end
+
     def tool_entries
       json = aggregation_result
       json["tools"]

data/spec/warnings_next_generation_spec.rb

@@ -261,6 +261,21 @@ module Danger
           expect(markdowns.first.message).to include("[TEST_CATEGORY]")
         end
 
+        it "type is dash not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = "TEST_CATEGORY"
+          issue["type"] = "-"
+          details_return_issue(issues)
+          target_files_return_manifest
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_CATEGORY]")
+        end
+
         it "type nil not added" do
           aggregation_return("/assets/aggregation_single.json")
           issues = android_lint_issues

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-warnings_next_generation
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Martin Schwamberger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-27 00:00:00.000000000 Z
+date: 2019-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api