danger-warnings_next_generation 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b52ea983c720acd63ecb4db0b2c3b2d401eaaf72402c4cb6382572bb36e5343c
-  data.tar.gz: 8c7a354b7a3144c6120e160af5ba3fba1b56d3fcb71bc04e2fd0df03b9c5c273
+  metadata.gz: eba6ffd3c7485975a270122fa89b748f08882d7616cc5cee693001789f298a99
+  data.tar.gz: 306a28d2ca2cf49b11c0e43d958380be89ac59bd359b00d4050e2ba3fe5a539e
 SHA512:
-  metadata.gz: 4d752d89c6d88b8d3b0005b799cb7d5d08cc3e3f108dd5a3825d8e489a526d1d2a92ee61bbdba8777217d6481ab3fecdffed8fda6d172f68ebc408007fcd85be
-  data.tar.gz: 6ac93eaa6e2dd50b1a31c311581eea2238e71657d5b54047af8e44a2cc4222d74fd881805bf9768487c545826dfe9b5947072c244f5c3c291731ab416dae44e2
+  metadata.gz: 0d16ae24773329a9ece05fa147eaa68d1cd2cb23d220163a5e67c307d771d9b3db4ca33baef4aab556014222e7763a466204c83030eccbd264972b4ee5b861e7
+  data.tar.gz: f5bb67adfb5df821b6dcffd163a6664ce1ed7c1e63e752c0c45141a90049868556944285150d040c90c6e04c2fb80a1347c7fb6cf0b1f4aab94f1f98b443bb74

data/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.1] - 2019-5-17
+### Fixed
+- Remove line breaks from message to avoid broken tables.
+- Adjust category and type message
+
 ## [0.1.0] - 2019-5-17
 ### Added
 - Add option to pass basic authentication

data/README.md

@@ -101,16 +101,15 @@ This plugin is inspired and works only with the jenkins [warnings-ng-plugin](htt
 |**Severity**|**File**|**Description**|
 |---|---|---|
 |NORMAL|ProductDetailPageFragment.kt:135|[Deprecation] 'getColor(Int): Int' is deprecated. Deprecated in Java|
-|NORMAL|ImageGalleryFragment.kt:40|[] Type mismatch: inferred type is java.util.ArrayList<String!>? but kotlin.collections.ArrayList<String> /* = java.util.ArrayList<String> */ was expected|
-|NORMAL|ImageGalleryFragment.kt:87|[Deprecation] 'getColor(Int): Int' is deprecated. Deprecated in Java|
-|NORMAL|ImageGalleryFragment.kt:90|[Deprecation] 'getColor(Int): Int' is deprecated. Deprecated in Java|
+|NORMAL|ImageGalleryFragment.kt:40|Type mismatch: inferred type is java.util.ArrayList<String!>? but kotlin.collections.ArrayList<String> /* = java.util.ArrayList<String> */ was expected|
+|NORMAL|MyUtil.java:5|[Design - HideUtilityClassConstructorCheck] 'getColor(Int): Int' is deprecated. Deprecated in Java|
 
 
 ### As inline
 ```text
 NORMAL
-[Deprecation]
-getColor(Int): Int' is deprecated. Deprecated in Java
+[Correctness - GradleDependency]
+Obsolete Gradle Dependency A newer version of com.android.support:design than 27.1.1 is available: 28.0.0 This detector looks for usages of libraries where the version you are using is not the current stable release. Using older versions is fine, and there are cases where you deliberately want to stick with an older version. However, you may simply not be aware that a more recent version is available, and that is what this lint check helps find.
 ```
 
 ## Installation

data/lib/warnings_next_generation/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WarningsNextGeneration
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/warnings_next_generation/plugin.rb

@@ -167,9 +167,8 @@ module Danger
         severity = issue["severity"]
         file = File.basename(issue["fileName"])
         line = issue["lineStart"]
-        message = issue["message"]
-        category = issue["category"]
-        table.line(severity, "#{file}:#{line}", "[#{category}] #{message}")
+        message = issue["message"].gsub("\n", " ")
+        table.line(severity, "#{file}:#{line}", "#{category_type(issue)} #{message}")
       end
       content = +"### #{name}\n\n"
       content << table.to_markdown
@@ -185,15 +184,29 @@ module Danger
         file = issue["fileName"].gsub(baseline, "")
         line = issue["lineStart"]
         message = issue["message"]
-        category = issue["category"]
 
         next unless file_in_changeset?(file)
 
-        inline_message = "#{severity}\n[#{category}]\n#{message}"
+        inline_message = "#{severity}\n#{category_type(issue)}\n#{message}"
         message(inline_message, file: file, line: line)
       end
     end
 
+    def category_type(issue)
+      category = issue["category"]
+      type = issue["type"]
+      result = ""
+
+      if (category && !category.empty?) || (type && !type.empty?)
+        result = +"["
+        result << category.to_s unless category&.empty?
+        result << " - " if (category && !category.empty?) && (type && !type.empty?)
+        result << type.to_s unless type&.empty?
+        result << "]"
+      end
+      result
+    end
+
     def tool_entries
       json = aggregation_result
       json["tools"]

data/spec/warnings_next_generation_spec.rb

@@ -217,6 +217,119 @@ module Danger
           expect(message.file).not_to include(JAVA_ALL_BASELINE)
           expect(message.file.chars.first).not_to eql("/")
         end
+
+        it "message will not contain new lines" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          expect(issue["message"]).to include("\n")
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message.split("|").last).not_to include("\n")
+        end
+
+        it "category and type both added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = "TEST_CATEGORY"
+          issue["type"] = "TEST_TYPE"
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_CATEGORY - TEST_TYPE]")
+        end
+
+        it "type empty not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = "TEST_CATEGORY"
+          issue["type"] = ""
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_CATEGORY]")
+        end
+
+        it "type nil not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = "TEST_CATEGORY"
+          issue["type"] = nil
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_CATEGORY]")
+        end
+
+        it "category empty not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = ""
+          issue["type"] = "TEST_TYPE"
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_TYPE]")
+        end
+
+        it "category nil not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = nil
+          issue["type"] = "TEST_TYPE"
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("[TEST_TYPE]")
+        end
+
+        it "category and type empty not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = ""
+          issue["type"] = ""
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).not_to include("[")
+          expect(markdowns.first.message).not_to include("]")
+        end
+
+        it "category and type nil not added" do
+          aggregation_return("/assets/aggregation_single.json")
+          issues = android_lint_issues
+          issue = issues["issues"].first
+          issue["category"] = nil
+          issue["type"] = nil
+          details_return_issue(issues)
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).not_to include("[")
+          expect(markdowns.first.message).not_to include("]")
+        end
       end
     end
   end
@@ -240,6 +353,37 @@ def details_return(file)
   @my_plugin.stubs(:details_result).returns(json)
 end
 
+def details_return_issue(issue)
+  @my_plugin.stubs(:details_result).returns(issue)
+end
+
+def android_lint_issues
+  json = {
+    "issues": [
+      {
+        "baseName": "AndroidManifest.xml",
+        "category": "Internationalization:Bidirectional Text",
+        "columnEnd": 0,
+        "columnStart": 0,
+        "description": "",
+        "fileName": "/var/lib/jenkins/workspace/Jenkins/Examples/android/MR6--danger/repository/mylibrary/src/main/AndroidManifest.xml",
+        "fingerprint": "4F7305CA47CE9CFC2A8E9BE4287E79F8",
+        "lineEnd": 0,
+        "lineStart": 0,
+        "message": "Using RTL attributes without enabling RTL support\nThe project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest\nTo enable right-to-left support, when running on API 17 and higher, you must set the `android:supportsRtl` attribute in the manifest `<application>` element.&#xA;&#xA;If you have started adding RTL attributes, but have not yet finished the migration, you can set the attribute to false to satisfy this lint check.",
+        "moduleName": "",
+        "origin": "android-lint",
+        "packageName": "-",
+        "reference": "3",
+        "severity": "NORMAL",
+        "type": "RtlEnabled",
+      },
+    ],
+  }
+  serialized = JSON.generate(json)
+  JSON.parse(serialized)
+end
+
 def target_files_return_java_all
   @my_plugin.stubs(:target_files).returns(["app/src/main/java/com/projectname/b2bshop/fragment/gallery/ImageGalleryFragment.kt",
                                            "app/src/main/java/com/projectname/b2bshop/webservice/requestqueue/RequestQueue.java",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-warnings_next_generation
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Martin Schwamberger