danger-todoist 1.2.3 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e5a33fddd5d6ffb7debff88c5442cebbde6b43c8
-  data.tar.gz: 9656c5631440b96e047f2ee8a6cb849a58994601
+  metadata.gz: 87a34fb9d9b0148fefa1215d0c4d3fa41349e4db
+  data.tar.gz: a53a69753b59d4b53eada001d6bfbdc7ff44e408
 SHA512:
-  metadata.gz: 7f773004d5e5af4b71485a829bfdfd61302b1cbcb874e4c1773f2dfe139b2d3fbba6138c5c2065c7b7a28613ea925fcb8b0bbf079c07b6f6b355b6b5d575e076
-  data.tar.gz: 4818dfaeb0f66de2bbaefded44b78ea26703ae090981c344fe5ccc95bce002582f7dc81e7ffcfcec52a1fa17b137e0733dd3090451627fc6fa317b0797dea1e3
+  metadata.gz: fe90da46ae4654bd4d335eac952381ceebfed5bb6b415e42b3c82702f05987b385edfd0d57db0d3827f8b38f7840f95aa812286b983a61df0d370a32db7030cb
+  data.tar.gz: 104a01bddd67932185013df9d8d379298c2abf6e29fde20f854385bedba0f0709a1b2a496dc757dc6b528ee8993e1c4277d33b894d38967617d9a27bef1e88cd

data/.gitignore

@@ -4,3 +4,5 @@
 Gemfile.lock
 coverage/
 pkg
+vendor/
+*.gem

data/.rubocop.yml

@@ -4,3 +4,18 @@ Style/StringLiterals:
 
 Style/StructInheritance:
   Enabled: false
+
+PercentLiteralDelimiters:
+  PreferredDelimiters:
+    "%":  ()
+    "%i": ()
+    "%q": ()
+    "%Q": ()
+    "%r": "{}"
+    "%s": ()
+    "%w": ()
+    "%W": ()
+    "%x": ()
+
+Layout/IndentHeredoc:
+  Enabled: false

data/.travis.yml

@@ -4,10 +4,9 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
-  - 2.1.10
-  - 2.3.3
-  - 2.4.0
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
 
 before_install:
   - gem update --system

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master
 
+## 1.3.0
+
+* Report line number for each todo - hanneskaeufler
+* Correctly report todo text with apostrophe - hanneskaeufler
+
 ## 1.2.3
 
 * Update rubies to run in CI - hanneskaeufler

data/Dangerfile

@@ -1,11 +1,17 @@
+is_wip = github.pr_title.include? "[WIP]"
+is_trivial = github.pr_title.include? "[trivial]"
+is_big_pr = git.lines_of_code > 500
+has_insufficient_description = github.pr_body.length < 5
+has_updated_changelog = git.modified_files.include?("CHANGELOG.md")
+
 # Make it more obvious that a PR is a work in progress and shouldn't be merged yet
-warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
+warn("PR is classed as Work in Progress") if is_wip
 
 # Warn when there is a big PR
-warn("Big PR") if git.lines_of_code > 500
+warn("Wow that's a lot of changes. Can we split this up?") if is_big_pr
 
 # Reminder to add changelog entry
-unless git.modified_files.include?("CHANGELOG.md")
+if !has_updated_changelog && !is_trivial
   fail("Please include a CHANGELOG entry.", sticky: false)
 end
 
@@ -16,6 +22,6 @@ todoist.print_todos_table
 
 # Mainly to encourage writing up some reasoning about the PR, rather than
 # just leaving a title
-if github.pr_body.length < 5
+if has_insufficient_description
   fail "Please provide a summary in the Pull Request description"
 end

data/README.md

@@ -65,4 +65,7 @@ todoist.todos.each { |todo| puts todo.text }</pre>
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
 
+## Licence
 
+This project is MIT licenced. Parts of the code (see class `Patch`) are heavily
+inspired by [ruby-git_diff_parser](https://github.com/packsaddle/ruby-git_diff_parser).

data/danger-todoist.gemspec

@@ -1,4 +1,3 @@
-# coding: utf-8
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "todoist/gem_version.rb"
@@ -26,13 +25,13 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
 
   # Testing support
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0"
   spec.add_development_dependency "rspec", "~> 3.4"
   spec.add_development_dependency "simplecov", "~> 0.12"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0"
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.41"
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "rubocop", "0.50"
+  spec.add_development_dependency "yard", "~> 0.9.12"
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency "guard", "~> 2.14"

data/lib/danger_plugin.rb

@@ -1,3 +1,4 @@
 require "todoist/plugin"
 require "todoist/diff_todo_finder"
+require "todoist/diff_inline_todo_finder"
 require "todoist/todo"

data/lib/todoist/diff_inline_todo_finder.rb

@@ -0,0 +1,22 @@
+module Danger
+  # Identify inline todos in a set of diffs
+  class DiffInlineTodoFinder
+    def initialize(keywords)
+      @keywords = keywords
+    end
+
+    def call(diffs)
+      diffs.map do |diff|
+        diff.patch.scan(/\+ .{3,}(#{keywords})[\s:]{1}(.+)$/).map do |match|
+          Todo.new(diff.path, match[1].strip)
+        end
+      end.flatten
+    end
+
+    private
+
+    def keywords
+      @keywords.join("|")
+    end
+  end
+end

data/lib/todoist/diff_todo_finder.rb

@@ -2,45 +2,110 @@ module Danger
   # Identify todos in a set of diffs
   class DiffTodoFinder
     def initialize(keywords)
-      @keywords = keywords
+      @regexp = todo_regexp(keywords)
     end
 
-    def find_diffs_containing_todos(diffs)
-      todos = []
-      regexp = todo_regexp
-      diffs.each do |diff|
-        matches = diff.patch.scan(regexp)
-        next if matches.empty?
-
-        matches.each do |match|
-          todos << Danger::Todo.new(diff.path, clean_todo_text(match))
-        end
-      end
-      todos
+    def call(diffs)
+      diffs
+        .map { |diff| MatchesInDiff.new(diff, diff.patch.scan(@regexp)) }
+        .select(&:todo_matches?)
+        .map(&:all_todos)
+        .flatten
     end
 
     private
 
-    def clean_todo_text(match)
-      comment_indicator, _, entire_todo = match
-      entire_todo.gsub(comment_indicator, "")
-                 .delete("\n")
-                 .strip
-    end
-
     # this is quite a mess now ... I knew it would haunt me.
     # to aid debugging, this online regexr can be
     # used: http://rubular.com/r/DPkoE2ztpn
     # the regexp uses backreferences to match the comment indicator multiple
     # times if possible
-    def todo_regexp
+    def todo_regexp(keywords)
       /
       (?<comment_indicator>^\+\s*[^a-z0-9\+\s]+)
       (\n\+)?\s+
-      (?<todo_indicator>#{@keywords.join("|")})[\s:]{1}
+      (?<todo_indicator>#{keywords.join("|")})[\s:]{1}
       (?<entire_text>(?<text>[^\n]*)
-      (?<rest>\n\k<comment_indicator>\s*[\w .]*)*)
+      (?<rest>\n\k<comment_indicator>\s*[\w .']*)*)
       /ixm
     end
   end
+
+  # Identify todos in a single diff
+  class MatchesInDiff < Struct.new(:diff, :matches)
+    def todo_matches?
+      !matches.empty?
+    end
+
+    def all_todos
+      matches.map { |match| build_todo(diff.path, match) }
+    end
+
+    private
+
+    def line_number(match)
+      _, _, _, first_text = match
+      Patch.new(diff.patch).changed_lines.each do |line|
+        return line.number if line.content.include? first_text
+      end
+      raise TextNotFoundInPatchError
+    end
+
+    def build_todo(path, match)
+      Danger::Todo.new(path, cleaned_todo_text(match), line_number(match))
+    end
+
+    def cleaned_todo_text(match)
+      comment_indicator, _, entire_todo = match
+      entire_todo.gsub(comment_indicator, "")
+                 .delete("\n")
+                 .strip
+    end
+
+    # Parsed patch
+    class Patch
+      RANGE_INFORMATION_LINE = /^@@ .+\+(?<line_number>\d+),/
+      MODIFIED_LINE = /^\+(?!\+|\+)/
+      REMOVED_LINE = /^[-]/
+      NOT_REMOVED_LINE = /^[^-]/
+
+      def initialize(body)
+        @body = body
+      end
+
+      # rubocop:disable Metrics/MethodLength
+      def changed_lines
+        line_number = 0
+
+        lines_with_index
+          .each_with_object([]) do |(content, patch_position), lines|
+            case content
+            when RANGE_INFORMATION_LINE
+              line_number = Regexp.last_match[:line_number].to_i
+            when MODIFIED_LINE
+              lines << Line.new(content, line_number, patch_position)
+              line_number += 1
+            when NOT_REMOVED_LINE
+              line_number += 1
+            end
+          end
+      end
+      # rubocop:enable Metrics/MethodLength
+
+      def lines
+        @body.lines
+      end
+
+      def lines_with_index
+        lines.each_with_index
+      end
+    end
+
+    # Parsed line
+    class Line < Struct.new(:content, :number, :patch_position)
+    end
+  end
+
+  class TextNotFoundInPatchError < RuntimeError
+  end
 end

data/lib/todoist/gem_version.rb

@@ -1,3 +1,3 @@
 module Todoist
-  VERSION = "1.2.3".freeze
+  VERSION = "1.3.0".freeze
 end

data/lib/todoist/plugin.rb

@@ -96,7 +96,7 @@ module Danger
       markdown("- #{file}")
       todos
         .select(&:text)
-        .each { |todo| markdown("  - #{todo.text}") }
+        .each { |todo| markdown("  - Line #{todo.line_number}: #{todo.text}") }
     end
 
     def call_method_for_todos(method)
@@ -108,8 +108,10 @@ module Danger
       @todos = []
       return if files_of_interest.empty?
 
-      @todos = DiffTodoFinder.new(keywords)
-                             .find_diffs_containing_todos(diffs_of_interest)
+      @todos = finders
+               .map { |finder_class| finder_class.new(keywords) }
+               .map { |finder| finder.call(diffs_of_interest) }
+               .flatten
     end
 
     def keywords
@@ -132,7 +134,7 @@ module Danger
         diff = EmptyDiff.new
         begin
           diff = git.diff_for_file(file)
-        rescue
+        rescue NoMethodError
           log_unable_to_find_diff(file.inspect)
         end
         diff
@@ -142,6 +144,10 @@ module Danger
     def log_unable_to_find_diff(file)
       markdown("* danger-todoist was unable to determine diff for \"#{file}\".")
     end
+
+    def finders
+      [DiffTodoFinder]
+    end
   end
 
   # Null object incase a diff cannot be determined

data/lib/todoist/todo.rb

@@ -1,4 +1,4 @@
 module Danger
-  class Todo < Struct.new(:file, :text)
+  class Todo < Struct.new(:file, :text, :line_number)
   end
 end

data/spec/diff_inline_todo_finder_spec.rb

@@ -0,0 +1,35 @@
+require File.expand_path("../spec_helper", __FILE__)
+
+module Danger
+  describe Danger::DiffInlineTodoFinder do
+    let(:subject) { Danger::DiffInlineTodoFinder.new(%w(TODO FIXME)) }
+
+    describe "#call" do
+      it "finds todos inline after code" do
+        patch = <<PATCH
++ function bla() {}; // TODO: fix this
+PATCH
+
+        diff = sample_diff(patch)
+
+        todos = subject.call([diff])
+
+        expect(todos.first.text).to eq("fix this")
+      end
+
+      it "doesn't find floating todos" do
+        patch = <<PATCH
++ # TODO: practice you must
++ def practice
++   return false
++ end
++ # FIXME: with you the force is
+PATCH
+
+        todos = subject.call([sample_diff(patch)])
+
+        expect(todos).to be_empty
+      end
+    end
+  end
+end

data/spec/diff_todo_finder_spec.rb

@@ -8,12 +8,12 @@ module Danger
       Danger::DiffTodoFinder.new(%w(TODO FIXME))
     end
 
-    describe "#find_diffs_containing_todos" do
+    describe "#call" do
       %w(TODO TODO: todo todo: FIXME fixme FIXME: fixme).each do |marker|
         it "identifies a new '#{marker}' as a todo" do
           diff = sample_diff("+ # #{marker} some todo")
 
-          todos = subject.find_diffs_containing_todos([diff])
+          todos = subject.call([diff])
 
           expect(todos).to_not be_empty
         end
@@ -23,16 +23,17 @@ module Danger
         diff = sample_diff("+ # BUG some todo")
 
         subject = described_class.new(["BUG"])
-        todos = subject.find_diffs_containing_todos([diff])
+        todos = subject.call([diff])
 
         expect(todos).to_not be_empty
+        expect(todos.first.line_number).to be 0
       end
 
       it "doesnt crash but also doesnt find anything with empty keywords" do
         diff = sample_diff("+ # BUG some todo")
 
         subject = described_class.new([])
-        todos = subject.find_diffs_containing_todos([diff])
+        todos = subject.call([diff])
 
         expect(todos).to be_empty
       end
@@ -42,7 +43,7 @@ module Danger
         it "identifies todos in languages with '#{comment}' as comments" do
           diff = sample_diff("+ #{comment} TODO: some todo")
 
-          todos = subject.find_diffs_containing_todos([diff])
+          todos = subject.call([diff])
 
           expect(todos).to_not be_empty
         end
@@ -51,7 +52,7 @@ module Danger
       it "does not identify removed todos as a todo" do
         diff = sample_diff("- TODO: some todo")
 
-        todos = subject.find_diffs_containing_todos([diff])
+        todos = subject.call([diff])
 
         expect(todos).to be_empty
       end
@@ -63,7 +64,7 @@ module Danger
         "+ def todo foo",
         "+ * this looks like a todo but isnt",
         "+ TODO_REGEXP = /",
-        "+          todos = subject.find_diffs_containing_todos(diffs)",
+        "+          todos = subject.call(diffs)",
         "++ # FIXME: with you the force is",
         "+ TODO: foo",
         "+ TODO",
@@ -72,7 +73,7 @@ module Danger
         it "does not identify occurences in '#{patch}'" do
           diff = sample_diff("some/file.rb")
 
-          todos = subject.find_diffs_containing_todos([diff])
+          todos = subject.call([diff])
 
           expect(todos).to be_empty
         end
@@ -81,7 +82,7 @@ module Danger
       it "identifies the todo text as well" do
         diff = sample_diff("+ # TODO: practice you must")
 
-        todos = subject.find_diffs_containing_todos([diff])
+        todos = subject.call([diff])
 
         expect(todos.first.text).to eql("practice you must")
       end
@@ -95,7 +96,7 @@ module Danger
 + # FIXME: with you the force is
 PATCH
 
-        todos = subject.find_diffs_containing_todos([sample_diff(patch)])
+        todos = subject.call([sample_diff(patch)])
 
         expect(todos.map(&:text))
           .to eql(["practice you must", "with you the force is"])
@@ -112,7 +113,7 @@ PATCH
 +  */
 PATCH
 
-        todos = subject.find_diffs_containing_todos([sample_diff(patch)])
+        todos = subject.call([sample_diff(patch)])
 
         expect(todos.map(&:text)).to eql(%w(something another))
       end
@@ -126,14 +127,21 @@ PATCH
 + # TODO: this is a
 + # multiline comment as well
 + function bla() {};
++  # TODO: I'd rather not have this here ...
++  # because it's probably just a bit of code that we can reimplement
++  # or steal
 PATCH
 
-        todos = subject.find_diffs_containing_todos([sample_diff(patch)])
+        todos = subject.call([sample_diff(patch)])
 
         expect(todos.map(&:text))
           .to eql(["this should be parsed as a single item.",
-                   "this is a multiline comment as well"])
+                   "this is a multiline comment as well",
+                   "I'd rather not have this here ... because it's probably "\
+                   "just a bit of code that we can reimplement or steal"])
       end
     end
   end
+  # rubocop:enable Metrics/BlockLength
 end
+# rubocop:enable Metrics/ModuleLength

data/spec/fixtures/multiline_todo_patch.diff

@@ -0,0 +1,14 @@
+diff --git a/danger-todoist.gemspec b/danger-todoist.gemspec
+index f5b474f..4c75b45 100644
+--- a/danger-todoist.gemspec
++++ b/danger-todoist.gemspec
+@@ -19,6 +19,9 @@ Gem::Specification.new do |spec|
+   spec.required_ruby_version = ">= 2.0.0"
+ 
+   spec.add_runtime_dependency "danger-plugin-api", "~> 1.0"
++  # TODO: I'd rather not have this here ...
++  # because it's probably just a bit of code that we can reimplement
++  # or steal
+   spec.add_runtime_dependency "git_diff_parser", "~> 3.1.0"
+ 
+   # General ruby development

data/spec/fixtures/sample_patch.diff

@@ -0,0 +1,36 @@
+diff --git a/lib/todoist/diff_todo_finder.rb b/lib/todoist/diff_todo_finder.rb
+index b58809b..1ecc4f0 100644
+--- a/lib/todoist/diff_todo_finder.rb
++++ b/lib/todoist/diff_todo_finder.rb
+@@ -9,7 +9,6 @@ def initialize(keywords)
+ 
+     def call(diffs)
+       diffs
+-        .each { |diff| debug(diff) }
+         .map { |diff| MatchesInDiff.new(diff, diff.patch.scan(@regexp)) }
+         .select(&:todo_matches?)
+         .map(&:all_todos)
+@@ -18,12 +17,6 @@ def call(diffs)
+ 
+     private
+ 
+-    def debug(diff)
+-      # GitDiffParser::Patches.new(diff.patch).each do |p|
+-      #   puts p.changed_lines.inspect
+-      # end
+-    end
+-
+     # this is quite a mess now ... I knew it would haunt me.
+     # to aid debugging, this online regexr can be
+     # used: http://rubular.com/r/DPkoE2ztpn
+@@ -54,9 +47,11 @@ def all_todos
+ 
+     def line_number(match)
+       _, todo_indicator = match
++      # TODO: What if there are multiple matching lines?
+       GitDiffParser::Patch.new(diff.patch).changed_lines.each do |line|
+         return line.number if line.content =~ /#{todo_indicator}/
+       end
++      # TODO: thats not gonna fly
+       -1
+     end

data/spec/matches_in_diff_spec.rb

@@ -0,0 +1,76 @@
+require File.expand_path("../spec_helper", __FILE__)
+
+module Danger
+  # rubocop:disable Metrics/BlockLength
+  describe Danger::MatchesInDiff do
+    describe "#todo_matches?" do
+      it "is false for no matches" do
+        expect(described_class.new("", []).todo_matches?).to be false
+      end
+
+      it "is true for some matches" do
+        expect(described_class.new("", [["hey"]]).todo_matches?).to be true
+      end
+    end
+
+    describe "#all_todos" do
+      it "returns the correct line number for the first todo" do
+        diff = sample_diff_fixture("sample_patch.diff")
+        subject = described_class.new(
+          diff,
+          [[
+            "+      #",
+            "TODO",
+            "What if there are multiple matching lines?",
+            "What if there are multiple matching lines?"
+          ]]
+        )
+        expect(subject.all_todos.first.line_number).to eq 50
+      end
+
+      it "returns the correct line number for the second todo" do
+        diff = sample_diff_fixture("sample_patch.diff")
+        subject = described_class.new(
+          diff,
+          [[
+            "+      #",
+            "TODO",
+            "thats not gonna fly",
+            "thats not gonna fly"
+          ]]
+        )
+        expect(subject.all_todos.first.line_number).to eq 54
+      end
+
+      it "returns the correct line number for a multiline todo" do
+        diff = sample_diff_fixture("multiline_todo_patch.diff")
+        subject = described_class.new(
+          diff,
+          [[
+            "+      #",
+            "TODO",
+            " I'd rather not have this here ...\n+  # because it's probably "\
+            "just a bit of code that we can reimplement\n+  # or steal",
+            " I'd rather not have this here ...", "\n+  # or steal"
+          ]]
+        )
+        expect(subject.all_todos.first.line_number).to eq 22
+      end
+
+      it "raises when the todo string was not found in the patch" do
+        diff = sample_diff_fixture("sample_patch.diff")
+        subject = described_class.new(
+          diff,
+          [[
+            "+      #",
+            "TODO",
+            "",
+            "definately not contained in the patch"
+          ]]
+        )
+        expect { subject.all_todos }.to raise_error(TextNotFoundInPatchError)
+      end
+    end
+  end
+  # rubocop:enable Metrics/BlockLength
+end

data/spec/spec_helper.rb

@@ -80,7 +80,13 @@ end
 def sample_diff(patch)
   Git::Diff::DiffFile.new(
     "base",
+    src: "src",
+    dst: "dst",
     path:  "some/file.rb",
     patch: patch
   )
 end
+
+def sample_diff_fixture(filename)
+  sample_diff(File.read(File.expand_path("./fixtures/#{filename}", __dir__)))
+end

data/spec/todoist_spec.rb

@@ -79,10 +79,10 @@ PATCH
             [
               "#### Todos left in files",
               "- some/file.rb",
-              "  - some todo",
-              "  - more todo in same file",
+              "  - Line 0: some todo",
+              "  - Line 3: more todo in same file",
               "- another/stuff.rb",
-              "  - another todo"
+              "  - Line 0: another todo"
             ]
           )
         end
@@ -149,4 +149,6 @@ PATCH
       end
     end
   end
+  # rubocop:enable Metrics/BlockLength
 end
+# rubocop:enable Metrics/ModuleLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-todoist
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.3.0
 platform: ruby
 authors:
 - Hannes Käufler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-08 00:00:00.000000000 Z
+date: 2018-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -53,75 +53,75 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '3.4'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.50'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.50'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.12
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.12
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -199,11 +199,16 @@ files:
 - danger-todoist.gemspec
 - lib/danger_plugin.rb
 - lib/danger_todoist.rb
+- lib/todoist/diff_inline_todo_finder.rb
 - lib/todoist/diff_todo_finder.rb
 - lib/todoist/gem_version.rb
 - lib/todoist/plugin.rb
 - lib/todoist/todo.rb
+- spec/diff_inline_todo_finder_spec.rb
 - spec/diff_todo_finder_spec.rb
+- spec/fixtures/multiline_todo_patch.diff
+- spec/fixtures/sample_patch.diff
+- spec/matches_in_diff_spec.rb
 - spec/spec_helper.rb
 - spec/todoist_spec.rb
 homepage: https://github.com/hanneskaeufler/danger-todoist
@@ -232,6 +237,10 @@ specification_version: 4
 summary: Marking something with a todo is very common during implementing a new feature.
   Often those todos will get missed in code review.
 test_files:
+- spec/diff_inline_todo_finder_spec.rb
 - spec/diff_todo_finder_spec.rb
+- spec/fixtures/multiline_todo_patch.diff
+- spec/fixtures/sample_patch.diff
+- spec/matches_in_diff_spec.rb
 - spec/spec_helper.rb
 - spec/todoist_spec.rb