danger-todoist 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ece9544107e09397ee672b6f3a0f0aad2797c664
-  data.tar.gz: 93e8a542c62490dbb51f3adf378abc17f72f92c5
+  metadata.gz: 910d2aa0929cc3af3260a88dfbf1a98fe27f3435
+  data.tar.gz: 18aa2c8dafb84287ff5e97051cb7d31f2cae6b8e
 SHA512:
-  metadata.gz: 8ba5ef9e357c74f9194bac0348134d761cb4a8bdf9265f0879dc2414ac464be5fb17545fbf05b4de3282e85f608824825f8f6f33a2fe59e85a54dd15c43dac7d
-  data.tar.gz: 27351b576938f30b197705f3731af8b382d3be794208e6c72a7e68ecadca63a9e220afbf2dd2a6b7ea93b133c5f2c0df05e683e4ee8749ed3de9c2855ae92cb5
+  metadata.gz: c52239b8a95725323d644886222bd174f3a5cc90d57ffde7b37a0b750ef8269aada7977dc557b1bf29a3459a0b2943c7c07e1473813686ef0471b4f658f07daf
+  data.tar.gz: 5e2a73ded27db0de67804511aa9cb7d23892f6725e1f3c3f70c09d8b1210571780aaf0e6c7b9fc3ca612900acf015ace3bf072f100bc5aafdc1d10cdc0bc864e

data/.codeclimate.yml

@@ -1,3 +1,6 @@
 engines:
   fixme:
     enabled: false
+ratings:
+  paths:
+    "**.rb"

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master
 
+## 1.2.1
+
+* fix issue #32 crash on nil - hanneskaeufler
+
 ## 1.2.0
 
 * fixes crash when git returns nil - hanneskaeufler

data/lib/todoist/gem_version.rb

@@ -1,3 +1,3 @@
 module Todoist
-  VERSION = "1.2.0".freeze
+  VERSION = "1.2.1".freeze
 end

data/lib/todoist/plugin.rb

@@ -113,22 +113,23 @@ module Danger
     end
 
     def keywords
-      return @keywords unless @keywords.nil?
-      DEFAULT_KEYWORDS
+      @keywords || DEFAULT_KEYWORDS
     end
 
     def message
-      return @message unless @message.nil?
-      DEFAULT_MESSAGE
+      @message || DEFAULT_MESSAGE
     end
 
     def files_of_interest
       git.modified_files + git.added_files
     end
 
+    # for whatever reason nils/false weird things creep
+    # into the files_of_interest. We have to make sure to only
+    # try to look up diffs for actual filepaths (strings)
     def diffs_of_interest
       files_of_interest
-        .compact
+        .select { |file| file.is_a?(String) }
         .map { |file| git.diff_for_file(file) }
     end
   end

data/spec/diff_todo_finder_spec.rb

@@ -1,6 +1,7 @@
 require File.expand_path("../spec_helper", __FILE__)
 
 module Danger
+  # rubocop:disable Metrics/BlockLength
   describe Danger::DiffTodoFinder do
     let(:subject) do
       Danger::DiffTodoFinder.new(%w(TODO FIXME))

data/spec/todoist_spec.rb

@@ -2,6 +2,7 @@ require File.expand_path("../spec_helper", __FILE__)
 
 # rubocop:disable Metrics/ModuleLength
 module Danger
+  # rubocop:disable Metrics/BlockLength
   describe Danger::DangerTodoist do
     it "should be a plugin" do
       expect(Danger::DangerTodoist.new(nil)).to be_a Danger::Plugin
@@ -131,9 +132,9 @@ PATCH
       end
 
       it "does not raise when git returns nil" do
-        invalid = [nil]
+        invalid = [nil, 0, false]
         allow(@dangerfile.git).to receive(:modified_files).and_return(invalid)
-        allow(@dangerfile.git).to receive(:added_files).and_return([])
+        allow(@dangerfile.git).to receive(:added_files).and_return(invalid)
 
         expect { @todoist.warn_for_todos }.to_not raise_error
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-todoist
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Hannes Käufler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-21 00:00:00.000000000 Z
+date: 2017-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -226,7 +226,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Marking something with a todo is very common during implementing a new feature.