danger-the_coding_love 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c000079295312c28efe06f6198dee7fd9df969a91778f9df8698e9fccec97a97
-  data.tar.gz: 431605a4ad0757b66bc70dc2d07f5bb0645a5aa10ed6969def96b525ba8c8e0d
+  metadata.gz: b410f9e8a7fff62174696e41797ee1eb61580a3085e0316bedea8bced6f45f97
+  data.tar.gz: 81bb3876751e59d78377f7633e16a0a32efe0bf5c74248ca43eb966d26fd6829
 SHA512:
-  metadata.gz: ce85980c614cd0ef9f41264aa0471e6aeb84f2735496b04fdfad839e0cb21bfd1deab4cf55e34c65e9895af6650404b70e04c0e48a823609d7533358cc1c397e
-  data.tar.gz: ac9bccae7b2ef6e2d4797070187ed58751faf11db8c23899cd18da7db53846e7be39e91b23eae74bf6ac09edae9b47b453dd014545fa113149b9f14c0d5c3900
+  metadata.gz: 3851ff21832a8f7a6dc78d060a631604234f403761bb3f37761ce47e3e62458b47bcf1e00452549b30d683c2b400697d41471c063ab0b4c56910ae197ae7a443
+  data.tar.gz: e8cfd5f69fb64d32c70552e5a8fc51c906ed3edb94c90857f580050f95de48f962d18ae09ad93053d2180f17eeae24edfada708bf59f3234fcce379d613290b4

data/.travis.yml

@@ -4,7 +4,6 @@ cache:
     - bundle
 
 rvm:
-  - 2.1.3
   - 2.3.1
 
 script:

data/Gemfile.lock

@@ -1,50 +1,51 @@
 PATH
   remote: .
   specs:
-    danger-the_coding_love (0.0.6)
+    danger-the_coding_love (0.0.7)
       danger-plugin-api (~> 1.0)
-      nokogiri
+      nokogiri (>= 1.8.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
+    addressable (2.6.0)
       public_suffix (>= 2.0.2, < 4.0)
     claide (1.0.2)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.1)
+    coderay (1.1.2)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.6.1)
+    danger (6.0.9)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.5)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
       octokit (~> 4.7)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.2.5)
-    faraday (0.15.2)
+    diff-lcs (1.3)
+    faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
+    faraday-http-cache (2.0.0)
       faraday (~> 0.8)
-    ffi (1.9.14)
+    ffi (1.11.1)
     formatador (0.2.5)
-    git (1.4.0)
-    guard (2.14.0)
+    git (1.5.0)
+    guard (2.15.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -55,57 +56,57 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.16.2)
+    kramdown (2.1.0)
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
-    method_source (0.8.2)
-    mini_portile2 (2.3.0)
-    multipart-post (2.0.0)
+    lumberjack (1.0.13)
+    method_source (0.9.2)
+    mini_portile2 (2.4.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
     no_proxy_fix (0.1.2)
-    nokogiri (1.8.2)
-      mini_portile2 (~> 2.3.0)
-    notiffany (0.1.1)
+    nokogiri (1.10.3)
+      mini_portile2 (~> 2.4.0)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.9.0)
+    octokit (4.14.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    pry (0.10.4)
+    pry (0.12.2)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    public_suffix (2.0.5)
+      method_source (~> 0.9.0)
+    public_suffix (3.1.1)
     rake (10.5.0)
-    rb-fsevent (0.9.8)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rb-fsevent (0.10.3)
+    rb-inotify (0.10.0)
+      ffi (~> 1.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.2)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.2)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
-    slop (3.6.0)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
-    thor (0.19.4)
-    unicode-display_width (1.3.3)
-    yard (0.9.5)
+    thor (0.20.3)
+    unicode-display_width (1.6.0)
+    yard (0.9.20)
 
 PLATFORMS
   ruby
@@ -119,7 +120,7 @@ DEPENDENCIES
   pry
   rake (~> 10.0)
   rspec (~> 3.4)
-  yard (~> 0.8)
+  yard (>= 0.9.11)
 
 BUNDLED WITH
-   1.16.1
+   1.17.2

data/lib/the_coding_love/gem_version.rb

@@ -1,3 +1,3 @@
 module TheCodingLove
-  VERSION = "0.0.6".freeze
+  VERSION = "0.0.7".freeze
 end

data/lib/the_coding_love/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   # Prints markdown containing a random post from
   # [thecodinglove.com](http://thecodinglove.com)
@@ -15,36 +17,40 @@ module Danger
     # @return  [text, image_url]
     #
     def random
-      require 'open-uri'
-      require 'nokogiri'
-
-      @main_page_doc = Nokogiri::HTML(open('https://thecodinglove.com'))
-      random_love_page_url = @main_page_doc.at_xpath("//a[@class='nav-link']/@href").to_s
-
-      text, image_url = atUrl(random_love_page_url)
+      text, image_url = at_url(random_post_url)
 
       markdown("------\n#{text}\n--\n![alt text](#{image_url} \"thecodinglove.com\")")
 
       [text, image_url]
     end
 
+    # Returns url to random post from thecodinglove.com
+    #
+    # @return [url]
+    #
+    def random_post_url
+      require 'open-uri'
+      require 'nokogiri'
+      @main_page_doc = Nokogiri::HTML(open('https://thecodinglove.com'))
+      random_love_page_url = @main_page_doc.at_xpath("//ul[@class='navbar-nav mr-auto']/a/@href").to_s
+      random_love_page_url
+    end
+
     # Returns text and url containing given post from thecodinglove.com url
     #
     # @return  [text, image_url]
     #
-    def atUrl(love_page_url)
-      @doc = Nokogiri::HTML(open(love_page_url))
-      @doc = @doc.at_xpath("//div[@class='blog-post']")
+    def at_url(love_page_url)
+      @doc = Nokogiri::HTML(URI.parse(love_page_url).open)
+      @doc = @doc.at_xpath("//div[@class='blog-post content-single']")
 
       text = @doc.at_xpath('//h1').text
       image_url = @doc.at_xpath("//div[@class='blog-post-content']/p/img/@src").to_s
       video_gif_url = @doc.at_xpath("//div[@class='blog-post-content']/p/video//object[@type='image/gif']/@data").to_s
 
-      if image_url.empty?
-        return [text, video_gif_url]
-      else
-        return [text, image_url]
-      end
+      return [text, video_gif_url] if image_url.empty?
+
+      [text, image_url]
     end
 
     def self.instance_name

data/spec/the_coding_love_spec.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 require File.expand_path('spec_helper', __dir__)
 
+# Module tests
 module Danger
   describe Danger::DangerTheCodingLove do
     it 'should be a plugin' do
@@ -12,6 +15,13 @@ module Danger
         @the_coding_love = @dangerfile.the_coding_love
       end
 
+      it 'prints a random url' do
+        rnd_url = @the_coding_love.random_post_url
+        
+        # expect(rnd_url).to eq('') # for development, should not be empty
+        expect(rnd_url).not_to be_empty
+      end
+
       it 'prints a random post' do
         post = @the_coding_love.random
 
@@ -21,7 +31,7 @@ module Danger
       end
 
       it 'prints an image post' do
-        post = @the_coding_love.atUrl('https://thecodinglove.com/ai-in-cars-is-getting-better')
+        post = @the_coding_love.at_url('https://thecodinglove.com/ai-in-cars-is-getting-better')
 
         expect(post[0]).not_to be_empty
         expect(post[1]).not_to be_empty
@@ -30,7 +40,7 @@ module Danger
       end
 
       it 'prints a gif post' do
-        post = @the_coding_love.atUrl('https://thecodinglove.com/when-i-commit-push-right-after-someone-has')
+        post = @the_coding_love.at_url('https://thecodinglove.com/when-i-commit-push-right-after-someone-has')
 
         expect(post[0]).not_to be_empty
         expect(post[1]).not_to be_empty

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-the_coding_love
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Valerio Mazzeo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-29 00:00:00.000000000 Z
+date: 2019-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api