danger-swiftlint 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b673a12b035e24daddf4915729da974602975f99
-  data.tar.gz: edd6a4eb9fd5bb1a8a9dd08da756c13e8a5a58ba
+  metadata.gz: 24ffc13551a8fc301e52e246257e507939190185
+  data.tar.gz: f194d6b75fc9dd688cd624a6dd61bac56cf691d8
 SHA512:
-  metadata.gz: 002d49f84c99347a74976ea6bdd45ab4507819db78065171446247481abed27986480af1af6280226b65a6f3f26df6ec7c4d9fb94f13274e16b73c7ee7dd755d
-  data.tar.gz: 533e487912bda9b981e9ac2354eba7c44a9e3f7ab6af20f3692886eb907fefe36defd49b2cc118d470b5247c85455424a0ebba77d360cb046ebb2733a0018abd
+  metadata.gz: 4029424658ca97f7548a22a01b57c587b74c6a2448eb7ece889d79b433e47d398f490f922995d071e90b1c419f6ea7a613099338eda60588b110af19745f5b1e
+  data.tar.gz: 0b5b53d7fb22979333e2ad1ced741e39e017ab7b89ddddee47c41ddac716523185e4c1c2dde69b31e4d884081f77611b24ffb768071f15e95baf6ea9f24c54f1

data/Changelog.md

@@ -2,6 +2,10 @@
 
 ## Current Master
 
+## 0.5.0
+
+- Bump managed SwiftLint version to 0.18.1
+
 ## 0.4.1
 
 - Fixes deleted files being added to the list of files to lint. See [#34](https://github.com/ashfurrow/danger-swiftlint/pull/34).

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-swiftlint (0.4.1)
+    danger-swiftlint (0.5.0)
       danger
       rake (~> 10.0)
       thor (~> 0.19)
@@ -9,7 +9,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.0)
+    addressable (2.5.1)
       public_suffix (~> 2.0, >= 2.0.2)
     bacon (1.2.0)
     claide (1.0.1)
@@ -18,11 +18,10 @@ GEM
       nap
       open4 (~> 1.3)
     coderay (1.1.1)
-    colored (1.2)
     colored2 (3.1.2)
-    cork (0.2.0)
-      colored (~> 1.2)
-    danger (4.3.0)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (5.1.0)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -33,15 +32,15 @@ GEM
       kramdown (~> 1.5)
       octokit (~> 4.2)
       terminal-table (~> 1)
-    diff-lcs (1.2.5)
-    faraday (0.11.0)
+    diff-lcs (1.3)
+    faraday (0.12.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
-    ffi (1.9.10)
+    ffi (1.9.18)
     formatador (0.2.5)
     git (1.3.0)
-    guard (2.14.0)
+    guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (~> 1.0)
@@ -51,7 +50,7 @@ GEM
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
-    guard-rspec (4.7.2)
+    guard-rspec (4.7.3)
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
@@ -59,46 +58,46 @@ GEM
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
+    lumberjack (1.0.11)
     metaclass (0.0.4)
     method_source (0.8.2)
-    mocha (1.1.0)
+    mocha (1.2.1)
       metaclass (~> 0.0.1)
-    mocha-on-bacon (0.2.2)
+    mocha-on-bacon (0.2.3)
       mocha (>= 0.13.0)
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.0)
+    notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.6.2)
+    octokit (4.7.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     prettybacon (0.0.2)
       bacon (~> 1.2)
-    pry (0.10.3)
+    pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
     public_suffix (2.0.5)
     rake (10.5.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
+    rb-fsevent (0.9.8)
+    rb-inotify (0.9.8)
       ffi (>= 0.5.0)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)
       faraday (~> 0.8, < 1.0)
@@ -106,7 +105,7 @@ GEM
     slop (3.6.0)
     terminal-table (1.7.3)
       unicode-display_width (~> 1.1.1)
-    thor (0.19.1)
+    thor (0.19.4)
     unicode-display_width (1.1.3)
 
 PLATFORMS

data/lib/danger_plugin.rb

@@ -119,8 +119,10 @@ module Danger
         {"excluded" => []}
       end
 
+      excluded_paths = config['excluded'] || []
+
       # Extract excluded paths
-      return config['excluded'].
+      return excluded_paths.
         map { |path| File.join(File.dirname(config_file), path) }.
         map { |path| File.expand_path(path) }.
         select { |path| File.exists?(path) || Dir.exists?(path) }

data/lib/version.rb

@@ -1,4 +1,4 @@
 module DangerSwiftlint
-  VERSION = "0.4.1".freeze
-  SWIFTLINT_VERSION = "0.16.1".freeze
+  VERSION = "0.5.0".freeze
+  SWIFTLINT_VERSION = "0.18.1".freeze
 end

data/spec/danger_plugin_spec.rb

@@ -103,6 +103,21 @@ module Danger
           @swiftlint.lint_files
         end
 
+        it 'does not crash when excluded is nil' do
+          allow(@swiftlint.git).to receive(:added_files).and_return([])
+          allow(@swiftlint.git).to receive(:modified_files).and_return([
+            'spec/fixtures/SwiftFile.swift',
+          ])
+
+          expect(Swiftlint).to receive(:lint)
+            .with(hash_including(:path => File.expand_path('spec/fixtures/SwiftFile.swift')))
+            .and_return(@swiftlint_response)
+            .once
+
+          @swiftlint.config_file = 'spec/fixtures/empty_excluded.yml'
+          @swiftlint.lint_files
+        end
+
         it 'does not lint deleted files paths' do
           # Danger (4.3.0 at the time of writing) returns deleted files in the
           # modified fiels array, which kinda makes sense.

data/spec/fixtures/empty_excluded.yml

@@ -0,0 +1,7 @@
+disabled_rules:
+  - todo
+
+included:
+  - an/included/folder
+
+excluded:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftlint
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Ash Furrow
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-11 00:00:00.000000000 Z
+date: 2017-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -170,6 +170,7 @@ files:
 - lib/version.rb
 - spec/danger_plugin_spec.rb
 - spec/fixtures/SwiftFile.swift
+- spec/fixtures/empty_excluded.yml
 - spec/fixtures/excluded_dir/SwiftFileThatShouldNotBeIncluded.swift
 - spec/fixtures/some_config.yml
 - spec/spec_helper.rb
@@ -194,13 +195,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for linting Swift with SwiftLint.
 test_files:
 - spec/danger_plugin_spec.rb
 - spec/fixtures/SwiftFile.swift
+- spec/fixtures/empty_excluded.yml
 - spec/fixtures/excluded_dir/SwiftFileThatShouldNotBeIncluded.swift
 - spec/fixtures/some_config.yml
 - spec/spec_helper.rb