danger-swiftlint 0.17.5 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f5939f208eecce698f379e691a8ce42d8c99c6f7
-  data.tar.gz: d1581c29cd30db64e06d4e17fa1243db98258c0d
+SHA256:
+  metadata.gz: deadbe6d57c929c594070425f46f30801dc55fce99f384b9773d4feceaefecea
+  data.tar.gz: bf49b1851d79915d02db6b6ddb4ffd7701677fe23cab3b6e38a9b0cbc0f86aa8
 SHA512:
-  metadata.gz: 6176320c263544e8208dc8b0f059de386b3e634d2782662d6494914b28e44e9fc418a496f9306844e4148711de4cdc09ea0a05d7b8872a0ef0d06f82d4cd7983
-  data.tar.gz: 32011ada543a29f5cce86402e7a1d49920dcb137385d928c95a64751067dc08a933b5a766bf638ab842dae827118ada2b322788ba502c3885aeb685dbd455d30
+  metadata.gz: f217f055c54cdbc7ef59b54a526ade9ca38afffb7767d2c549c5ae4036bba484973f95dee8367175ea955f901f49a5e3c34b95c2ef2ad5107d5fc44edfa33b09
+  data.tar.gz: b405c26b1046a2f5b81d059a9dae12c9f1584e1c4b08568a5b9d4a2031312c7b244682bed57570da23f90d5075ae4ddf40c0f368fd9507d67ca5a0e00f0f0f69

data/lib/danger_plugin.rb

@@ -35,6 +35,9 @@ module Danger
     # Provides additional logging diagnostic information.
     attr_accessor :verbose
 
+    # Whether all files should be linted in one pass
+    attr_accessor :lint_all_files
+
     # Lints Swift files. Will fail if `swiftlint` cannot be installed correctly.
     # Generates a `markdown` list of warnings for the prose in a corpus of
     # .markdown and .md files.
@@ -88,7 +91,7 @@ module Danger
       log "linting with options: #{options}"
 
       # Lint each file and collect the results
-      issues = run_swiftlint(files, options, additional_swiftlint_args)
+      issues = run_swiftlint(files, lint_all_files, options, additional_swiftlint_args)
       other_issues_count = 0
       unless @max_num_violations.nil?
         other_issues_count = issues.count - @max_num_violations if issues.count > @max_num_violations
@@ -123,13 +126,22 @@ module Danger
     # Run swiftlint on each file and aggregate collect the issues
     #
     # @return [Array] swiftlint issues
-    def run_swiftlint(files, options, additional_swiftlint_args)
-      files
-        .map { |file| options.merge(path: file) }
-        .map { |full_options| swiftlint.lint(full_options, additional_swiftlint_args) }
-        .reject { |s| s == '' }
-        .map { |s| JSON.parse(s).flatten }
-        .flatten
+    def run_swiftlint(files, lint_all_files, options, additional_swiftlint_args)
+      if lint_all_files
+        result = swiftlint.lint(options, additional_swiftlint_args)
+        if result == ''
+          {}
+        else
+          JSON.parse(result).flatten
+        end
+      else
+        files
+          .map { |file| options.merge(path: file) }
+          .map { |full_options| swiftlint.lint(full_options, additional_swiftlint_args) }
+          .reject { |s| s == '' }
+          .map { |s| JSON.parse(s).flatten }
+          .flatten
+      end
     end
 
     # Find swift files from the files glob

data/lib/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module DangerSwiftlint
-  VERSION = '0.17.5'
+  VERSION = '0.18.0'
   SWIFTLINT_VERSION = '0.28.1'
 end

data/spec/danger_plugin_spec.rb

@@ -353,6 +353,22 @@ module Danger
           @swiftlint.config_file = 'spec/fixtures/environment_variable_config.yml'
           @swiftlint.lint_files
         end
+
+        it 'runs SwiftLint only once if lint_all_files is set' do
+          allow(@swiftlint.git).to receive(:added_files).and_return([])
+          allow(@swiftlint.git).to receive(:modified_files).and_return([
+                                                                         'spec/fixtures/SwiftFile.swift',
+                                                                         'spec/fixtures/SwiftFile2.swift'
+                                                                       ])
+
+          expect_any_instance_of(Swiftlint).to receive(:lint)
+            .with(hash_including(config: nil), '')
+            .once
+            .and_return(@swiftlint_response)
+
+          @swiftlint.lint_all_files = true
+          @swiftlint.lint_files
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftlint
 version: !ruby/object:Gem::Version
-  version: 0.17.5
+  version: 0.18.0
 platform: ruby
 authors:
 - Ash Furrow
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-20 00:00:00.000000000 Z
+date: 2018-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for linting Swift with SwiftLint.