danger-swiftlint 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bc125a1eab659b16db325b01cc6e17d3b7d46f2a
-  data.tar.gz: 1b2bb65a44388d2a69b7aae55cd707208a1dc1b7
+SHA256:
+  metadata.gz: 01a0939fa22887ccd7c5fb12e95137480358a86b29fa5172013fcab5c4a641e8
+  data.tar.gz: fd0159f18351b1024d8a0375da700490a1fb65bf854b1afc43d9353129050ba6
 SHA512:
-  metadata.gz: 759555135b7c2b2900273e2701eac2a8884f77b41368922e2f0b735871f13df821ab60c9d4456092b032d9ed9b0392f813dd71794ac3bfef3f6eec5e944bf8c3
-  data.tar.gz: 4982d50f8e88cb400edf37ddb9f1e58e47f479002d98dc728f870f5a624a8873e33c8750bb8e2ba7d42b7ca0cccb45d57056cb0910a699fa9ad784fc4dc017dd
+  metadata.gz: d4ab4971ad7ce9ec8534f1640e6fb6d0ab9ab5ebc150fb3978bf0f2090969ea51af28982d920fb791a579a19ab8a938ce4bea2971b3183473ff30ac00ff5b01e
+  data.tar.gz: 2d2dda5c3ce69edc438d2054a52ecbb13dd0479dcc116c1c4981393328f2134d69c27790160ac2f5a16e5c67b12739aa311fae403cb7db6793eaca87ff7b884f

data/lib/danger_plugin.rb

@@ -98,8 +98,8 @@ module Danger
 
       if inline_mode
         # Report with inline comment
-        send_inline_comment(warnings, 'warn')
-        send_inline_comment(errors, 'fail')
+        send_inline_comment(warnings, :warn)
+        send_inline_comment(errors, fail_on_error ? :fail : :warn)
         warn other_issues_message(other_issues_count) if other_issues_count > 0
       elsif warnings.count > 0 || errors.count > 0
         # Report if any warning or error

data/lib/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module DangerSwiftlint
-  VERSION = '0.14.0'
+  VERSION = '0.15.0'
   SWIFTLINT_VERSION = '0.25.0'
 end

data/spec/danger_plugin_spec.rb

@@ -282,17 +282,40 @@ module Danger
           @swiftlint.lint_files
         end
 
-        it 'generates errors instead of markdown when use inline mode' do
+        it 'generates errors/warnings instead of markdown when use inline mode' do
           allow_any_instance_of(Swiftlint).to receive(:lint)
             .with(hash_including(path: File.expand_path('spec/fixtures/SwiftFile.swift')), '')
             .and_return(@swiftlint_response)
 
-          @swiftlint.lint_files('spec/fixtures/*.swift', inline_mode: true, fail_on_error: false, additional_swiftlint_args: '')
+          @swiftlint.lint_files('spec/fixtures/*.swift', inline_mode: true, additional_swiftlint_args: '')
 
           status = @swiftlint.status_report
-          expect(status[:errors]).to_not be_empty
+          expect(status[:errors] + status[:warnings]).to_not be_empty
           expect(status[:markdowns]).to be_empty
         end
+
+        it 'generate errors in inline_mode when fail_on_error' do
+          allow_any_instance_of(Swiftlint).to receive(:lint)
+            .with(hash_including(path: File.expand_path('spec/fixtures/SwiftFile.swift')), '')
+            .and_return(@swiftlint_response)
+
+          @swiftlint.lint_files('spec/fixtures/*.swift', inline_mode: true, fail_on_error: true, additional_swiftlint_args: '')
+
+          status = @swiftlint.status_report
+          expect(status[:errors]).to_not be_empty
+        end
+
+        it 'generate only warnings in inline_mode when fail_on_error is false' do
+          allow_any_instance_of(Swiftlint).to receive(:lint)
+            .with(hash_including(path: File.expand_path('spec/fixtures/SwiftFile.swift')), '')
+            .and_return(@swiftlint_response)
+
+          @swiftlint.lint_files('spec/fixtures/*.swift', inline_mode: true, fail_on_error: false, additional_swiftlint_args: '')
+
+          status = @swiftlint.status_report
+          expect(status[:warnings]).to_not be_empty
+          expect(status[:errors]).to be_empty
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftlint
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Ash Furrow
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-21 00:00:00.000000000 Z
+date: 2018-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for linting Swift with SwiftLint.