danger-swiftlint 0.10.2 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18a143487b60e3af2f374acebf0f22493b1906a8
-  data.tar.gz: 80dbc5a826284cc2b73f30c0356974247532a597
+  metadata.gz: c3e7ed119f894d13115a6147e512b018678edd8e
+  data.tar.gz: 9ead229790970463d5f2e7c8afcf03067a6decad
 SHA512:
-  metadata.gz: eb8c96ef07981c6db9a5b879adfc6a9c51f1fd4bf30ab1f4826d786149fcbfb89e170f3870b50b8447dadf1d868b003d206c80e670890ae8fa5c25771b5e77af
-  data.tar.gz: ca3faab2254f588ddf10cf0e4c939c81c5d3f096ea59b0f17ac1b0cfe886a3da531b7276b27cb4b4bcec483bf3f26bb74d3647422e843c2b5145917ac5a85e79
+  metadata.gz: 36d6752da9448acccea5208d1eb5453163cc1b5b17308a2c230840ae4bce72c3bd70681c83f71f2f7f2aef156edd570eeb37e50ff37b779b83685fffce5d2cd1
+  data.tar.gz: b4eae3d9a68e20dc5c1551862fd154f626edad9af58af3a2ad5d5e3adfebdf8ca14fdd0a501fc4a05ecb753bcb2fe04bd78da60bd878a20cd5a77c653a2f05dc

data/lib/danger_plugin.rb

@@ -29,6 +29,9 @@ module Danger
     # Allows you to specify a directory from where swiftlint will be run.
     attr_accessor :directory
 
+    # Maximum number of issues to be reported.
+    attr_accessor :max_num_violations
+
     # Provides additional logging diagnostic information.
     attr_accessor :verbose
 
@@ -74,6 +77,11 @@ module Danger
 
       # Lint each file and collect the results
       issues = run_swiftlint(files, options, additional_swiftlint_args)
+      other_issues_count = 0
+      unless @max_num_violations.nil?
+        other_issues_count = issues.count - @max_num_violations if issues.count > @max_num_violations
+        issues = issues.take(@max_num_violations)
+      end
       log "Received from Swiftlint: #{issues}"
 
       # Filter warnings and errors
@@ -84,11 +92,13 @@ module Danger
         # Report with inline comment
         send_inline_comment(warnings, 'warn')
         send_inline_comment(errors, 'fail')
+        warn other_issues_message(other_issues_count) if other_issues_count.positive?
       elsif warnings.count.positive? || errors.count.positive?
         # Report if any warning or error
         message = +"### SwiftLint found issues\n\n"
         message << markdown_issues(warnings, 'Warnings') unless warnings.empty?
         message << markdown_issues(errors, 'Errors') unless errors.empty?
+        message << "\n#{other_issues_message(other_issues_count)}" if other_issues_count.positive?
         markdown message
 
         # Fail Danger on errors
@@ -193,6 +203,11 @@ module Danger
       end
     end
 
+    def other_issues_message(issues_count)
+      violations = issues_count == 1 ? 'violation' : 'violations'
+      "SwiftLint also found #{issues_count} more #{violations} with this PR."
+    end
+
     # Make SwiftLint object for binary_path
     #
     # @return [SwiftLint]

data/lib/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module DangerSwiftlint
-  VERSION = '0.10.2'
+  VERSION = '0.11.0'
   SWIFTLINT_VERSION = '0.20.1'
 end

data/spec/danger_plugin_spec.rb

@@ -56,6 +56,22 @@ module Danger
           expect(output).to include('SwiftFile.swift | 13 | Force casts should be avoided.')
         end
 
+        it 'sets maxium number of violations' do
+          swiftlint_response = '[{ "rule_id" : "force_cast", "reason" : "Force casts should be avoided.", "character" : 19, "file" : "/Users/me/this_repo/spec//fixtures/SwiftFile.swift", "severity" : "Error", "type" : "Force Cast", "line" : 13 }, { "rule_id" : "force_cast", "reason" : "Force casts should be avoided.", "character" : 19, "file" : "/Users/me/this_repo/spec//fixtures/SwiftFile.swift", "severity" : "Error", "type" : "Force Cast", "line" : 14 }]'
+          expect_any_instance_of(Swiftlint).to receive(:lint)
+            .with(hash_including(path: File.expand_path('spec/fixtures/SwiftFile.swift')), '')
+            .and_return(swiftlint_response)
+
+          @swiftlint.max_num_violations = 1
+          @swiftlint.lint_files('spec/fixtures/*.swift')
+
+          output = @swiftlint.status_report[:markdowns].first.to_s
+          expect(output).to include('SwiftLint found issues')
+          expect(output).to include('SwiftFile.swift | 13 | Force casts should be avoided.')
+          expect(output).to include('SwiftLint also found 1 more violation with this PR.')
+          expect(output).to_not include('SwiftFile.swift | 14 | Force casts should be avoided.')
+        end
+
         it 'accepts additional cli arguments' do
           expect_any_instance_of(Swiftlint).to receive(:lint)
             .with(hash_including(path: File.expand_path('spec/fixtures/SwiftFile.swift')), '--lenient')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftlint
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.11.0
 platform: ruby
 authors:
 - Ash Furrow
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-25 00:00:00.000000000 Z
+date: 2017-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger