danger-swiftformat 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1437a0e4028a1bb64f0627d4bc16e15bb8ab73e7
-  data.tar.gz: dbad08332fa993cd805425cc88557dbde5524e67
+  metadata.gz: 3f81a4c7e44e5a23a8d7067dce1c851f898ed8a8
+  data.tar.gz: 345782e42ac5b52abd278476c527ba412e374763
 SHA512:
-  metadata.gz: 8314e9c66a55238c9923d80bc249ef6c5c0a7f86cb60a6bb7c5ccf951df51ac584565f4e2015e7499a42bd0f757c6108d1e122cad7880e480e10e3a47e385eca
-  data.tar.gz: 8c9a45515e26efa9cfb60f871b13c9e10a8755ad5979bb295309c1c05d0380401b79fbd52d8e294be2f01c0e049621b44e9f698aa49ff1977a882cccce0e106b
+  metadata.gz: 3c660ed15219c13a5d4d68f6196207e06a418cb2cc0277b60a39dc71ef73add88d1c0112a29a9662eef8c22d012c81f39f93ed2de971e884a1f187b8100afdca
+  data.tar.gz: bc68d5038eb2355a49c79aa3b1fc58a385cbbe3c6b66e3315cbcace224a048f8df3f20df70c69d778ddf10ae9b13887bba40ab850457620e3451af1cb47c2620

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-swiftformat (0.3.0)
+    danger-swiftformat (0.3.1)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -19,7 +19,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.5.5)
+    danger (5.5.6)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)

data/lib/swiftformat/gem_version.rb

@@ -1,3 +1,3 @@
 module Swiftformat
-  VERSION = "0.3.0".freeze
+  VERSION = "0.3.1".freeze
 end

data/lib/swiftformat/swiftformat.rb

@@ -1,3 +1,5 @@
+require "logger"
+
 module Danger
   class SwiftFormat
     def initialize(path = nil)
@@ -45,7 +47,13 @@ module Danger
     RUNTIME_REGEX = /.*swiftformat completed.*(.+\..+)s/
 
     def run_time(output)
-      RUNTIME_REGEX.match(output)[1]
+      if RUNTIME_REGEX.match(output)
+        RUNTIME_REGEX.match(output)[1]
+      else
+        logger = Logger.new(STDERR)
+        logger.error("Invalid run_time output: #{output}")
+        "-1"
+      end
     end
   end
 end

data/spec/fixtures/swiftformat_output_bad.txt

@@ -0,0 +1,9 @@
+running swiftformat...
+formatting /Users/garriguv/FirstClass.swift
+-- no changes
+formatting /Users/garriguv/FileWithErrors.swift
+-- no changes
+formatting /Users/garriguv/OtherFile.swift
+-- no changes
+
+swiftformat completed. 0/3 files would have been updated in 0.08m

data/spec/swiftformat/swiftformat_spec.rb

@@ -113,5 +113,20 @@ RSpec.describe Danger::SwiftFormat do
 
       expect(@sut.check_format(%w(.), "--self insert --indent tab")).to eq(output)
     end
+
+    it "should not crash if the output is invalid" do
+      expect(@cmd).to receive(:run)
+        .with(%w(swiftformat . --self insert --indent tab --dryrun --verbose))
+        .and_return(fixture("swiftformat_output_bad.txt"))
+
+      output = {
+          errors: [],
+          stats: {
+              run_time: "-1"
+          }
+      }
+
+      expect(@sut.check_format(%w(.), "--self insert --indent tab")).to eq(output)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftformat
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Vincent Garrigues
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-12 00:00:00.000000000 Z
+date: 2018-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -174,6 +174,7 @@ files:
 - lib/swiftformat/plugin.rb
 - lib/swiftformat/swiftformat.rb
 - spec/fixtures/swiftformat_output.txt
+- spec/fixtures/swiftformat_output_bad.txt
 - spec/fixtures/swiftformat_output_with_errors.txt
 - spec/spec_helper.rb
 - spec/swiftformat/plugin_spec.rb
@@ -204,6 +205,7 @@ specification_version: 4
 summary: A danger plugin for checking Swift formatting using SwiftFormat.
 test_files:
 - spec/fixtures/swiftformat_output.txt
+- spec/fixtures/swiftformat_output_bad.txt
 - spec/fixtures/swiftformat_output_with_errors.txt
 - spec/spec_helper.rb
 - spec/swiftformat/plugin_spec.rb