danger-swiftformat 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6ee9731972b91a28abe4fc4b8c560508db30f76
-  data.tar.gz: 2f85cde2168bc1073d85e826a7b6645f43db271e
+  metadata.gz: 4c8c48bd8f7f861b6222d443bfa92df522b3808f
+  data.tar.gz: 0a8d82cb15fc5bc6e4fd9c7d663bdc246b160680
 SHA512:
-  metadata.gz: 3b1d0ff41b673f6c0cf6d0b97d17a70fb9721f858ab9d97f29a68af42e9e2089f37ee5dff6fe11edc80becd1c2222747146045040fc53b1777f55c0aeab91244
-  data.tar.gz: 5569c70f0570483713ee28a074cc07bf9027c04a29383651091a8fa8eab442c2bd42d466845411000e2af9021cc3137a80f6aee1fa2eb1efe28e4d3b9b58d6a1
+  metadata.gz: 95dc50ab3b0fdea5415783920e82c231619472bcf8c07e8d9b70a97496100a8f2147b218c0db082232f36c5ed05209a21d41dab9fde5f59504abfdc20b254b2e
+  data.tar.gz: a509022e22ab09438da6f9098c47857d1cbb7e846ed4e0b9037b6192ef3c0e31973a2fdd1a0104ed1aee910f4bdc7a6d961d72185aec3f2f2e7d8410d7bba02a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-swiftformat (0.0.2)
+    danger-swiftformat (0.0.3)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -69,7 +69,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.7.0)
+    octokit (4.8.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.12.1)

data/lib/swiftformat/gem_version.rb

@@ -1,3 +1,3 @@
 module Swiftformat
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.3".freeze
 end

data/lib/swiftformat/plugin.rb

@@ -27,6 +27,9 @@ module Danger
       # Find Swift files
       swift_files = find_swift_files
 
+      # Stop processing if there are no swift files
+      return if swift_files.empty?
+
       # Run swiftformat
       results = swiftformat.check_format(swift_files)
 

data/spec/swiftformat/plugin_spec.rb

@@ -35,16 +35,12 @@ module Danger
         let(:success_output) { { errors: [], stats: { run_time: "0.08s" } } }
         let(:error_output) { { errors: [{ file: "Modified.swift", rules: %w(firstRule secondRule) }], stats: { run_time: "0.16s" } } }
 
-        before do
-          allow_any_instance_of(SwiftFormat).to receive(:installed?).and_return(true)
-          allow(@sut.git).to receive(:added_files).and_return(["Added.swift"])
-          allow(@sut.git).to receive(:modified_files).and_return(["Modified.swift"])
-          allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.swift"])
-        end
 
-        context "when swiftformat does not find any errors" do
+        context "when there are no swift files to check" do
           before do
-            allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(success_output)
+            allow(@sut.git).to receive(:added_files).and_return(["Added.m"])
+            allow(@sut.git).to receive(:modified_files).and_return(["Modified.m"])
+            allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.m"])
           end
 
           it "should not do anything" do
@@ -56,25 +52,48 @@ module Danger
           end
         end
 
-        context "when swiftformat finds errors" do
+        context "when there are swift files to check" do
           before do
-            allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(error_output)
+            allow_any_instance_of(SwiftFormat).to receive(:installed?).and_return(true)
+            allow(@sut.git).to receive(:added_files).and_return(["Added.swift"])
+            allow(@sut.git).to receive(:modified_files).and_return(["Modified.swift"])
+            allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.swift"])
           end
 
-          it "should output some markdown and error if fail_on_error is true" do
-            @sut.check_format(fail_on_error: true)
+          context "when swiftformat does not find any errors" do
+            before do
+              allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(success_output)
+            end
 
-            status = @sut.status_report
-            expect(status[:errors]).to_not be_empty
-            expect(status[:markdowns]).to_not be_empty
+            it "should not do anything" do
+              @sut.check_format(fail_on_error: true)
+
+              status = @sut.status_report
+              expect(status[:errors]).to be_empty
+              expect(status[:markdowns]).to be_empty
+            end
           end
 
-          it "should output some markdown and not error if fail_on_error is false" do
-            @sut.check_format(fail_on_error: false)
+          context "when swiftformat finds errors" do
+            before do
+              allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(error_output)
+            end
 
-            status = @sut.status_report
-            expect(status[:errors]).to be_empty
-            expect(status[:markdowns]).to_not be_empty
+            it "should output some markdown and error if fail_on_error is true" do
+              @sut.check_format(fail_on_error: true)
+
+              status = @sut.status_report
+              expect(status[:errors]).to_not be_empty
+              expect(status[:markdowns]).to_not be_empty
+            end
+
+            it "should output some markdown and not error if fail_on_error is false" do
+              @sut.check_format(fail_on_error: false)
+
+              status = @sut.status_report
+              expect(status[:errors]).to be_empty
+              expect(status[:markdowns]).to_not be_empty
+            end
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftformat
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Vincent Garrigues