danger-slather 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0cca0c4afa507eb7bd73fd601ff4e97337d69b34
-  data.tar.gz: c2c51b1c82fb386547c377da813ea9aa19b0b2e3
+  metadata.gz: ba3f7cf814e5c7c34df8ba4dc7eaf2a2a4feb131
+  data.tar.gz: 022e6952680d03141cae1a2784fc4e8480f751a6
 SHA512:
-  metadata.gz: f797ddccc437deecb8f81bbdb7542387dabe93a377b489b1a2b8244ce401c009b49547ffa928cc262cf41bf1aa6300b4dcf822131877eed044e81cc2239fa9ea
-  data.tar.gz: 5d0f6df048d4d9c4f1696d8d79281e309dba257333faf1a4da97461dbd8e397c6ec822a03b552462a446698958c5f3302e7c17f6b54e3ca3fccf5591a89d0f12
+  metadata.gz: 94caa281818749952ac7dba39aca501650b39881cb0df8fcf3860e3d00b969b8f20e64c2cece449f79b31a2da6ee9fe80774cf1221039da9ed5ba028051ae9ed
+  data.tar.gz: e36e75e82569157ab01f3e385b88bdad1898658877635f84f4e93cd3864f34e4f8d3ad49ada13186e42e218bcab03b56ed2ef19e7166068e9f4e29270112b929

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-slather (0.0.3)
+    danger-slather (0.0.6)
       danger-plugin-api (~> 1.0)
       slather (~> 2.3)
 

data/lib/slather/gem_version.rb

@@ -1,3 +1,3 @@
 module Slather
-  VERSION = '0.0.5'.freeze
+  VERSION = '0.0.6'.freeze
 end

data/lib/slather/plugin.rb

@@ -78,8 +78,8 @@ module Danger
       minimum_coverage = options[:minimum_coverage]
       notify_level = options[:notify_level] || :fail
 
-      if modified_files_coverage.count > 0
-        files_to_notify = modified_files_coverage.select do |file|
+      if all_modified_files_coverage.count > 0
+        files_to_notify = all_modified_files_coverage.select do |file|
           file.percentage_lines_tested < minimum_coverage
         end
         notify_messages = files_to_notify.map do |file|
@@ -117,10 +117,10 @@ module Danger
     def modified_files_coverage_table
       unless @project.nil?
         line = ''
-        if modified_files_coverage.count > 0
+        if all_modified_files_coverage.count > 0
           line << "File | Coverage\n"
           line << "-----|-----\n"
-          modified_files_coverage.each do |coverage_file|
+          all_modified_files_coverage.each do |coverage_file|
             file_name = coverage_file.source_file_pathname_relative_to_repo_root.to_s
             percentage = @project.decimal_f([coverage_file.percentage_lines_tested])
             line << "#{file_name} | **`#{percentage}%`**\n"
@@ -152,14 +152,21 @@ module Danger
 
     # Array of files that we have coverage information and was modified
     # @return [Array<File>]
-    def modified_files_coverage
+    def all_modified_files_coverage
       unless @project.nil?
-        @project.coverage_files.select do |file|
-          git.modified_files.include? file.source_file_pathname_relative_to_repo_root.to_s
+        all_modified_files_coverage ||= begin
+          modified_files = git.modified_files.nil? ? [] : git.modified_files
+          added_files = git.added_files.nil? ? [] : git.added_files
+          all_changed_files = modified_files | added_files
+          @project.coverage_files.select do |file|
+            all_changed_files.include? file.source_file_pathname_relative_to_repo_root.to_s
+          end
         end
+
+        all_modified_files_coverage
       end
     end
 
-    private :modified_files_coverage, :total_coverage_markdown
+    private :all_modified_files_coverage, :total_coverage_markdown
   end
 end

data/spec/slather_spec.rb

@@ -32,6 +32,7 @@ module Danger
       describe 'notify_if_modified_file_is_less_than' do
         it 'Should only fails on modified files' do
           @dangerfile.git.stubs(:modified_files).returns(['AppDelegate.swift'])
+          @dangerfile.git.stubs(:added_files).returns([])
 
           @project_mock.stubs(:coverage_files).returns(
             [
@@ -52,6 +53,7 @@ module Danger
 
         it 'Should not fail if coverage is higher than parameter' do
           @dangerfile.git.stubs(:modified_files).returns(['AppDelegate.swift'])
+          @dangerfile.git.stubs(:added_files).returns([])
 
           @project_mock.stubs(:coverage_files).returns(
             [
@@ -66,6 +68,7 @@ module Danger
 
         it 'Should add warning if notify_level is warning' do
           @dangerfile.git.stubs(:modified_files).returns(['AppDelegate.swift'])
+          @dangerfile.git.stubs(:added_files).returns([])
 
           @project_mock.stubs(:coverage_files).returns(
             [
@@ -82,6 +85,28 @@ module Danger
             ]
           )
         end
+
+        it 'Should count new files' do
+          @dangerfile.git.stubs(:modified_files).returns(['AppDelegate.swift'])
+          @dangerfile.git.stubs(:added_files).returns(['ViewController.swift'])
+
+          @project_mock.stubs(:coverage_files).returns(
+            [
+              mock_file('AppDelegate.swift', 10),
+              mock_file('ViewController.swift', 10)
+            ]
+          )
+
+          @my_plugin.notify_if_modified_file_is_less_than(minimum_coverage: 50, notify_level: :warning)
+
+          expect(@dangerfile.status_report[:errors]).to eq([])
+          expect(@dangerfile.status_report[:warnings]).to eq(
+            [
+              'AppDelegate.swift has less than 50% code coverage',
+              'ViewController.swift has less than 50% code coverage'
+            ]
+          )
+        end
       end
 
       describe 'notify_if_coverage_is_less_than' do
@@ -155,7 +180,11 @@ module Danger
             [
               'AppDelegate.swift',
               'ViewController.swift',
-              'ViewController2.swift',
+              'ViewController2.swift'
+            ]
+          )
+          @dangerfile.git.stubs(:added_files).returns(
+            [
               'ViewController3.swift',
               'ViewController4.swift'
             ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-slather
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Bruno Mazzo