danger-regexp 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5aada31b2f14ba00a9890334c975ba3be1283d402350944728f26d1e5ba096a7
-  data.tar.gz: f51797d24f46d8693cf5ff85e25a7b2ec273f8619953d7b101ff58ce0c16042a
+  metadata.gz: a9f7dc7e2b183a72f4798e7c6fd5bf8b1f87d7ea5f53d8dc205cc89912c207ac
+  data.tar.gz: 3e3318da2e098ff341a3e3956480c6694707c77a57c45e25741edc5cdd53ed48
 SHA512:
-  metadata.gz: 593a5c310cdbee7a47d96c59dee745643889d8b59e2a25e5fad79b5962dcbc7a798fe2e234e7f754aba89d3575e2a1f9ff1b4227700c512aceb6d1adde45f82d
-  data.tar.gz: 9f72c21072f512e2f5dd037863cc81209c2677208a9160fb0d7b28435294b9019e3b141ddecfdd04258aa3d1d4a8cfef5f9b08e130969ce803608cd414b8790b
+  metadata.gz: 18e3e3d615dd520d6ea81c81425a1f02fbd0a255908751ff9f929ebeb27174f73e1b34690961ee29922af9ed8e09bff2fc1024ce8426a3288b1fc69f6a66bfa5
+  data.tar.gz: e25c43249d26c57abcf50de63dd6f8b0bec799316a1d44bb72ffec98e542cbe397a7a37b551126fbe9818367f22887ad9579a7d776a2dff181d8d05da08d33cc

data/.devcontainer/.gitignore

@@ -0,0 +1 @@
+*.env

data/.devcontainer/Dockerfile

@@ -0,0 +1,22 @@
+FROM ruby:3.0.2
+
+ARG USERNAME=app
+ARG USER_UID=1000
+ARG USER_GID=$USER_UID
+
+RUN groupadd --gid $USER_GID $USERNAME \
+  && useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \
+  && apt-get update \
+  && apt-get install -y sudo \
+  && echo "$USERNAME ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/$USERNAME \
+  && chmod 0440 /etc/sudoers.d/$USERNAME
+
+ENV BUNDLE_PATH=/vendor/bundle
+RUN mkdir -p /app $BUNDLE_PATH /home/$USERNAME/.config
+RUN chown -R $USERNAME /app $BUNDLE_PATH /home
+
+USER $USERNAME
+
+ENV SHELL=/bin/bash
+
+WORKDIR /app

data/.devcontainer/app.env.example

@@ -0,0 +1 @@
+#SHELL=/usr/bin/zsh

data/.devcontainer/devcontainer.json

@@ -0,0 +1,10 @@
+{
+  "dockerComposeFile": "./docker-compose.yml",
+  "service": "app",
+  "workspaceFolder": "/app",
+  "initializeCommand": "cp -n .devcontainer/app.env.example .devcontainer/app.env",
+  "name": "${localWorkspaceFolderBasename}",
+  "extensions": [
+    "esbenp.prettier-vscode",
+  ]
+}

data/.devcontainer/docker-compose.yml

@@ -0,0 +1,18 @@
+version: "3.8"
+services:
+  app:
+    init: true
+    build:
+      context: .
+    command: sleep infinity
+    env_file:
+      - app.env
+    volumes:
+      - ..:/app:cached
+      - dotconfig:/home/app/.config
+      - vendor:/vendor
+
+volumes:
+  app:
+  vendor:
+  dotconfig:

data/.github/workflows/publish.yml

@@ -0,0 +1,17 @@
+on:
+  push:
+    tags:
+      - "v*"
+
+jobs:
+  publish:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.0"
+          bundler-cache: true
+      - run: bundle exec rake release
+        env:
+          GEM_HOST_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}

data/.github/workflows/test.yml

@@ -0,0 +1,21 @@
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
+        ruby: [2.6, 2.7, "3.0"]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rspec

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Change log
+
+## 1.0.0
+
+- Limit comment count
+
+## 0.1.0
+
+- Release

data/Gemfile

@@ -4,3 +4,6 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in danger-regexp.gemspec
 gemspec
+
+gem "pry-byebug"
+gem "rspec"

data/Gemfile.lock

@@ -0,0 +1,113 @@
+PATH
+  remote: .
+  specs:
+    danger-regexp (1.0.0)
+      danger
+      git_diff_parser (~> 3.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    byebug (11.1.3)
+    claide (1.0.3)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (8.3.1)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (>= 1, < 4)
+    diff-lcs (1.4.4)
+    faraday (1.5.1)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
+      faraday-patron (~> 1.0)
+      multipart-post (>= 1.2, < 3)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    faraday-httpclient (1.0.1)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    git (1.9.1)
+      rchardet (~> 1.8)
+    git_diff_parser (3.2.0)
+    kramdown (2.3.1)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
+    nap (1.1.0)
+    no_proxy_fix (0.1.2)
+    octokit (4.21.0)
+      faraday (>= 0.9)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    open4 (1.3.4)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.6)
+    rake (13.0.6)
+    rchardet (1.8.0)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    ruby2_keywords (0.0.5)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
+    terminal-table (3.0.1)
+      unicode-display_width (>= 1.1.1, < 3)
+    unicode-display_width (2.0.0)
+
+PLATFORMS
+  x86_64-linux
+
+DEPENDENCIES
+  bundler (>= 2.2.10)
+  danger-regexp!
+  pry-byebug
+  rake (>= 12.3.3)
+  rspec
+
+BUNDLED WITH
+   2.2.22

data/README.md

@@ -1,8 +1,6 @@
-# Danger::Regexp
+# Danger Regexp
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/danger/regexp`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+A danger plugin to add a comment based on regexp.
 
 ## Installation
 
@@ -22,7 +20,13 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+```ruby
+regexp.lint to
+  match(/hello world/, <<~MESSAGE)
+    Don't use hello world, just use hello instead.
+  MESSAGE
+end
+```
 
 ## Development
 
@@ -32,7 +36,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/danger-regexp. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/mtsmfm/danger-regexp. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
 
@@ -40,4 +44,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the Danger::Regexp project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/danger-regexp/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Danger::Regexp project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/mtsmfm/danger-regexp/blob/master/CODE_OF_CONDUCT.md).

data/danger-regexp.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Fumiaki MATSUSHIMA"]
   spec.email         = ["mtsmfm@gmail.com"]
 
-  spec.summary       = %q{}
-  spec.description   = %q{}
+  spec.summary       = %q{A danger plugin to add a comment based on regexp}
+  spec.description   = %q{A danger plugin to add a comment based on regexp}
   spec.homepage      = "https://github.com/mtsmfm/danger-regexp"
   spec.license       = "MIT"
 
@@ -24,8 +24,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "git_diff_parser", "~> 3.1"
+  spec.add_dependency "danger"
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "bundler", ">= 2.2.10"
+  spec.add_development_dependency "rake", ">= 12.3.3"
 end

data/lib/danger/regexp/version.rb

@@ -1,5 +1,5 @@
 module Danger
   module Regexp
-    VERSION = "0.1.0"
+    VERSION = "1.0.0"
   end
 end

data/lib/danger_plugin.rb

@@ -2,18 +2,30 @@ require 'git_diff_parser'
 
 module Danger
   class DangerRegexp < Plugin
+    MAX_COMMENT_COUNT = 5
+
+    ChangedLine = Struct.new(:file, :number, :content, keyword_init: true)
+
     def lint(&block)
       @map = {}
 
       instance_eval(&block)
 
-      git.diff.each do |diff|
-        GitDiffParser::Patch.new(diff.patch).changed_lines.each do |line|
-          @map.each do |regexp, message|
-            if line.content.match?(regexp)
-              markdown(message, file: diff.path, line: line.number)
-            end
-          end
+      @map.each do |regexp, message|
+        count = 0
+
+        target_lines = changed_lines.select do |line|
+          line.content.match?(regexp)
+        end
+
+        target_lines.first(MAX_COMMENT_COUNT).each do |line|
+          markdown(message, file: line.file, line: line.number)
+        end
+
+        if target_lines.size > MAX_COMMENT_COUNT
+          warn <<~MSG
+            Regexp #{regexp.inspect} matched too many lines (#{target_lines.size} lines). Only first #{MAX_COMMENT_COUNT} comments are posted.
+          MSG
         end
       end
     end
@@ -25,5 +37,13 @@ module Danger
         @map[regexp] = message
       end
     end
+
+    def changed_lines
+      @changed_lines ||= git.diff.flat_map do |diff|
+        GitDiffParser::Patch.new(diff.patch).changed_lines.map do |line|
+          ChangedLine.new(file: diff.path, number: line.number, content: line.content)
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-regexp
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Fumiaki MATSUSHIMA
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-04 00:00:00.000000000 Z
+date: 2021-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git_diff_parser
@@ -25,58 +25,68 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: danger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.16'
-  type: :development
+        version: '0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 2.2.10
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 2.2.10
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
-description: ''
+        version: 12.3.3
+description: A danger plugin to add a comment based on regexp
 email:
 - mtsmfm@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".devcontainer/.gitignore"
+- ".devcontainer/Dockerfile"
+- ".devcontainer/app.env.example"
+- ".devcontainer/devcontainer.json"
+- ".devcontainer/docker-compose.yml"
+- ".github/workflows/publish.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
+- ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -105,9 +115,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
-summary: ''
+summary: A danger plugin to add a comment based on regexp
 test_files: []