danger-rcov 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ddfec7f815e67a3c1dbe442357a9f8b3c9c4705cf39247cf684cddcd523b8d4
-  data.tar.gz: 3c5a8ac0abd40831e389220ff68443d51a0ea67f08758ed5d112141b2ac81a9e
+  metadata.gz: 7d64817997942110a3e432c546a853f985e064baaee7f66e29150cacfc7de878
+  data.tar.gz: 25d558cae50e9e68dc33f3f7b1f34d1524ffb013f695f73d6ca7fe87fb94e153
 SHA512:
-  metadata.gz: e5805512c82d9716af34e497e5b38f28c6278e05c0d25a8a81834346887e775bf4d440d26e10ea3224c2affd41a4bdf06d3331a2f24379aab49d3226320a8bd9
-  data.tar.gz: ba4cd7e9794eb784f0ccd3a892160d725ac59db892056674a83b6164027eb8430156ca10c438e227852c86aa7533501dd4ae091a2bc35297e1f98a721aa4a866
+  metadata.gz: fac7501215e94b5df5b6f205ae37c97b633fcb383998cac9fd109e90912cd2e22d07db4510d5413d7ac460220b8e9eb7dbd44d3a0b42917c7bfba1da02ed0a39
+  data.tar.gz: 4282eae7cc78f55fa4b065ce68b7d02117098ef7e4b0e98efbd856de3544b361357daa6b6f4047a58aa55c743c75036634f0f5d1f62fa265c9f910d377134f4c

data/README.md

@@ -15,12 +15,20 @@ This plugin will provide an interface similar to codecov.
 
 ## Usage
 
-  Inside your Dangerfile:
+  [circleCI] Inside your Dangerfile:
 
   ```
-    markdown rcov.report(
-      current_url: "https://circleci.com/api/v1.1/project/github/#{ENV['CIRCLE_PROJECT_USERNAME']}/#{ENV['CIRCLE_PROJECT_REPONAME']}/#{ENV['CIRCLE_BUILD_NUM']}/artifacts?circle-token=#{ENV['CIRCLE_TOKEN']}",
-      master_url: "https://circleci.com/api/v1.1/project/github/#{ENV['CIRCLE_PROJECT_USERNAME']}/#{ENV['CIRCLE_PROJECT_REPONAME']}/latest/artifacts?circle-token=#{ENV['CIRCLE_TOKEN']}&branch=master",
-      warning: true # this will warn when the code coverage decrease!
-    )
+    # stable branch to check against (default: 'master')
+    # build name (default: 'build')
+    # warning (default: true)
+    markdown rcov.report('master', 'build', true)
+  ```
+
+  [Others] Generic
+
+  ```
+    # current branch url to coverage.json
+    # stable branch url to coverage.json
+    # warning (default: true)
+    markdown rcov.report_by_urls('http://current_branch/coverage.json', 'http://master_branch/coverage.json', true)
   ```

data/lib/rcov/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rcov
-  VERSION = '2.0.4'
+  VERSION = '2.0.5'
 end

data/lib/rcov/plugin.rb

@@ -6,9 +6,14 @@ require 'circle_ci_wrapper'
 
 module Danger
   class DangerRcov < Plugin
-    def report(branch_name, build_name = 'build', show_warning = true)
+    # report will get the urls from circleCi trough circle_ci_wrapper gem
+    def report(branch_name = 'master', build_name = 'build', show_warning = true)
       current_url, master_url = CircleCiWrapper.report_urls_by_branch(branch_name, build_name)
 
+      report_by_urls(current_url, master_url, show_warning)
+    end
+
+    def report_by_urls(current_url, master_url, show_warning = true)
       # Get code coverage report as json from url
       @current_report = get_report(url: current_url)
       @master_report = get_report(url: master_url)
@@ -60,10 +65,10 @@ module Danger
       formatter = symbol ? '%+.2f' : '%+d'
       currrent_formatted = current.to_s + symbol.to_s
       master_formatted = master ? master.to_s + symbol.to_s : '-'
-      prep = master_formatted != '-' && current - master != 0 ? '+ ' : '  '
+      prep = calulate_prep(master_formatted, current - master)
 
       line = data_string(title, master_formatted, currrent_formatted, prep)
-      line << justify_text(format(formatter, current - master) + symbol.to_s, 8) if prep == '+ '
+      line << justify_text(format(formatter, current - master) + symbol.to_s, 8) if prep != '  '
       line << "\n"
       line
     end
@@ -75,5 +80,11 @@ module Danger
     def data_string(title, master, current, prep)
       "#{prep}#{justify_text(title, 9, 'left')} #{justify_text(master, 7)}#{justify_text(current, 9)}"
     end
+
+    def calulate_prep(master_formatted, diff)
+      return '  ' if master_formatted != '-' && diff.zero?
+
+      diff.positive? ? '+ ' : '- '
+    end
   end
 end

data/spec/rcov_spec.rb

@@ -46,10 +46,10 @@ module Danger
           "@@           Coverage Diff            @@\n"\
           "##           master     #123     +/-  ##\n"\
           "========================================\n"\
-          "+ Coverage   81.62%   79.16%  -2.46%\n"\
+          "- Coverage   81.62%   79.16%  -2.46%\n"\
           "========================================\n"\
           "  Files          85       85\n"\
-          "+ Lines        1708     1699      -9\n"\
+          "- Lines        1708     1699      -9\n"\
           "========================================\n"\
           "+ Misses        314      354     +40\n"\
           '```')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-rcov
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - Guilherme Pereira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-21 00:00:00.000000000 Z
+date: 2020-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: circle_ci_wrapper