danger-rails_best_practices 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 031feabf20a7c5eec09939d71d5a14390bbdd54f
-  data.tar.gz: e4e7f0d41c8ff3f96bced9b3949739e03bbde3af
+  metadata.gz: f68087b7d06bdaeb36834310b7b9c97b0be378fd
+  data.tar.gz: 95cc88e911fb17fa7332f68e35e8d886e52ad0e3
 SHA512:
-  metadata.gz: ba632be929844a01ad5d43007a844eabb083b9e244eeae3cf8ebb7811bc3a52e73d5bc39247136d26e39e434ee6f5c4944e6d192a19edea8272783ff5823d8ef
-  data.tar.gz: b48432814c4b7a340890c74f61e5cb801e0f2cc3041636d93f5f1497ea6c02a98b129efa5b90ec29ba464be56d5fd313b69a4cb52e347ee5dca652acee8d38dd
+  metadata.gz: d445ac4d66b00c0f8d85ad28f21e38da6e5cd166558b97703c7d5ffaff0ab111beb0c01c292e3dc5b2d72e8152b815a77a0c244f6f85ba1dab1cdab32a645885
+  data.tar.gz: fd5eb99645323af48a752670ae895e280f9a2ecb872215daa43dc426f1ce6bda06115f68b2ff8ec1e58c4afe43d4bdb0a580f8d9d6595233e301e5ca0fcc6b66

data/.rubocop.yml

@@ -2,9 +2,6 @@
 
 # If you don't like these settings, just delete this file :)
 
-AllCops:
-  TargetRubyVersion: 2.0
-
 # kind_of? is a good way to check a type
 Style/ClassCheck:
   EnforcedStyle: kind_of?

data/.travis.yml

@@ -8,9 +8,9 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
+  - 2.2.8
+  - 2.3.5
+  - 2.4.2
 
 before_install:
   - gem update bundler

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Change Log
+
+## [v0.1.1](https://github.com/blooper05/danger-rails_best_practices/tree/v0.1.1) (2017-10-21)
+[Full Changelog](https://github.com/blooper05/danger-rails_best_practices/compare/v0.1.0...v0.1.1)
+
+**Fixed bugs:**
+
+- CI is failing due to Rubocop settings [\#3](https://github.com/blooper05/danger-rails_best_practices/issues/3)
+
+**Merged pull requests:**
+
+- :bug: Fix Neverfail test [\#5](https://github.com/blooper05/danger-rails_best_practices/pull/5) ([blooper05](https://github.com/blooper05))
+- :bug: Fix TargetRubyVersion setting of .rubocop.yml [\#4](https://github.com/blooper05/danger-rails_best_practices/pull/4) ([blooper05](https://github.com/blooper05))
+-  Escape filename regexp [\#1](https://github.com/blooper05/danger-rails_best_practices/pull/1) ([edvakf](https://github.com/edvakf))
+
+## [v0.1.0](https://github.com/blooper05/danger-rails_best_practices/tree/v0.1.0) (2017-10-05)
+
+
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

data/README.md

@@ -7,7 +7,7 @@
 [![Gem Version](https://img.shields.io/gem/v/danger-rails_best_practices.svg)](https://rubygems.org/gems/danger-rails_best_practices)
 [![License](https://img.shields.io/github/license/blooper05/danger-rails_best_practices.svg)](https://github.com/blooper05/danger-rails_best_practices/blob/master/LICENSE)
 
-A [danger](https://rubygems.org/gems/danger) plugin for [rails_best_practices](https://rubygems.org/gems/rails_best_practices).
+A [Danger](https://rubygems.org/gems/danger) plugin for [rails_best_practices](https://rubygems.org/gems/rails_best_practices).
 
 ## Installation
 

data/lib/rails_best_practices/gem_version.rb

@@ -1,3 +1,3 @@
 module RailsBestPractices
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/lib/rails_best_practices/plugin.rb

@@ -32,7 +32,7 @@ module Danger
 
     def fetch_files_to_lint
       files = git.modified_files + git.added_files
-      Array(files.map { |file| /#{file}/ })
+      files.map { |file| Regexp.compile(Regexp.escape(file)) }
     end
 
     def warn_each_line(lint_errors)

data/spec/rails_best_practices_spec.rb

@@ -26,8 +26,8 @@ module Danger
         let(:violation_reports) { dangerfile.violation_report[:warnings] }
 
         context 'with changed files' do
-          let(:modified_files) { [double('Modified Files')] }
-          let(:added_files)    { [double('Added Files')] }
+          let(:modified_files) { %w(spec/fixtures/modified_file.rb) }
+          let(:added_files)    { %w(spec/fixtures/added_file.rb) }
 
           context 'with lint errors' do
             let(:stubbings) { changed_files && lint_errors }
@@ -73,6 +73,24 @@ module Danger
             expect(violation_reports).to be_empty
           end
         end
+
+        describe 'arguments passed to RailsBestPractices::Analyzer.new' do
+          let(:stubbings) { changed_files && analyzer }
+
+          let(:modified_files) { %w(spec/fixtures/modified_file.rb) }
+          let(:added_files)    { %w(\*?{}.) }
+
+          let(:analyzer) do
+            expect(::RailsBestPractices::Analyzer).to receive(:new)
+              .with('.', 'silent' => true,
+                         'only' => [%r{spec/fixtures/modified_file\.rb},
+                                    /\\\*\?\{\}\./])
+              .and_call_original
+          end
+
+          it 'escapes filenames correctly' do
+          end
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - blooper05
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-05 00:00:00.000000000 Z
+date: 2017-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -188,6 +188,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE
@@ -198,6 +199,8 @@ files:
 - lib/danger_rails_best_practices.rb
 - lib/rails_best_practices/gem_version.rb
 - lib/rails_best_practices/plugin.rb
+- spec/fixtures/added_file.rb
+- spec/fixtures/modified_file.rb
 - spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/blooper05/danger-rails_best_practices
@@ -225,5 +228,7 @@ signing_key:
 specification_version: 4
 summary: A Danger plugin to lint Ruby files through rails_best_practices.
 test_files:
+- spec/fixtures/added_file.rb
+- spec/fixtures/modified_file.rb
 - spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb