danger-prose 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f09413f72b2e58d7e5d6a3d86e110d17999e7594
-  data.tar.gz: 6483ac3b556427b1debbed54c4c07f23719b0fbd
+  metadata.gz: 175ef2fd408df4f9ab570fbe55e1691198a79b02
+  data.tar.gz: 67c89b4fb1de6cd1f3e77a9518f095e3e39c52db
 SHA512:
-  metadata.gz: 6c23179053f947d8be3bc2654ad8967b0d9b487a66051c043e121ac911a0b31258005070f6f77e5fabf562c7dcfde845387d9c819924adeca9869817e841dcc6
-  data.tar.gz: 93d94353ef9ca6d35f43a2245708e17ef386c2882a057bd7836f3189648529d2f853244e874d94ee0f7f406846c86d6bb565f650d8af558acf14f6308f0c8651
+  metadata.gz: bf8b908df7f848b1601da0ff2dade9b641a89aec74cf4fa7a1bb4e95094570af12096f27acf2a52f353fcb223df94defbb68e65af9108df331d3e92b725904e8
+  data.tar.gz: 67f56f3082e21cd1058ff4841c36137430ce8ce36c14641e5fb37107ac9eb78e411163a92861f6152bf3beea3e5a06bc7dbecc4d8d2b35cbeb1beb437fe3596a

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+2.0.5
+- Fix based on danger changing how `FileList` is implemented (dbgrandi)
+
+2.0.4
+- Make sure proselint success results are filtered out (zhusee2)
+
+2.0.1
+- Fix typo in module name (suchow)
+
+2.0.0
+- Fix a bunch of things (orta)
+
+1.0.0
+- Initial release

data/Gemfile.lock

@@ -1,47 +1,44 @@
 PATH
   remote: .
   specs:
-    danger-prose (2.0.2)
+    danger-prose (2.0.5)
       danger
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.4.0)
+    addressable (2.5.1)
+      public_suffix (~> 2.0, >= 2.0.2)
     bacon (1.2.0)
-    claide (1.0.0)
-    claide-plugins (0.9.1)
+    claide (1.0.2)
+    claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
     coderay (1.1.1)
-    colored (1.2)
-    cork (0.2.0)
-      colored (~> 1.2)
-    danger (3.0.3)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (5.3.2)
       claide (~> 1.0)
-      claide-plugins (> 0.9.0)
-      colored (~> 1.2)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
       faraday-http-cache (~> 1.0)
       git (~> 1)
-      gitlab (~> 3.7.0)
       kramdown (~> 1.5)
       octokit (~> 4.2)
       terminal-table (~> 1)
-    diff-lcs (1.2.5)
-    faraday (0.9.2)
+    diff-lcs (1.3)
+    faraday (0.12.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
-    ffi (1.9.10)
+    ffi (1.9.18)
     formatador (0.2.5)
     git (1.3.0)
-    gitlab (3.7.0)
-      httparty (~> 0.13.0)
-      terminal-table
-    guard (2.14.0)
+    guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (~> 1.0)
@@ -51,66 +48,64 @@ GEM
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
-    guard-rspec (4.7.2)
+    guard-rspec (4.7.3)
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    httparty (0.13.7)
-      json (~> 1.8)
-      multi_xml (>= 0.5.2)
-    json (1.8.3)
-    kramdown (1.12.0)
+    kramdown (1.14.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
+    lumberjack (1.0.12)
     metaclass (0.0.4)
     method_source (0.8.2)
-    mocha (1.1.0)
+    mocha (1.2.1)
       metaclass (~> 0.0.1)
-    mocha-on-bacon (0.2.2)
+    mocha-on-bacon (0.2.3)
       mocha (>= 0.13.0)
-    multi_xml (0.5.5)
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.0)
+    notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.3.0)
-      sawyer (~> 0.7.0, >= 0.5.3)
+    octokit (4.7.0)
+      sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     prettybacon (0.0.2)
       bacon (~> 1.2)
-    pry (0.10.3)
+    pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    public_suffix (2.0.5)
     rake (10.5.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
+    rb-fsevent (0.10.2)
+    rb-inotify (0.9.10)
+      ffi (>= 0.5.0, < 2)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    sawyer (0.7.0)
-      addressable (>= 2.3.5, < 2.5)
-      faraday (~> 0.8, < 0.10)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    sawyer (0.8.1)
+      addressable (>= 2.3.5, < 2.6)
+      faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.6.0)
-    thor (0.19.1)
-    yard (0.8.7.6)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    thor (0.19.4)
+    unicode-display_width (1.3.0)
+    yard (0.9.9)
 
 PLATFORMS
   ruby

data/README.md

@@ -4,6 +4,8 @@ A description of danger-prose.
 
 ## Installation
 
+As a pre-requisite, danger-prose requires a node environment for spell checking and a python environment for linting. So, make sure your CI environment has support for either or both of those.
+
     $ gem install danger-prose
 
 ### prose
@@ -40,11 +42,11 @@ prose.lint_files</pre>
 
 
 #### Attributes
-<tr>
+
 `disable_linters` - Allows you to disable a collection of linters from running. Doesn't work yet.
 You can get a list of [them here](https://github.com/amperser/proselint#checks)
 defaults to `["misc.scare_quotes", "typography.symbols"]` when it's nil.
-<tr>
+
 `ignored_words` - Allows you to add a collection of words to skip in spellchecking.
 defaults to `[""]` when it's nil.
 

data/lib/danger_plugin.rb

@@ -59,7 +59,7 @@ module Danger
       to_disable = disable_linters || ["misc.scare_quotes", "typography.symbols"]
       with_proselint_disabled(to_disable) do
         # Convert paths to proselint results
-        result_jsons = Hash[markdown_files.uniq.collect { |v| [v, get_proselint_json(v)] }]
+        result_jsons = Hash[markdown_files.to_a.uniq.collect { |v| [v, get_proselint_json(v)] }]
         proses = result_jsons.select { |_, prose| prose['data']['errors'].count > 0 }
       end
 
@@ -123,7 +123,7 @@ module Danger
 
       skip_words = ignored_words || []
       File.write(".spelling", skip_words.join("\n"))
-      result_texts = Hash[markdown_files.uniq.collect { |md| [md, `mdspell #{md} -r`.strip] }]
+      result_texts = Hash[markdown_files.to_a.uniq.collect { |md| [md, `mdspell #{md} -r`.strip] }]
       spell_issues = result_texts.select { |path, output| output.include? "spelling errors found" }
       File.unlink(".spelling")
 

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerProse
-  VERSION = '2.0.4'.freeze
+  VERSION = '2.0.5'.freeze
 end

data/spec/danger_plugin_spec.rb

@@ -39,7 +39,7 @@ module Danger
             # The request source's PR JSON typically looks like
             # https://raw.githubusercontent.com/danger/danger/bffc246a11dac883d76fc6636319bd6c2acd58a3/spec/fixtures/pr_response.json
 
-            @prose.env.request_source.pr_json = { head: { ref: 'my_fake_branch' } }
+            @prose.env.request_source.pr_json = { "head" => { "ref" => 'my_fake_branch' } }
           end
 
           it 'handles a known JSON report from proselint' do
@@ -47,11 +47,11 @@ module Danger
             output = @prose.status_report[:markdowns].first
 
             # A title
-            expect(output).to include('Proselint found issues')
+            expect(output.message).to include('Proselint found issues')
             # A warning
-            expect(output).to include('!!! is hyperbolic. | warning')
+            expect(output.message).to include('!!! is hyperbolic. | warning')
             # A link to the file inside the fixtures dir
-            expect(output).to include('[spec/fixtures/blog_post.md](/artsy/eigen/tree/my_fake_branch/spec/fixtures/blog_post.md)')
+            expect(output.message).to include('[spec/fixtures/blog_post.md](/artsy/eigen/tree/my_fake_branch/spec/fixtures/blog_post.md)')
           end
         end
       end
@@ -82,7 +82,7 @@ module Danger
             # The request source's PR JSON typically looks like
             # https://raw.githubusercontent.com/danger/danger/bffc246a11dac883d76fc6636319bd6c2acd58a3/spec/fixtures/pr_response.json
 
-            @prose.env.request_source.pr_json = { head: { ref: 'my_fake_branch' } }
+            @prose.env.request_source.pr_json = { "head" => { "ref" => 'my_fake_branch' } }
           end
 
           it 'handles a known JSON report from mdspell' do
@@ -90,11 +90,11 @@ module Danger
             output = @prose.status_report[:markdowns].first
 
             # A title
-            expect(output).to include('Spell Checker found issues')
+            expect(output.message).to include('Spell Checker found issues')
             # A typo, in bold
-            expect(output).to include('**tpyo**')
+            expect(output.message).to include('**tpyo**')
             # A link to the file inside the fixtures dir
-            expect(output).to include('[spec/fixtures/blog_post.md](/artsy/eigen/tree/my_fake_branch/spec/fixtures/blog_post.md)')
+            expect(output.message).to include('[spec/fixtures/blog_post.md](/artsy/eigen/tree/my_fake_branch/spec/fixtures/blog_post.md)')
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-prose
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - David Grandinetti
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-20 00:00:00.000000000 Z
+date: 2017-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -147,6 +147,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -180,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A danger plugin for working with bodies of markdown prose.