danger-packwerk 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3338a7622d64fc169f9ef273873bc11002ff56ba3d66b225189f0dc1bd6b6cf9
-  data.tar.gz: 58cb63b3956cf29245575e8be453280c33041b3ce15579c2102d07819c836c26
+  metadata.gz: '0118c3bc15c4a681dc290f557549e24451cd5c3fda714c8a29637ad791f77cfb'
+  data.tar.gz: 716b2b0a13d4392cf8263abadca2620e241527c4874e25c93e9ad2b7baec57ee
 SHA512:
-  metadata.gz: 31aab3fcdb5c3bb7837214ac46fae8807fcfa9727d9a3d21a4d371c8c8de4db688c13ff486e7e9660ec552f7aa39cbd1c622338e8b88ae087f226362804e8097
-  data.tar.gz: fba5ddd5b2d9ed86b3173b1aca8562ba523dcd74c974d45570edc07853ac5c4819bf3c64956ca10a037b800db056853cb38097ce422fa79eb2983ab297ea9890
+  metadata.gz: ac00cad5d9241aec516693df310a0b97afd8da2bc59f0234d005ab9bc9ae1d3d781fa6c591f9267f03919327ef6f57dc16e2ef6d494d98d8e43acd205c9ef530
+  data.tar.gz: 7043ca6402ac04d799dabe1ed8ddce3d4d239ebc6f818236e47b494faa9a5b3b52df1b6148e9a2d35e50788264c6735e70548a814ff12219cb080f2efbf953be

data/lib/danger-packwerk/danger_deprecated_references_yml_changes.rb

@@ -78,16 +78,21 @@ module DangerPackwerk
         removed_violations += deleted_violations
       end
 
+      # The format for git.renamed_files is a T::Array[{after: "some/path/new", before: "some/path/old"}]
+      renamed_files_before = git.renamed_files.map { |before_after_file| before_after_file[:before] }
+      renamed_files_after = git.renamed_files.map { |before_after_file| before_after_file[:after] }
+
       git.modified_files.grep(DEPRECATED_REFERENCES_PATTERN).each do |modified_deprecated_references_yml_file|
+        # We skip over modified files if one of the modified files is a renamed `deprecated_references.yml` file.
+        # This allows us to rename packs while ignoring "new violations" in those renamed packs.
+        next if renamed_files_before.include?(modified_deprecated_references_yml_file)
+
         head_commit_violations = BasicReferenceOffense.from(modified_deprecated_references_yml_file)
         base_commit_violations = get_violations_before_patch_for(modified_deprecated_references_yml_file)
         added_violations += head_commit_violations - base_commit_violations
         removed_violations += base_commit_violations - head_commit_violations
       end
 
-      # The format for git.renamed_files is a T::Array[{after: "some/path/new", before: "some/path/old"}]
-      renamed_files = git.renamed_files.map { |before_after_file| before_after_file[:after] }
-
       #
       # This implementation creates some false negatives:
       # That is – it doesn't capture some cases:
@@ -106,11 +111,11 @@ module DangerPackwerk
 
       added_violations.each do |violation|
         filepath_that_defines_this_constant = Private.constant_resolver.resolve(violation.class_name)&.location
-        renamed_constants << violation.class_name if renamed_files.include?(filepath_that_defines_this_constant)
+        renamed_constants << violation.class_name if renamed_files_after.include?(filepath_that_defines_this_constant)
       end
 
       relevant_added_violations = added_violations.reject do |violation|
-        renamed_files.include?(violation.file) || renamed_constants.include?(violation.class_name)
+        renamed_files_after.include?(violation.file) || renamed_constants.include?(violation.class_name)
       end
 
       ViolationDiff.new(

data/lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-packwerk
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-12 00:00:00.000000000 Z
+date: 2022-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api