danger-missing_codeowners 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 970c2a9802600b8d3b23d23f23810f11d2c5b3490e32c21b1de0dc662f7a094a
-  data.tar.gz: a1ad21324215c762e3a69515f2b9b66281ef3a8955f238a9f9ff0867d3534f0a
+  metadata.gz: 4ee614f9e8f6c289b7703b986ab724fa66bb09823f63f0d2958db26bbf314692
+  data.tar.gz: c519cae4557cad087b86f80f42ab4ffb5eb45fef4716e9c52ac4c113bee083a7
 SHA512:
-  metadata.gz: e9e820fc8a00114fe751122bcbd230fbeab691541b7e83ab5e2541cf558345461ebcf7b88b0b732fc8eed47ce401a66189acbb6620d441123e334bc81261e864
-  data.tar.gz: 3ac47d981dbc81ab5f733de36da6ff872720bd56a1911e02f0b6219554bf6abaee1e33c075d7012b9e26c648779ffbd2cfc6e5ab0f35881acacec536c27347b1
+  metadata.gz: 25313015ad2565b99b1a91b8d3d62b42f193f0a3e62ceac78188f25569c6df22713c9fe50803bfc0f2c75b5cfc9cbe96a5df9261af1d3132d0a6079380b0d430
+  data.tar.gz: 6adaa343ee28ab37dc60a8855f31572d123ec54392d36e308ea7c46fcbd4a59200c1f7ad18dc0b2b69c83f41bc10138fe052d4894d1b7f9ed7b702c22f3f50c2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-missing_codeowners (1.2.1)
+    danger-missing_codeowners (1.2.2)
       danger-plugin-api (~> 1.0)
       pathspec (~> 1.0.0)
 

data/lib/missing_codeowners/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MissingCodeowners
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/lib/missing_codeowners/plugin.rb

@@ -134,7 +134,7 @@ module Danger
         components = line.split(/\s+(@\S+|\S+@\S+)/).reject { |c| c.strip.empty? }
         if line.match(/^\s*((?:#.*)|(?:\[.*)|(?:\^.*))?$/)
           next # Comment, group or empty line
-        elsif components.length < 2
+        elsif components.empty?
           raise "[ERROR] Invalid CODEOWNERS line: '#{line}'"
         else
           pattern = components[0]

data/spec/fixtures/CODEOWNERS

@@ -42,6 +42,9 @@ path\ with\ spaces/ @space-owner
 foo/bar/  @owners
 feature/  @owners
 
+# Empty owners
+empty/owners/
+
 # Code Owners section:
 
 [Database]

data/spec/missing_codeowners_spec.rb

@@ -50,7 +50,8 @@ module Danger
                           "very/nested/lib/source.js",
                           "very/nested/sources/php/source.php",
                           "model/db/",
-                          "sources/something.go"
+                          "sources/something.go",
+                          "empty/owners/foo.py"
                         ])
 
           @my_plugin.verify
@@ -185,19 +186,6 @@ module Danger
           expect(@my_plugin.files_missing_codeowners.length).to eq(1)
         end
       end
-
-      context "and invalid CODEOWNERS file" do
-        before do
-          allow(@my_plugin).to receive(:find_codeowners_file)
-            .and_return("#{File.dirname(__FILE__)}/fixtures/INVALID_CODEOWNERS")
-        end
-
-        it "raises exception with invalid line" do
-          allow(@my_plugin).to receive(:git_modified_files).and_return(["any_file.yml", "any_file.go"])
-
-          expect { @my_plugin.verify }.to raise_error(RuntimeError)
-        end
-      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-missing_codeowners
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - andre-alves
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-21 00:00:00.000000000 Z
+date: 2024-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -187,7 +187,6 @@ files:
 - lib/missing_codeowners/gem_version.rb
 - lib/missing_codeowners/plugin.rb
 - spec/fixtures/CODEOWNERS
-- spec/fixtures/INVALID_CODEOWNERS
 - spec/missing_codeowners_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/andre-alves/danger-missing_codeowners
@@ -215,6 +214,5 @@ specification_version: 4
 summary: A Danger plugin for checking if files have owners.
 test_files:
 - spec/fixtures/CODEOWNERS
-- spec/fixtures/INVALID_CODEOWNERS
 - spec/missing_codeowners_spec.rb
 - spec/spec_helper.rb

data/spec/fixtures/INVALID_CODEOWNERS

@@ -1,5 +0,0 @@
-# Example of Invalid CODEOWNERS
-
-*.yml @default-codeowner
-*.go @golang
-invalid.txt group