danger-mention 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 213247ca462fd48119c8878ad2495521991b2859
-  data.tar.gz: c5c7dfbaee22aececc7eb8426d9824e270d554fa
+  metadata.gz: 7e43a52772ece5e47082fc17bc2a4a4347716c81
+  data.tar.gz: bab8674d4d4fb7870f8c6d1a00ddace25657b3d6
 SHA512:
-  metadata.gz: 343e44cf2467a419aaeb748b955b94c2631466d36b44cd0fb6bbd1bc6bc6a37b8abad378cd27c28b9263c8710d11f800e45021ecb5e4183b73cdfe2f6cd44230
-  data.tar.gz: eba2f24c5b40df8303395e21318869913a75e3a597a3220fb2bc09a05475e61ff66c957bd687a213deaa94e7179125cb485f5ae6665f92ec66bc33ac737455f9
+  metadata.gz: 0689580ec954452ef86e27aaf2f667ea83f59e90817e71ac86a93debb49c099ff30faf88ec58d3b0114d3eeb6d42927464d34ba0b86807b592c9e1214f7a77b1
+  data.tar.gz: 3eced031241e2c3be33873c1e23383f491ca12948de035fc247e270c37cab84203a0d0591dd24e6c93cc6169e7bd7abe8845d76900498aeddc97012d3644ab38

data/Gemfile

@@ -3,3 +3,4 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rspec', '~> 3.4'
+gem 'pry'

data/Gemfile.lock

@@ -120,6 +120,7 @@ DEPENDENCIES
   danger-mention!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
+  pry
   rake (~> 10.0)
   rspec (~> 3.4)
   rubocop (~> 0.41)

data/README.md

@@ -1,6 +1,6 @@
 # Danger Mention
 
-A [Danger](https://github.com/danger/danger) plugin to automatically mention potential reviewers on pull requests.
+A [Danger](https://github.com/danger/danger) plugin to automatically mention potential reviewers on pull requests on GitHub and GitLab.
 
 ## Installation
 

data/lib/danger_plugin.rb

@@ -75,7 +75,18 @@ module Danger
     def compose_urls(files)
       host = 'https://' + env.request_source.host
       repo_slug = env.ci_source.repo_slug
-      path = host + '/' + repo_slug + '/' + 'blame' + '/' + github.branch_for_base
+
+      path = ""
+      if defined? @dangerfile.gitlab
+        # https://gitlab.com/danger-systems/danger.systems/blame/danger_update/.gitlab-ci.yml
+        path = host + '/' + repo_slug + '/' + 'blame' + '/' + gitlab.branch_for_base
+
+      elsif defined? @dangerfile.github
+        # https://github.com/artsy/emission/blame/master/dangerfile.js
+        path = host + '/' + repo_slug + '/' + 'blame' + '/' + github.branch_for_base
+      else
+        raise "This plugin does not yet support bitbucket, would love PRs: https://github.com/danger/danger-mention/"
+      end
 
       urls = []
       files.each do |file|
@@ -105,7 +116,12 @@ module Danger
     end
 
     def find_reviewers(users, user_blacklist, max_reviewers)
-      user_blacklist << pr_author
+      if defined? @dangerfile.gitlab
+        user_blacklist << gitlab.mr_author
+      elsif defined? @dangerfile.github
+        user_blacklist << github.pr_author
+      end
+
       users = users.select { |k, _| !user_blacklist.include? k }
       users = users.sort_by { |_, value| value }.reverse
 

data/lib/version.rb

@@ -1,4 +1,4 @@
 module DangerMention
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
   DESCRIPTION = 'Danger plugin to automatically mention potential reviewers on pull requests'
 end

data/spec/danger_plugin_spec.rb

@@ -32,21 +32,22 @@ module Danger
 
     describe :compose_urls do
       before do
-        allow(@mention).to receive_message_chain('env.request_source.host').and_return('host')
+        github = Danger::RequestSources::GitHub.new({}, testing_env)
+        allow(@mention).to receive_message_chain('env.request_source').and_return github
         allow(@mention).to receive_message_chain('env.ci_source.repo_slug').and_return('slug')
         allow(@mention).to receive_message_chain('github.branch_for_base').and_return('branch')
       end
 
       it 'composes urls for files' do
         files = (1..4).to_a.map { |i| format('M%d', i) }
-        expected = files.map { |f| format('https://host/slug/blame/branch/%s', f) }
+        expected = files.map { |f| format('https://github.com/slug/blame/branch/%s', f) }
         results = @mention.compose_urls(files)
         expect(results).to eq expected
       end
 
       describe :compose_urls do
         before do
-          allow(@mention).to receive(:pr_author).and_return('author')
+          allow(@mention).to receive_message_chain('github.pr_author').and_return('author')
         end
 
         it 'finds potential reviewers' do
@@ -88,7 +89,31 @@ module Danger
           expect(output).to include('@user2')
         end
       end
+    end
+
+
+    describe :compose_urls_gitlab do
+
+      it 'composes gitlab urls for files' do
+        stub_env = {
+          "DRONE" => true,
+          "DRONE_REPO" => "k0nserv/danger-test",
+          "DRONE_PULL_REQUEST" => "593728",
+          "DANGER_GITLAB_API_TOKEN" => "a86e56d46ac78b"
+        }
+
+        env = Danger::EnvironmentManager.new(testing_env)
+        env.request_source = Danger::RequestSources::GitLab.new(Danger::Drone.new(stub_env), testing_env)
+        danger = Danger::Dangerfile.new(env)
+        allow(danger.gitlab).to receive(:branch_for_base).and_return("branch_name")
 
+        files = (1..4).to_a.map { |i| format('M%d', i) }
+        expected = files.map { |f| format('https://gitlab.com/artsy/eigen/blame/branch_name/%s', f) }
+
+        results = danger.mention.compose_urls(files)
+        expect(results).to eq expected
+      end
     end
   end
 end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-mention
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Wojtek Lukaszuk