danger-mention 0.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a931bd08ddadf8a06b2782b68f0ea90578a886ea
-  data.tar.gz: 663f78d18918c436f6cd52bdb311c46385d8cb84
+  metadata.gz: 8297f54a5ea709aa67d5c032f4bd4b7c203abe7d
+  data.tar.gz: fa6c8849b61ee0e0a5bbdff94ef06070b3301097
 SHA512:
-  metadata.gz: b7b3307926962942d07d84dc7e01572f1d60c8bb54c85a1252b4580fc1a8bcdcb37716332ca50bc6f22115fe96d87fab1527942ef0b98367f2078c1ba0b80fe2
-  data.tar.gz: 424e61736c5ff435b5fec6fc936dd0d88ac53719b187188afcc8aa95d66c4b44e7594f84ff305d976d2208444eb3c2684b9574048264b6cebff9dca91f019108
+  metadata.gz: c2a807ac485bce802c103cdf982b988ee847941853a8027ce0174bc5680a3047a849120c71965a848a2ccb9b326d4c9c4ba361a9397a1deb5305301009ea2cfc
+  data.tar.gz: e253ef9e4789852d7b642f1c1d3aed67f267519b59119a509d5dfa3bff14e8dc6debfe89466322c40aac848a2fbd4e28071952906940b41999ac9000349f4bd9

data/Gemfile

@@ -1,3 +1,5 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'rspec', '~> 3.4'

data/Gemfile.lock

@@ -27,6 +27,7 @@ GEM
       octokit (~> 4.2)
       redcarpet (~> 3.3)
       terminal-table (~> 1)
+    diff-lcs (1.2.5)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.0)
@@ -39,6 +40,19 @@ GEM
     open4 (1.3.4)
     rake (10.5.0)
     redcarpet (3.3.4)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.1)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
     sawyer (0.7.0)
       addressable (>= 2.3.5, < 2.5)
       faraday (~> 0.8, < 0.10)
@@ -51,6 +65,7 @@ DEPENDENCIES
   bundler (~> 1.3)
   danger-mention!
   rake (~> 10.0)
+  rspec (~> 3.4)
 
 BUNDLED WITH
    1.11.2

data/Rakefile

@@ -1 +1,5 @@
 require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+task default: :spec

data/danger-mention.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = DangerMention::VERSION
   spec.authors       = ['Wojtek Lukaszuk']
   spec.email         = ['wojciech.lukaszuk@icloud.com']
-  spec.description   = %q{Danger plugin to automatically mention potential reviewers on pull requests.}
-  spec.summary       = %q{Danger plugin to automatically mention potential reviewers on pull requests}
+  spec.description   = 'Danger plugin to automatically mention potential reviewers on pull requests.'
+  spec.summary       = 'Danger plugin to automatically mention potential reviewers on pull requests.'
   spec.homepage      = 'https://github.com/wojteklu/danger-mention'
   spec.license       = 'MIT'
 
@@ -22,4 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 10.0'
 
+  # Testing support
+  spec.add_development_dependency 'rspec', '~> 3.4'
+
 end

data/lib/danger_plugin.rb

@@ -1,4 +1,5 @@
 require 'open-uri'
+require_relative 'finder'
 
 module Danger
 
@@ -47,21 +48,16 @@ module Danger
       end
     end
 
-    private
-
     def select_files(file_blacklist)
-      files = modified_files + deleted_files
+      files = Finder.parse(env.scm.diff)
+
       file_blacklist = file_blacklist.map { |f| /#{f}/ }
       re = Regexp.union(file_blacklist)
-
       files = files.select { |f| !f.match(re) }
 
-      # select just 6 random files
-      # gonna be changed in next version
-      files[0...6]
+      files[0...3]
     end
 
-
     def compose_urls(files)
       host = 'https://' + env.request_source.host
       repo_slug = env.ci_source.repo_slug
@@ -97,11 +93,9 @@ module Danger
     def find_reviewers(users, user_blacklist, max_reviewers)
       user_blacklist << pr_author
       users = users.select { |k, _| !user_blacklist.include? k }
+      users = users.sort_by { |_, value| value }.reverse
 
-      max_values = users.values.sort.reverse[0..max_reviewers]
-      users = users.select { |_, v| max_values.include? v }
-
-      users.keys
+      users[0...max_reviewers].map { |u| u[0] }
     end
 
   end

data/lib/finder.rb

@@ -0,0 +1,37 @@
+class FileInfo
+  attr_accessor :name
+  attr_accessor :changed_lines
+
+  def initialize(name, changed_lines)
+    self.name = name
+    self.changed_lines = changed_lines
+  end
+end
+
+class Finder
+  def self.parse(diff)
+    files = []
+
+    diff.each do |f|
+      name = f.path
+
+      if f.type != 'modified'
+        files << FileInfo.new(name, 0)
+        next
+      end
+
+      lines = f.patch.split(/\n/).reject(&:empty?)
+
+      count = 0
+      lines[4..-1].each do |line|
+        count += 1 if line.start_with?('-', '+')
+      end
+
+      files << FileInfo.new(name, count)
+    end
+
+    files = files.sort_by(&:changed_lines).reverse
+    files.map(&:name)
+  end
+
+end

data/lib/version.rb

@@ -1,4 +1,4 @@
 module DangerMention
-  VERSION = "0.1"
-  DESCRIPTION = "Danger plugin to automatically mention potential reviewers on pull requests"
+  VERSION = '0.2'
+  DESCRIPTION = 'Danger plugin to automatically mention potential reviewers on pull requests'
 end

data/spec/danger_plugin_spec.rb

@@ -0,0 +1,92 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe DangerMention do
+    before do
+      @mention = testing_dangerfile.mention
+    end
+
+    it 'is a plugin' do
+      expect(Danger::DangerMention < Danger::Plugin).to be_truthy
+    end
+
+    describe :select_files do
+      before do
+        modified_files = (1..2).to_a.map { |i| format('M%d', i) }
+        deleted_files = (1..2).to_a.map { |i| format('D%d', i) }
+        allow(Finder).to receive(:parse).and_return(modified_files + deleted_files)
+      end
+
+      it 'takes first 3 modified files' do
+        files = @mention.select_files([])
+        expect(files).to eq %w(M1 M2 D1)
+      end
+
+      it 'does not return blacklisted files' do
+        files = @mention.select_files(['M.*'])
+        expect(files).to eq %w(D1 D2)
+      end
+    end
+
+    describe :compose_urls do
+      before do
+        allow(@mention).to receive_message_chain('env.request_source.host').and_return('host')
+        allow(@mention).to receive_message_chain('env.ci_source.repo_slug').and_return('slug')
+        allow(@mention).to receive_message_chain('branch_for_base').and_return('branch')
+      end
+
+      it 'composes urls for files' do
+        files = (1..4).to_a.map { |i| format('M%d', i) }
+        expected = files.map { |f| format('https://host/slug/blame/branch/%s', f) }
+        results = @mention.compose_urls(files)
+        expect(results).to eq expected
+      end
+
+      describe :compose_urls do
+        before do
+          allow(@mention).to receive(:pr_author).and_return('author')
+        end
+
+        it 'finds potential reviewers' do
+          users = Hash[(1..10).to_a.collect { |v| [format('user%s', v), v] }]
+          expected = %w(user10 user9 user8)
+          results = @mention.find_reviewers(users, [], 3)
+
+          expect(results).to eq expected
+        end
+
+        it 'does not return pr author' do
+          users = Hash['author' => 1]
+          results = @mention.find_reviewers(users, [], 3)
+
+          expect(results).to eq []
+        end
+
+        it 'does not return blacklisted users' do
+          users = Hash['user10' => 1]
+          results = @mention.find_reviewers(users, ['user10'], 1)
+
+          expect(results).to eq []
+        end
+      end
+
+      describe :run do
+        before do
+          allow(@mention).to receive(:select_files).and_return(%w(M1 M2))
+          allow(@mention).to receive(:parse_blame).and_return({})
+          allow(@mention).to receive(:find_reviewers).and_return(%w(user1 user2))
+        end
+
+        it 'mentions potential reviewers' do
+          @mention.run
+          output = @mention.status_report[:markdowns].first
+
+          expect(output).to_not be_empty
+          expect(output).to include('@user1')
+          expect(output).to include('@user2')
+        end
+      end
+
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,31 @@
+require 'pathname'
+
+ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+$LOAD_PATH.unshift((ROOT + 'lib').to_s)
+$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+
+RSpec.configure do |config|
+  # Use color in STDOUT
+  config.color = true
+end
+
+require 'danger'
+require 'cork'
+require 'danger_plugin'
+
+def testing_ui
+  Cork::Board.new(silent: true)
+end
+
+def testing_env
+  {
+    'HAS_JOSH_K_SEAL_OF_APPROVAL' => 'true',
+    'TRAVIS_PULL_REQUEST' => '1',
+    'TRAVIS_REPO_SLUG' => 'test'
+  }
+end
+
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-mention
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
 platform: ruby
 authors:
 - Wojtek Lukaszuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-19 00:00:00.000000000 Z
+date: 2016-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
 description: Danger plugin to automatically mention potential reviewers on pull requests.
 email:
 - wojciech.lukaszuk@icloud.com
@@ -67,7 +81,10 @@ files:
 - Rakefile
 - danger-mention.gemspec
 - lib/danger_plugin.rb
+- lib/finder.rb
 - lib/version.rb
+- spec/danger_plugin_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/wojteklu/danger-mention
 licenses:
 - MIT
@@ -91,5 +108,5 @@ rubyforge_project:
 rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
-summary: Danger plugin to automatically mention potential reviewers on pull requests
+summary: Danger plugin to automatically mention potential reviewers on pull requests.
 test_files: []