danger-lgtm 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c41e972ff6217e87e4faeda85e8a008f1c2b3112
-  data.tar.gz: 285fad85d2d187eac5a483f24c74781dc644dd3a
+  metadata.gz: fc895c5b5010b4c4a5f4d7447c0f1e8ae6c3e739
+  data.tar.gz: 7e65307505e57e652024c53b27aa9e155f4115f3
 SHA512:
-  metadata.gz: ba670e45ef28ba76197fcd7fac93ddd34d4e0313db4017e14fa010290af3f0007864de857333c53eccef7d749e826222cab387879490c66188f98d5e6321dcb6
-  data.tar.gz: 68b6ec3cca877bcde72f97da32c0f50dfdd3198858f19d4a3800cdd778337b7c2299ca994d00f5adfdcfbb7e908e944d0767da7552cccafbd4bf6a65b6d24077
+  metadata.gz: feabb54a4e5d374387f0d64542565991115236d90a1cd098e54cb68250662368f12694f745f19900b1974a65f9abbec1aeb18836ca13f2251fa44324bfe6c606
+  data.tar.gz: 66d8d3a8f931cad7346f4e3ef563da528b14c561cec252e4c11c4d0b556a3b7f4cb7b6bc3dd4f3317bdbb755f6278f14022c7c1fc2939f802f7be66cb1f2471f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-lgtm (1.0.1)
+    danger-lgtm (1.0.2)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -19,7 +19,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.6.2)
+    danger (5.6.4)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)

data/lib/lgtm/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lgtm
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.0.2'.freeze
 end

data/lib/lgtm/plugin.rb

@@ -39,9 +39,9 @@ module Danger
 
     private
 
+    # returns "<h1 align="center">LGTM</h1>" when ServiceTemporarilyUnavailable.
     def fetch_image_url(https_image_only: false)
-      lgtm_post_url = process_request(RANDOM_LGTM_POST_URL)['location']
-
+      return unless lgtm_post_url
       lgtm_post_response = process_request(lgtm_post_url) do |req|
         req['Accept'] = 'application/json'
       end
@@ -67,8 +67,18 @@ module Danger
       end
     end
 
+    def lgtm_post_url
+      lgtm_post_req = process_request(RANDOM_LGTM_POST_URL)
+      return if lgtm_post_req.code == '503'
+      lgtm_post_req['location']
+    end
+
     def markdown_template(image_url)
-      "<p align='center'><img src='#{image_url}' alt='LGTM' /></p>"
+      if image_url.nil?
+        "<h1 align='center'>LGTM</h1>"
+      else
+        "<p align='center'><img src='#{image_url}' alt='LGTM' /></p>"
+      end
     end
   end
 end

data/spec/lgtm_spec.rb

@@ -25,13 +25,24 @@ module Danger
         expect(@dangerfile.status_report[:markdowns].length).to eq(1)
       end
 
+      it 'lgtm with default url is OverQuota' do
+        allow(Net::HTTP).to receive(:start).and_return(mock(code: '503'))
+
+        @lgtm.check_lgtm
+
+        expect(@dangerfile.status_report[:markdowns][0].message)
+          .to eq("<h1 align='center'>LGTM</h1>")
+      end
+
       def mock(request_url: 'https://lgtm.in/p/sSuI4hm0q',
-               actual_image_url: 'https://example.com/image.jpg')
+               actual_image_url: 'https://example.com/image.jpg',
+               code: '302')
         double(
           :[] => request_url,
           body: JSON.generate(
             actualImageUrl: actual_image_url
-          )
+          ),
+          code: code
         )
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-lgtm
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - leonhartX
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-28 00:00:00.000000000 Z
+date: 2018-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -193,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Danger Plugin used to post LGTM iamge when there is no violations