danger-lgtm 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58d8c218679e3e92cd006bd729372d134da6ae8d
-  data.tar.gz: 2ce6309beacdde7d1f05ec2c69bc22d2ee9159d7
+  metadata.gz: 2003b650eca71ba9c3c9ac91b86eda29757349c7
+  data.tar.gz: 9d258b59a6f6f0ab638f556ae7b91b7b4cf11563
 SHA512:
-  metadata.gz: 20e79789224b8dc14ba329f6b90feb867d91f95dcc91be3f795d5ecd00574c1e5c469d1c7db1ab350a5d88b6d7a0174f3a53ffbb8d370a8964756d36508f6680
-  data.tar.gz: c4fd46569128e03849e82f465ba00b6d3f3068a294b281a14fb54b35fba579ab45123bcd2945d2acf2d78a6e693b32e5dd45bef114976506b210568183b6e4f4
+  metadata.gz: 48166fec2e2aa69503e71431839aacb146864505efb2cf26297b9d2fcf36823b9dab78b7b42c94da1dee51a394a44c92de810f91a9ee1fc4419066cc23f4473f
+  data.tar.gz: 2309634a33d3d73baf5a429ac054bbcd4d01f4d27234b7187f336e3fa41d80226569707ddffe9d79e1ad0b4eb2fd8b70db2a3a956e887eac60be632a3180a4f3

data/.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 pkg
 .idea/
+.vscode/

data/.rubocop.yml

@@ -0,0 +1,3 @@
+Metrics/BlockLength:
+  Exclude:
+    - "**/*_spec.rb"

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    danger-lgtm (0.1.1)
+    danger-lgtm (0.2.0)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.0)
+    addressable (2.5.1)
       public_suffix (~> 2.0, >= 2.0.2)
     ast (2.3.0)
     claide (1.0.1)
@@ -16,11 +16,10 @@ GEM
       nap
       open4 (~> 1.3)
     coderay (1.1.1)
-    colored (1.2)
     colored2 (3.1.2)
-    cork (0.2.0)
-      colored (~> 1.2)
-    danger (4.3.0)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (5.2.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -34,7 +33,7 @@ GEM
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.3)
-    faraday (0.11.0)
+    faraday (0.12.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
@@ -67,7 +66,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.6.2)
+    octokit (4.7.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parser (2.4.0.0)
@@ -108,8 +107,8 @@ GEM
       faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.7.3)
-      unicode-display_width (~> 1.1.1)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
     thor (0.19.4)
     unicode-display_width (1.1.3)
     yard (0.9.8)
@@ -130,4 +129,4 @@ DEPENDENCIES
   yard (~> 0.8)
 
 BUNDLED WITH
-   1.14.6
+   1.15.0

data/README.md

@@ -1,4 +1,5 @@
 [![Gem](https://img.shields.io/gem/v/danger-lgtm.svg)](https://rubygems.org/gems/danger-lgtm)
+[![Gem](https://img.shields.io/gem/dt/danger-lgtm.svg)](https://rubygems.org/gems/danger-lgtm)
 [![Gem](https://img.shields.io/gem/dtv/danger-lgtm.svg)](https://rubygems.org/gems/danger-lgtm)
 [![Travis branch](https://img.shields.io/travis/leonhartX/danger-lgtm/master.svg)](https://travis-ci.org/leonhartX/danger-lgtm)
 # danger-lgtm

data/lib/danger_lgtm.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'lgtm/gem_version'

data/lib/danger_plugin.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'lgtm/plugin'

data/lib/lgtm/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Lgtm
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.2.0'.freeze
 end

data/lib/lgtm/plugin.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'uri'
+require 'json'
 require 'net/http'
 
 module Danger
@@ -12,6 +16,8 @@ module Danger
   # @tags lgtm, github
   #
   class DangerLgtm < Plugin
+    RANDOM_LGTM_POST_URL = 'http://lgtm.in/g'.freeze
+
     # Check status report, say lgtm if no violations
     # Generates a `markdown` of a lgtm iamge.
     #
@@ -22,11 +28,40 @@ module Danger
     def check_lgtm(image_url: nil)
       return unless status_report[:errors].length.zero? &&
                     status_report[:warnings].length.zero?
-      unless image_url
-        id = Net::HTTP.get_response('lgtm.in', '/g')['location'].split('/').last
-        image_url = "https://lgtm.in/p/#{id}"
+
+      image_url ||= fetch_image_url
+
+      markdown(
+        markdown_template(image_url)
+      )
+    end
+
+    private
+
+    def fetch_image_url
+      lgtm_post_url = process_request(RANDOM_LGTM_POST_URL)['location']
+
+      lgtm_post_response = process_request(lgtm_post_url) do |req|
+        req['Accept'] = 'application/json'
       end
-      markdown("![LGTM](#{image_url})")
+
+      lgtm_post = JSON.parse(lgtm_post_response.body)
+
+      lgtm_post['actualImageUrl']
+    end
+
+    def process_request(url)
+      uri = URI(url)
+
+      req = Net::HTTP::Get.new(uri)
+
+      yield req if block_given?
+
+      Net::HTTP.start(uri.hostname, uri.port) { |http| http.request(req) }
+    end
+
+    def markdown_template(image_url)
+      "<p align='center'><img src='#{image_url}' alt='LGTM' /></p>"
     end
   end
 end

data/spec/lgtm_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../spec_helper', __FILE__)
 
 module Danger
@@ -24,9 +26,19 @@ module Danger
       end
 
       it 'pick random pic from lgtm.in' do
+        mock = double(
+          :[] => 'https://lgtm.in/p/sSuI4hm0q',
+          body: JSON.generate(
+            actualImageUrl: 'https://example.com/image.jpg'
+          )
+        )
+
+        allow(Net::HTTP).to receive(:start).and_return(mock)
+
         @lgtm.check_lgtm
+
         expect(@dangerfile.status_report[:markdowns][0].message)
-          .to match(%r{https:\/\/lgtm.\in\/p\/})
+          .to match(%r{https:\/\/example.com\/image.jpg})
       end
 
       it 'use given url' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('../../', __FILE__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-lgtm
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - leonhartX
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-19 00:00:00.000000000 Z
+date: 2017-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -158,6 +158,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
@@ -192,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Danger Plugin used to post LGTM iamge when there is no violations