danger-junit 0.7.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e4fee6603ee8518a035652d71f265d6d2e868a86
-  data.tar.gz: 488242d6b63b32f260f581581d8a6feb890596be
+SHA256:
+  metadata.gz: a77f977d090351e161a00681133882722b68f9bb6b28ac4cbebff16c2e36828e
+  data.tar.gz: 43c9a8ed5b86acfe14408d24da7555d396a2495c5ac4eac891390c843e3e4465
 SHA512:
-  metadata.gz: b8a8f6051e4dc5fa807708f6f79f8ade2c4df1358234ab4710bac1034bc146142b71fabf91bae376a70da0c94a8510ab6b9a0a334403cf81d8e4c2761c9e5193
-  data.tar.gz: 5087c98670f0151e6e290b4ab0cfe77a12bb445d3d380a78b8df281ffd03c8af81ca19a9ebb279a17f54c210080a452e75d8bae20a70059406f82846efdf06bd
+  metadata.gz: c2592d04156cdab05b89e5462b018ad9fededda320c544d05bea486a468cc6bf30ded2b20c503de339004b3bb588707a39e83d57494ec56b6bc7bd7fbcde35c5
+  data.tar.gz: b58ab5044bee356598b5f7458d76c40e319e8aa9103087825d3612bffa0a3b6ab022661660d89edca3113da3df67dfbe9ab4e9bde6695cb3b7c47f40668e70d3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-junit (0.7.4)
+    danger-junit (1.0.0)
       danger (> 2.0)
       ox (~> 2.0)
 
@@ -21,25 +21,26 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.3.3)
+    danger (5.9.0)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
       faraday-http-cache (~> 1.0)
-      git (~> 1)
+      git (~> 1.5)
       kramdown (~> 1.5)
+      no_proxy_fix
       octokit (~> 4.7)
       terminal-table (~> 1)
     diff-lcs (1.2.5)
-    faraday (0.13.1)
+    faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
     ffi (1.9.14)
     formatador (0.2.5)
-    git (1.3.0)
+    git (1.5.0)
     guard (2.14.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -54,7 +55,7 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.15.0)
+    kramdown (1.17.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
@@ -63,13 +64,14 @@ GEM
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
+    no_proxy_fix (0.1.2)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.7.0)
+    octokit (4.13.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    ox (2.5.0)
+    ox (2.10.0)
     parser (2.3.1.2)
       ast (~> 2.2)
     powerpack (0.1.1)
@@ -77,7 +79,7 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    public_suffix (2.0.5)
+    public_suffix (3.0.3)
     rainbow (2.1.0)
     rake (10.5.0)
     rb-fsevent (0.9.7)
@@ -134,4 +136,4 @@ DEPENDENCIES
   yard (~> 0.8)
 
 BUNDLED WITH
-   1.15.4
+   1.16.3

data/lib/junit/gem_version.rb

@@ -1,3 +1,3 @@
 module Junit
-  VERSION = '0.7.4'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/lib/junit/plugin.rb

@@ -14,6 +14,16 @@ module Danger
   #          junit.parse "/path/to/output.xml"
   #          junit.report
   #
+  # @example Parse multiple XML files by passing multiple file names
+  #
+  #          junit.parse_files "/path/to/integration-tests.xml", "/path/to/unit-tests.xml"
+  #          junit.report
+  #
+  # @example Parse multiple XML files by passing an array
+  #          result_files = %w(/path/to/integration-tests.xml /path/to/unit-tests.xml)
+  #          junit.parse_files result_files
+  #          junit.report
+  #
   # @example Let the plugin parse the XML file, and report yourself
   #
   #          junit.parse "/path/to/output.xml"
@@ -76,7 +86,8 @@ module Danger
     attr_accessor :show_skipped_tests
 
     # An array of symbols that become the columns of your tests,
-    # if `nil`, the default, it will be all of the attributes.
+    # if `nil`, the default, it will be all of the attributes for a single parse
+    # or all of the common attributes between multiple files
     #
     # @return   [Array<Symbol>]
     attr_accessor :headers
@@ -85,17 +96,29 @@ module Danger
     # will `raise` for errors
     # @return   [void]
     def parse(file)
+      parse_files(file)
+    end
+
+    # Parses multiple XML files, which fills all the attributes,
+    # will `raise` for errors
+    # @return   [void]
+    def parse_files(*files)
       require 'ox'
-      raise "No JUnit file was found at #{file}" unless File.exist? file
+      @tests = []
+      failed_tests = []
 
-      xml_string = File.read(file)
-      @doc = Ox.parse(xml_string)
+      Array(files).flatten.each do |file|
+        raise "No JUnit file was found at #{file}" unless File.exist? file
 
-      suite_root = @doc.nodes.first.value == 'testsuites' ? @doc.nodes.first : @doc
-      @tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
+        xml_string = File.read(file)
+        doc = Ox.parse(xml_string)
 
-      failed_suites = suite_root.nodes.select { |suite| suite[:failures].to_i > 0 || suite[:errors].to_i > 0 }
-      failed_tests = failed_suites.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
+        suite_root = doc.nodes.first.value == 'testsuites' ? doc.nodes.first : doc
+        @tests += suite_root.nodes.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
+
+        failed_suites = suite_root.nodes.select { |suite| suite[:failures].to_i > 0 || suite[:errors].to_i > 0 }
+        failed_tests += failed_suites.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
+      end
 
       @failures = failed_tests.select do |test| 
         test.nodes.count > 0
@@ -135,14 +158,15 @@ module Danger
 
         tests = (failures + errors)
 
+        common_attributes = tests.map{|test| test.attributes.keys }.inject(&:&)
+
         # check the provided headers are available
         unless headers.nil?
-          attributtesKey = tests.first.attributes.keys
-          not_available_headers = headers.select { |header| not attributtesKey.include?(header) }
+          not_available_headers = headers.select { |header| not common_attributes.include?(header) }
           raise "Some of headers provided aren't available in the JUnit report (#{not_available_headers})" unless not_available_headers.empty?
         end
 
-        keys = headers || tests.first.attributes.keys
+        keys = headers || common_attributes
         attributes = keys.map(&:to_s).map(&:capitalize)
 
         # Create the headers

data/spec/junit_spec.rb

@@ -87,6 +87,36 @@ module Danger
         outputs = @junit.status_report[:markdowns].first
         expect(outputs.to_s).to include('github.com/thing/thingy')
       end
+
+      describe 'parsing multiple files' do
+        it 'gets the right results for multiple files' do
+          @junit.parse_files 'spec/fixtures/rspec_fail.xml', 'spec/fixtures/fastlane_trainer.xml'
+
+          expect(@junit.failures.count).to eq 1 + 1
+          expect(@junit.passes.count).to eq 190 + 1
+          expect(@junit.errors.count).to eq 0 + 0
+          expect(@junit.skipped.count).to eq 7 + 0
+        end
+
+        it 'gets the right results for an array of files' do
+          files = %w(spec/fixtures/rspec_fail.xml spec/fixtures/fastlane_trainer.xml)
+          @junit.parse_files files
+
+          expect(@junit.failures.count).to eq 1 + 1
+          expect(@junit.passes.count).to eq 190 + 1
+          expect(@junit.errors.count).to eq 0 + 0
+          expect(@junit.skipped.count).to eq 7 + 0
+        end
+
+        it 'defaults to reporting common attributes for multiple files' do
+          @junit.parse_files 'spec/fixtures/rspec_fail.xml', 'spec/fixtures/eigen_fail.xml'
+
+          @junit.report
+
+          outputs = @junit.status_report[:markdowns].first
+          expect(outputs.to_s).to include('Classname | Name')
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-junit
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Orta Therox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2019-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -225,8 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Get automatic inline test reporting for JUnit-conforming XML files