danger-junit 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58c923a604963a4621a2ba5bd2034933df54b684
-  data.tar.gz: eddcbb189a7161a39db64ea1ee95d6c3a4303229
+  metadata.gz: 11c90a8c04d958031389e06046851da0bd340567
+  data.tar.gz: 630cad02ddbee1575b42f9a586d9a458367e0693
 SHA512:
-  metadata.gz: 89f9ba58e802a44f84c1e0a5a0002ebd19d1982b09ea2c29d23a713f96016de2f227efe069dfa91a55a0fd465f2ceffad94ded81c8d757b729dcadbcb972af71
-  data.tar.gz: bb4a172c51a0277c9be1da381faba9e3ffbf7bf61afd8eb574f42db9787133b02ac2703099f4bcaca42dd53523a428475f7b38b31294dcbbb5707ad9ba01b75d
+  metadata.gz: d9d8f576d975c6b96a998dfc46c0a56814c75b27bc43aa101e904026c652222e78845c2fec4475c16bce439d9602ceb89ff00268bf3154a32dcf03628b1951d1
+  data.tar.gz: 3d91dbab3426cd94525eb05cd004145a21da9408887a8fead38ddc3f21676fad20d94bc4646ec1cb63333086378ebf0e4cf83e3f8545f8722fd04ce5db7e24d6

data/lib/junit/gem_version.rb

@@ -1,3 +1,3 @@
 module Junit
-  VERSION = '0.7.2'.freeze
+  VERSION = '0.7.3'.freeze
 end

data/lib/junit/plugin.rb

@@ -92,10 +92,10 @@ module Danger
       @doc = Ox.parse(xml_string)
 
       suite_root = @doc.nodes.first.value == 'testsuites' ? @doc.nodes.first : @doc
-      @tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
+      @tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
 
       failed_suites = suite_root.nodes.select { |suite| suite[:failures].to_i > 0 || suite[:errors].to_i > 0 }
-      failed_tests = failed_suites.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
+      failed_tests = failed_suites.map(&:nodes).flatten.select { |node| node.kind_of?(Ox::Element) && node.value == 'testcase' }
 
       @failures = failed_tests.select do |test| 
         test.nodes.count > 0

data/spec/fixtures/fastlane_trainer.xml

@@ -1,5 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <testsuites tests="2" failures="1">
+    <testsuite name="EmptyTests" tests="0" failures="0">
+    </testsuite>
     <testsuite name="ThemojiUITests" tests="2" failures="1">
         <testcase classname="ThemojiUITests" name="testExample()">
         </testcase>
@@ -8,4 +10,4 @@
             </failure>
         </testcase>
     </testsuite>
-</testsuites>
+</testsuites>

data/spec/junit_spec.rb

@@ -55,7 +55,7 @@ module Danger
 
         output = @junit.status_report[:markdowns].first
         row = '| Danger::CISource::CircleCI validates when circle all env vars are set | ./spec/lib/danger/ci_sources/circle_spec.rb | 0.012097|'
-        expect(output).to include(row)
+        expect(output.to_s).to include(row)
       end
 
       it 'shows a known markdown row' do
@@ -65,7 +65,7 @@ module Danger
 
         output = @junit.status_report[:markdowns].first
         row = "Time|\n"
-        expect(output).to include(row)
+        expect(output.to_s).to include(row)
       end
 
       it 'shows a warning for skipped' do
@@ -78,14 +78,14 @@ module Danger
       end
 
       it 'links paths that are files' do
-        allow(@dangerfile.github).to receive(:pr_json).and_return(head: { repo: { html_url: 'https://github.com/thing/thingy' } })
+        allow(@dangerfile.github).to receive(:pr_json).and_return('head' => { 'repo' => { 'html_url' => 'https://github.com/thing/thingy' } })
         allow(@dangerfile.github).to receive(:head_commit).and_return('hello')
 
         @junit.parse 'spec/fixtures/danger-junit-fail.xml'
         @junit.report
 
         outputs = @junit.status_report[:markdowns].first
-        expect(outputs).to include('github.com/thing/thingy')
+        expect(outputs.to_s).to include('github.com/thing/thingy')
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-junit
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Orta Therox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-12 00:00:00.000000000 Z
+date: 2017-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger