danger-junit 0.6.4 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a8275408662c8c7e43cb5e021b9d4e0aba5ca89
-  data.tar.gz: fe861876aa05c98d15dbf8dcfd739cc9f564a198
+  metadata.gz: f82fa75a940b47aec4595195cb3c22a2efd6c245
+  data.tar.gz: acea0f9b7335b0fb7ca4ec013f4529ec031e772c
 SHA512:
-  metadata.gz: 59fc85be4a5299fa24b9f23cc11e4a454d50270d4b2ab1ed8247932959c605dbf5cb55f26902fd50832b007170f3fb36cc854dd926d98486b801e9ea9193a33e
-  data.tar.gz: 88d2386fd4fdcbfbe00bd8cf08f5a6010ba27627d88d390b680c8332c67ed607d28595d4676e3e4898ed55893d69ce21e048a51ebe07de3a247fa5d28945796e
+  metadata.gz: a3ae64fc76315bc2eeaf01cf58bd5eaf1b8f7d984b948cfc50a9eb2904c7e2cfcce8e226d05b5b7fd1ff5a83d457665c8a6539e2b7ce992041877e4e79d799dc
+  data.tar.gz: 9612320f665727ba7d3330c59cab98e7bdc9aa27456ed1cc92d235e5501834bfd0e5efc6f8ac985cfdf2137601387d519019dcab25c3f5852c333991fd62117b

data/.gitignore

@@ -1,4 +1,4 @@
 .DS_Store
 pkg
 .idea/
-danger-junit-fail.xml
+/danger-junit-fail.xml

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-junit (0.6.2)
+    danger-junit (0.6.4)
       danger (~> 2.0)
       ox (~> 2.0)
 
@@ -20,7 +20,7 @@ GEM
     colored (1.2)
     cork (0.1.0)
       colored (~> 1.2)
-    danger (2.0.1)
+    danger (2.1.1)
       claide (~> 1.0)
       claide-plugins (> 0.9.0)
       colored (~> 1.2)
@@ -28,8 +28,8 @@ GEM
       faraday (~> 0)
       faraday-http-cache (~> 1.0)
       git (~> 1)
+      kramdown (~> 1.5)
       octokit (~> 4.2)
-      redcarpet (~> 3.3)
       terminal-table (~> 1)
     diff-lcs (1.2.5)
     faraday (0.9.2)
@@ -53,6 +53,7 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
+    kramdown (1.11.1)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
@@ -80,7 +81,6 @@ GEM
     rb-fsevent (0.9.7)
     rb-inotify (0.9.7)
       ffi (>= 0.5.0)
-    redcarpet (3.3.4)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
       rspec-expectations (~> 3.5.0)

data/README.md

@@ -39,7 +39,11 @@ Then you can pass the `junit-results.xml` file to the plugin in your `Dangerfile
 
 ### iOS
 
-Both [xcpretty](https://github.com/supermarin/xcpretty#reporters) and [XCTool](https://github.com/facebook/xctool#included-reporters) include reporters for creating a JUnit XML file. As Fastlane's [scan](https://github.com/fastlane/fastlane/tree/master/scan) uses xcpretty, it also has support for the file.
+You have a lot of options:
+
+* [trainer](https://github.com/krausefx/trainer) is the fastest way to generate the junit file.
+* [xcpretty](https://github.com/supermarin/xcpretty#reporters)  is used in both Fastlane, and a lot of standard setups.
+* [XCTool](https://github.com/facebook/xctool#included-reporters) includes it's own reporter for creating the file. 
 
 ### junit
 

data/danger-junit.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'ox', '~> 2.0'
 
   # So we can run our specs with junit
-  spec.add_development_dependency "rspec_junit_formatter", "~> 0.2"
+  spec.add_development_dependency 'rspec_junit_formatter', '~> 0.2'
 
   # General ruby development
   spec.add_development_dependency 'bundler', '~> 1.3'

data/lib/junit/gem_version.rb

@@ -1,3 +1,3 @@
 module Junit
-  VERSION = '0.6.4'.freeze
+  VERSION = '0.7.0'.freeze
 end

data/lib/junit/plugin.rb

@@ -39,11 +39,12 @@ module Danger
   #          message "#{slowest_test[:time]} took #{slowest_test[:time]} seconds"
   #
   #
-  # @see  orta/danger-junit, danger/danger, artsy/eigen
+  # @see  orta/danger-junit
+  # @see  danger/danger
+  # @see  artsy/eigen
   # @tags testing, reporting, junit, rspec, jasmine, jest, xcpretty
   #
   class DangerJunit < Plugin
-
     # All the tests for introspection
     #
     # @return   [Array<Ox::Element>]
@@ -80,15 +81,15 @@ module Danger
     # @return   [Array<Symbol>]
     attr_accessor :headers
 
-    # Parses an XML file, which fills all the attributes
+    # Parses an XML file, which fills all the attributes,
     # will `raise` for errors
     # @return   [void]
     def parse(file)
       require 'ox'
       raise "No Junit file was found at #{file}" unless File.exist? file
 
-      xml_string = File.read file
-      @doc = Ox.parse xml_string
+      xml_string = File.read(file)
+      @doc = Ox.parse(xml_string)
 
       suite_root = @doc.nodes.first.value == 'testsuites' ? @doc.nodes.first : @doc
       @tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
@@ -96,9 +97,26 @@ module Danger
       failed_suites = suite_root.nodes.select { |suite| suite[:failures].to_i > 0 || suite[:errors].to_i > 0 }
       failed_tests = failed_suites.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
 
-      @failures = failed_tests.select { |test| test.nodes.count > 0 }.select { |test| test.nodes.first.value == 'failure' }
-      @errors = failed_tests.select { |test| test.nodes.count > 0 }.select { |test| test.nodes.first.value == 'error' }
-      @skipped = tests.select { |test| test.nodes.count > 0 }.select { |test| test.nodes.first.value == 'skipped' }
+      @failures = failed_tests.select do |test| 
+        test.nodes.count > 0
+      end.select do |test|
+        node = test.nodes.first
+        node.kind_of?(Ox::Element) && node.value == 'failure'
+      end
+
+      @errors = failed_tests.select do |test| 
+        test.nodes.count > 0
+      end.select do |test| 
+        node = test.nodes.first
+        node.kind_of?(Ox::Element) && node.value == 'error'
+      end
+
+      @skipped = tests.select do |test| 
+        test.nodes.count > 0
+      end.select do |test| 
+        node = test.nodes.first
+        node.kind_of?(Ox::Element) && node.value == 'skipped'
+      end
 
       @passes = tests - @failures - @errors - @skipped
     end
@@ -112,7 +130,7 @@ module Danger
       warn("Skipped #{skipped.count} tests.") if show_skipped_tests && skipped.count > 0
 
       unless failures.empty? && errors.empty?
-        fail("Tests have failed, see below for more information.", sticky: false)
+        fail('Tests have failed, see below for more information.', sticky: false)
         message = "### Tests: \n\n"
 
         tests = (failures + errors)

data/spec/fixtures/danger-junit-fail.xml

@@ -0,0 +1,67 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="rspec" tests="48" failures="1" errors="0" time="1.485178" timestamp="2016-08-06T20:02:41-04:00">
+  <!-- Randomized with seed 55363 -->
+  <properties/>
+  <testcase classname="spec.lib.danger.ci_sources.buildkite_spec" name="Danger::Buildkite validates when buildkite all env vars is found" file="./spec/lib/danger/ci_sources/buildkite_spec.rb" time="0.000594"/>
+  <testcase classname="spec.lib.danger.ci_sources.buildkite_spec" name="Danger::Buildkite doesnt validate when buildkite is not found" file="./spec/lib/danger/ci_sources/buildkite_spec.rb" time="0.000111"/>
+  <testcase classname="spec.lib.danger.ci_sources.buildkite_spec" name="Danger::Buildkite gets out a repo slug from a git+ssh repo and pull request number" file="./spec/lib/danger/ci_sources/buildkite_spec.rb" time="0.000425"/>
+  <testcase classname="spec.lib.danger.ci_sources.buildkite_spec" name="Danger::Buildkite gets out a repo slug from a https repo and pull request number" file="./spec/lib/danger/ci_sources/buildkite_spec.rb" time="0.000091"/>
+  <testcase classname="spec.lib.danger.ci_sources.buildkite_spec" name="Danger::Buildkite doesn't continue when the build is not a pull request" file="./spec/lib/danger/ci_sources/buildkite_spec.rb" time="0.000103"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_api_spec" name="Danger::CircleAPI has a nil token as default" file="./spec/lib/danger/ci_sources/circle_api_spec.rb" time="0.000734"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_api_spec" name="Danger::CircleAPI sets the token on initialize" file="./spec/lib/danger/ci_sources/circle_api_spec.rb" time="0.000578"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_api_spec" name="Danger::CircleAPI creates a client with the correct base url" file="./spec/lib/danger/ci_sources/circle_api_spec.rb" time="0.001214"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_api_spec" name="Danger::CircleAPI fetches the build info without token" file="./spec/lib/danger/ci_sources/circle_api_spec.rb" time="0.006071"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_api_spec" name="Danger::CircleAPI fetches the build info with token" file="./spec/lib/danger/ci_sources/circle_api_spec.rb" time="0.001416"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI validates when circle all env vars are set" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.000105"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI validates when circle env var is found and it has a bad PR url" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.000091"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI doesnt get a PR id when it has a bad PR url" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.009006"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI does validate when circle env var is found and it has no PR url" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.000128"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI doesnt validate when circle ci is not found" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.000095"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI gets out a repo slug and pull request number" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.009844"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI gets out a repo slug, pull request number and commit refs when PR url is not found" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.012487"/>
+  <testcase classname="spec.lib.danger.ci_sources.circle_spec" name="Danger::CircleCI uses Circle CI API token if available" file="./spec/lib/danger/ci_sources/circle_spec.rb" time="0.010687"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone validates when DRONE variable is set" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.000145"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone does not validate when DRONE is not set" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.000126"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone does not validate PR when DRONE_PULL_REQUEST is set to non int value" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.000402"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone does not validate  PRwhen DRONE_PULL_REQUEST is set to non positive int value" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.000116"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone gets the pull request ID" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.008783"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone gets the repo address" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.008404"/>
+  <testcase classname="spec.lib.danger.ci_sources.drone_spec" name="Danger::Drone gets out a repo slug and pull request number" file="./spec/lib/danger/ci_sources/drone_spec.rb" time="0.011970"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo Return Types #modified_files returns a FileList object" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.079570"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo Return Types #added_files returns a FileList object" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.080882"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo Return Types #deleted_files returns a FileList object" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.081833"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo with files handles adding a new file to a git repo" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.093674"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo with files handles file deletions as expected" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.095147"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo with files handles modified as expected" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.082327"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo lines of code handles code insertions as expected" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.085685"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo lines of code handles code deletions as expected" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.091486"/>
+  <testcase classname="spec.lib.danger.ci_sources.git_spec" name="Danger::GitRepo lines of code #commits returns the commits" file="./spec/lib/danger/ci_sources/git_spec.rb" time="0.082046"/>
+  <testcase classname="spec.lib.danger.ci_sources.jenkins_spec" name="Danger::Jenkins validates when jenkins env var is found" file="./spec/lib/danger/ci_sources/jenkins_spec.rb" time="0.000128"/>
+  <testcase classname="spec.lib.danger.ci_sources.jenkins_spec" name="Danger::Jenkins doesnt validate when jenkins is not found" file="./spec/lib/danger/ci_sources/jenkins_spec.rb" time="0.000082"/>
+  <testcase classname="spec.lib.danger.ci_sources.jenkins_spec" name="Danger::Jenkins gets out a repo slug from a git+ssh repo and pull request number" file="./spec/lib/danger/ci_sources/jenkins_spec.rb" time="0.000155"/>
+  <testcase classname="spec.lib.danger.ci_sources.jenkins_spec" name="Danger::Jenkins gets out a repo slug from a https repo and pull request number" file="./spec/lib/danger/ci_sources/jenkins_spec.rb" time="0.000093"/>
+  <testcase classname="spec.lib.danger.ci_sources.jenkins_spec" name="Danger::Jenkins Is classed as a PR when ghprbPullId exists" file="./spec/lib/danger/ci_sources/jenkins_spec.rb" time="0.000138"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo validates when run by danger local" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.000082"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo doesnt validate when the local git flag is missing" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.000117"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo gets the pull request ID" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.099535"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos gets the repo address when it uses https" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.000019">
+    <skipped/>
+  </testcase>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos gets the repo address when it uses git@" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.110539"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos gets the repo address when it contains .git" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.103677"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos gets the repo address when it starts with git://" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.110886"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos gets the repo address when it starts with git://git@" file="./spec/lib/danger/ci_sources/local_git_repo_spec.rb" time="0.098927"/>
+  <testcase classname="spec.lib.danger.ci_sources.local_git_repo_spec" name="Danger::LocalGitRepo github repos does not set a repo_slug if the repo has a non-gh remote" file="./spec/spec_helper.rb" time="0.095487">
+    <failure message="undefined method `split' for nil:NilClass" type="NoMethodError">
+      <![CDATA[undefined method `split' for nil:NilClass
+./lib/danger/ci_source/local_git_repo.rb:31:in `initialize'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:91:in `new'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:91:in `block (4 levels) in <top (required)>'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:17:in `block (2 levels) in run_in_repo'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:6:in `chdir'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:6:in `block in run_in_repo'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:5:in `run_in_repo'
+./spec/lib/danger/ci_sources/local_git_repo_spec.rb:88:in `block (3 levels) in <top (required)>']]>
+    </failure>
+  </testcase>
+</testsuite>

data/spec/fixtures/fastlane_trainer.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites tests="2" failures="1">
+    <testsuite name="ThemojiUITests" tests="2" failures="1">
+        <testcase classname="ThemojiUITests" name="testExample()">
+        </testcase>
+        <testcase classname="ThemojiUITests" name="testIsBroken()">
+            <failure message="XCTAssertTrue failed - /Users/krausefx/Developer/hacking/themoji_copy/ThemojiUITests/ThemojiUITests.swift:24">
+            </failure>
+        </testcase>
+    </testsuite>
+</testsuites>

data/spec/junit_spec.rb

@@ -31,6 +31,15 @@ module Danger
         expect(@junit.skipped.count).to eq 0
       end
 
+      it 'gets the right results for trainer generated files' do
+        @junit.parse 'spec/fixtures/fastlane_trainer.xml'
+
+        expect(@junit.failures.count).to eq 1
+        expect(@junit.passes.count).to eq 1
+        expect(@junit.errors.count).to eq 0
+        expect(@junit.skipped.count).to eq 0
+      end
+
       it 'gets the right results for the danger rspec failure' do
         @junit.parse 'spec/fixtures/rspec_fail.xml'
 
@@ -49,7 +58,7 @@ module Danger
         expect(output).to include(row)
       end
 
-       it 'shows a known markdown row' do
+      it 'shows a known markdown row' do
         @junit.parse 'spec/fixtures/rspec_fail.xml'
         @junit.headers = [:time]
         @junit.report
@@ -69,10 +78,8 @@ module Danger
       end
 
       it 'links paths that are files' do
-        allow(@dangerfile.github).to receive(:pr_json).and_return({
-          head: { repo: { html_url: 'https://github.com/thing/thingy' } }
-        })
-        allow(@dangerfile.github).to receive(:head_commit).and_return("hello")
+        allow(@dangerfile.github).to receive(:pr_json).and_return(head: { repo: { html_url: 'https://github.com/thing/thingy' } })
+        allow(@dangerfile.github).to receive(:head_commit).and_return('hello')
 
         @junit.parse 'spec/fixtures/danger-junit-fail.xml'
         @junit.report

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-junit
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.7.0
 platform: ruby
 authors:
 - Orta Therox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-02 00:00:00.000000000 Z
+date: 2016-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -199,7 +199,9 @@ files:
 - lib/danger_plugin.rb
 - lib/junit/gem_version.rb
 - lib/junit/plugin.rb
+- spec/fixtures/danger-junit-fail.xml
 - spec/fixtures/eigen_fail.xml
+- spec/fixtures/fastlane_trainer.xml
 - spec/fixtures/rspec_fail.xml
 - spec/fixtures/selenium.xml
 - spec/junit_spec.rb
@@ -229,7 +231,9 @@ signing_key:
 specification_version: 4
 summary: Get automatic inline test reporting for JUnit-conforming XML files
 test_files:
+- spec/fixtures/danger-junit-fail.xml
 - spec/fixtures/eigen_fail.xml
+- spec/fixtures/fastlane_trainer.xml
 - spec/fixtures/rspec_fail.xml
 - spec/fixtures/selenium.xml
 - spec/junit_spec.rb