danger-jira_sync 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3676486d775890e8168b4c19fcb0723753c638abc1bbf234c305a389fcc74ac3
-  data.tar.gz: 29a78685c72621bc10e6100a9606e9c674e8d7e6e3858a23f77078e4f049f18c
+  metadata.gz: b11f9ef73bd5db3c5d26b38c5fa285ad6d958bc28d8ea0c1143f3c5d4d1b650e
+  data.tar.gz: aabfa9cd7a266af8cdf860d0ec44c55db61a1300e09909600ca3556b4bf01d45
 SHA512:
-  metadata.gz: 5779baee09ceb623ccd21a4adf03b4621f4e119c84321095bd2ee59c8fdcbdbf9651e41f51a24350acccfb8adbb134c82dd0dc13974b640bb0d69cc0955e0ed2
-  data.tar.gz: 77208ea90084bcb5da9e548001db1f4a777cf55eb4d2ec6f8e45125427bd8c1c267744443447d7199870381e6bb9b6af380c482b1df918588f436bc505bdc1b5
+  metadata.gz: e00eb94c4cdee985fcd70cdc0d12680e268ebbad0e8e9849e7fe2a1c47c055d393df8de41664892abc2622817ce4c00816c69d43e12fdc5e803fec939fa5e6a9
+  data.tar.gz: 397899d6534b6020747fa15715a22b9b82aaa4538058bb532498d3250f9e555626cae94367f1f033fbfa8dfe36f6a21ee560be47173e475bb2c5050f4c8df7dd

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-jira_sync (0.0.5)
+    danger-jira_sync (0.0.6)
       danger-plugin-api (~> 1.0)
       jira-ruby (~> 1.5.0)
 

data/README.md

@@ -62,6 +62,6 @@ Labels the Pull Request with Jira Project Keys and Component Names
 
 # **:warning: Do not commit fixtures with your credentials in them :warning:**
 
-Before committing, check to see if you have created or changed any fixtures in `/spec/fixtures/vcr_cassettes`. If you have, it is likely that the changed file contains your credentials. Manually remove your credentials from these fixture files
+Before committing, check to see if you have created or changed any fixtures in `/spec/fixtures/vcr_cassettes`. If you have, it is possible that the changed file contains your credentials. Manually remove your credentials from these fixture files
 
 When a new HTTP request is made that [VCR](https://github.com/vcr/vcr) hasn't seen before, it will record the response from the server and play it back in subsequent HTTP requests to the same URL with the same headers. This means that if a new request is made in the tests, it will actually make a request to the server in order to record the response. For this reason, development should be done within testing environments in GitHub and Jira Cloud

data/lib/jira_sync/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JiraSync
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/jira_sync/plugin.rb

@@ -138,7 +138,9 @@ module Danger
     end
 
     def add_labels_to_issue(labels)
-      github.api.add_labels_to_an_issue(repo, issue_number, labels)
+      existing_labels = github.api.labels_for_issue(repo, issue_number).map { |label| label[:name] }
+      new_labels = labels - existing_labels
+      github.api.add_labels_to_an_issue(repo, issue_number, new_labels) unless new_labels.empty?
     rescue Octokit::Error => e
       warn "#{e.response_status} Error while adding labels [#{labels}] to GitHub issue: #{e.message}"
     end

data/spec/jira_sync_spec.rb

@@ -146,6 +146,7 @@ RSpec.describe Danger::DangerJiraSync do
         def stub_github_api_labelling(labels: [])
           allow(github_api_mock).to receive(:labels).and_return(github_labels_response(labels))
           allow(github_api_mock).to receive(:add_label).and_return(nil)
+          allow(github_api_mock).to receive(:labels_for_issue).and_return([])
           allow(github_api_mock).to receive(:add_labels_to_an_issue).and_return(nil)
 
           allow(plugin.github).to receive(:api).and_return(github_api_mock)
@@ -312,6 +313,27 @@ RSpec.describe Danger::DangerJiraSync do
           expect(dangerfile.status_report[:warnings].count).to eq(1)
         end
 
+        it "creates a warning when it cannot fetch labels for the related pr" do
+          stub_github_api_labelling
+
+          error = Octokit::Error.from_response({
+            method: "GET",
+            url: "https://www.example.com/",
+            status: 503,
+            documentation_url: "https://developer.github.com/v3/issues/labels/#create-a-label",
+            message: "Forbidden"
+          })
+
+          expect(github_api_mock).to receive(:labels_for_issue).and_raise(error)
+          expect(dangerfile.status_report[:warnings].count).to eq(0), "preconditions"
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+
+          expect(dangerfile.status_report[:warnings].count).to eq(1)
+        end
+
         it "creates a warning when it cannot fetch existing github labels" do
           stub_github_api_labelling
 
@@ -359,6 +381,17 @@ RSpec.describe Danger::DangerJiraSync do
           end
         end
 
+        it "does not add existing labels to the github pr" do
+          expect(github_api_mock).to receive(:labels_for_issue).once.and_return github_labels_response(%w(DEV))
+          expect(github_api_mock).to receive(:add_labels_to_an_issue).with(anything, anything, %w(ComponentA ComponentC ABC ComponentB)).once
+
+          stub_github_api_labelling
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+        end
+
         it "adds missing github labels" do
           labels = pr_title_project_keys + pr_title_related_component_names
           labels.each do |label|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jira_sync
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Ben Menesini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-28 00:00:00.000000000 Z
+date: 2018-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api