danger-jira_sync 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fce89991967105fa855239f168ddcd39023c05f3a864602c0f73d625fdcf182
-  data.tar.gz: add9884c0ce2306212d0ac502cf20b1ab9f3d1c70d25b1ec14fa884aba97b881
+  metadata.gz: 3676486d775890e8168b4c19fcb0723753c638abc1bbf234c305a389fcc74ac3
+  data.tar.gz: 29a78685c72621bc10e6100a9606e9c674e8d7e6e3858a23f77078e4f049f18c
 SHA512:
-  metadata.gz: f9e4d1cf4d8409f002d014e10ab3dabf0c0932c31171b24d3f0b92cb0e6772980ede2f405358cb1cb9ab4c089f9f73e793e76134b91efd4906979c6d91bf2f8a
-  data.tar.gz: e5403bd45a24ff908279a7e4c0f4d3397531318bd87fcca8b5ae2288d33d8fcea9a3eaadf38636789475d3fedb6023f7c1efb9ec5bf4556eb3c585820515aef2
+  metadata.gz: 5779baee09ceb623ccd21a4adf03b4621f4e119c84321095bd2ee59c8fdcbdbf9651e41f51a24350acccfb8adbb134c82dd0dc13974b640bb0d69cc0955e0ed2
+  data.tar.gz: 77208ea90084bcb5da9e548001db1f4a777cf55eb4d2ec6f8e45125427bd8c1c267744443447d7199870381e6bb9b6af380c482b1df918588f436bc505bdc1b5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-jira_sync (0.0.4)
+    danger-jira_sync (0.0.5)
       danger-plugin-api (~> 1.0)
       jira-ruby (~> 1.5.0)
 

data/lib/jira_sync/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JiraSync
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/jira_sync/plugin.rb

@@ -92,7 +92,7 @@ module Danger
     end
 
     def github_labels
-      @github_labels ||= github.api.labels(repo)
+      @github_labels ||= github.api.labels(repo).map { |github_label| github_label[:name] }
     rescue Octokit::Error => e
       warn "#{e.response_status} Error while retrieving GitHub labels: #{e.message}"
     end

data/spec/jira_sync_spec.rb

@@ -130,8 +130,21 @@ RSpec.describe Danger::DangerJiraSync do
           plugin.configure(jira_settings)
         end
 
+        def github_labels_response(labels)
+          labels.map do |label|
+            {
+              id: SecureRandom.random_number(100_000),
+              node_id: SecureRandom.base64,
+              url: "https://api.github.com/repos/<someorg>/<somerepo>/labels/#{label}",
+              name: label,
+              color: SecureRandom.hex(3),
+              default: false
+            }
+          end
+        end
+
         def stub_github_api_labelling(labels: [])
-          allow(github_api_mock).to receive(:labels).and_return(labels)
+          allow(github_api_mock).to receive(:labels).and_return(github_labels_response(labels))
           allow(github_api_mock).to receive(:add_label).and_return(nil)
           allow(github_api_mock).to receive(:add_labels_to_an_issue).and_return(nil)
 
@@ -278,7 +291,7 @@ RSpec.describe Danger::DangerJiraSync do
           expect(dangerfile.status_report[:warnings].count).to eq(expected_missing_label_count)
         end
 
-        it "creates a warning when it cannot fetch existing github labels" do
+        it "creates a warning when it cannot add a label to an existing github issue" do
           stub_github_api_labelling
 
           error = Octokit::Error.from_response({
@@ -299,7 +312,7 @@ RSpec.describe Danger::DangerJiraSync do
           expect(dangerfile.status_report[:warnings].count).to eq(1)
         end
 
-        it "creates a warning when it cannot add a label to an existing github issue" do
+        it "creates a warning when it cannot fetch existing github labels" do
           stub_github_api_labelling
 
           error = Octokit::Error.from_response({
@@ -314,7 +327,7 @@ RSpec.describe Danger::DangerJiraSync do
             HEREDOC
           })
 
-          expect(github_api_mock).to receive(:add_label).and_raise(error)
+          expect(github_api_mock).to receive(:labels).and_raise(error)
           expect(dangerfile.status_report[:warnings].count).to eq(0), "preconditions"
 
           VCR.use_cassette(:default_success, record: :new_episodes) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-jira_sync
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Ben Menesini