danger-jira 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: daacac410e05a9b467387aebfd37ab246879df80
-  data.tar.gz: 2f8b2e3e28fe2b7fac647328296292e044faa768
+  metadata.gz: b15d8ebf7429b4cf1c9fca0d0f15e8abfde51d7b
+  data.tar.gz: 07c9a190ac242399f89b967d2078a8f3a909a621
 SHA512:
-  metadata.gz: d2f031933e816a15720b421665f7f0c0f626e9da2270d6de76ad0780150142c3c323f11816bb8a602ef061930c6a53b25d45a1a70360012fc19885c5f177e9f6
-  data.tar.gz: 9d1f8d7c9910ff55c8bbd30d7bd5906e79e0c29ad6c2733dbd901acb2bb59f041adef5c2a4b05cd7b9d6046d82aa7092a75968f314edfa528321632a0aa76b12
+  metadata.gz: 94222d9d7703e076b6dbcca12e4b05c38799c3323c829cf6010b118fc6edc41a5ea11e08e0a058a3272ae02bc233a354c6494a75c059f59c838f99e77b06b6de
+  data.tar.gz: f872c9f3a63c965998778150d2ddbbcb64f9e95a52575c5eb4caf0ae035a216eca2513f6706ce8437a0ed1ab09bea71c01e96928847ede7b5692557b055ed568

data/lib/jira/gem_version.rb

@@ -1,3 +1,3 @@
 module Jira
-  VERSION = "0.5.0".freeze
+  VERSION = "0.5.1".freeze
 end

data/lib/jira/plugin.rb

@@ -41,7 +41,7 @@ module Danger
       throw Error("'key' missing - must supply JIRA issue key") if key.nil?
       throw Error("'url' missing - must supply JIRA installation URL") if url.nil?
 
-      return if skippable && should_skip_jira?
+      return if skippable && should_skip_jira?(search_title: search_title)
 
       jira_issues = find_jira_issues(
         key: key,
@@ -94,7 +94,7 @@ module Danger
       return jira_issues.uniq
     end
 
-    def should_skip_jira?(search_title: true, search_commits: false)
+    def should_skip_jira?(search_title: true)
       # Consider first occurrence of 'no-jira'
       regexp = Regexp.new("no-jira", true)
 
@@ -104,14 +104,6 @@ module Danger
         end
       end
 
-      if search_commits
-        git.commits.map do |commit|
-          commit.message.gsub(regexp) do |match|
-            return true unless match.empty?
-          end
-        end
-      end
-
       github.pr_body.gsub(regexp) do |match|
         return true unless match.empty?
       end

data/spec/jira_spec.rb

@@ -49,24 +49,7 @@ module Danger
 
       it "can find no-jira in pr body" do
         allow(@jira).to receive_message_chain("github.pr_body").and_return("[no-jira] Ticket doesn't need a jira but [WEB-123] WEB-123")
-        result = @jira.should_skip_jira?(
-          search_title: false,
-          search_commits: false
-        )
-        expect(result).to be(true)
-      end
-
-      it "can find no-jira in commits" do
-        single_commit = Object.new
-        def single_commit.message
-          "Small text change [no-jira]"
-        end
-        commits = [single_commit]
-        allow(@jira).to receive_message_chain("git.commits").and_return(commits)
-        result = @jira.should_skip_jira?(
-          search_title: false,
-          search_commits: true
-        )
+        result = @jira.should_skip_jira?(search_title: false)
         expect(result).to be(true)
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jira
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - RestlessThinker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-22 00:00:00.000000000 Z
+date: 2018-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api