danger-jacoco 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98c57cc2ececdda3470143782f1c87943a3f0a08f2931c0aa634444da0d90c69
-  data.tar.gz: 4de9109e706b7fa0f33a3906261535fe6c40e4d6b1580951af6cc1a1d6597e01
+  metadata.gz: d4d5975aa9e605034d57f94ae6c1e83b5b9ba5f9b21be614a3266c5b8d70a36d
+  data.tar.gz: 98ee2072a867384ae8d732cfef8dcda6b201a8da7706e2361481fa5add96bda4
 SHA512:
-  metadata.gz: 021aa093d7763cef129b9b3ee73ddb23ca1e29d6565d6b8c74e24ee4071ea55ea8de5452dd16fea5b2aef97fefdb67ce9fd82a20d22b248af58bd37c51df11fa
-  data.tar.gz: 527c5b390bae29e370215cec242586c41adeb16ccd25932a7ab41a03ffd81afaaaf756acf36dd0168f0f86423237ecdfe6a715941a3943a0c514ddab63b5841c
+  metadata.gz: 07e545a038ee4ea8c7aa81c77ef96a1b62756513f90cb9994d762b9f5605689e02eb2a4c2d56c7dfb15b1177e9b9e700f51f4dc44162a7663350031b28f84511
+  data.tar.gz: 6138c222b2bcd09bf9c4e1744e256065bf9c1ac5e3d33c1b080252ccd0e7e50dfc2ab4dc92264bb8e32ab4428ab8887f5a7acbad715e9e8cca9cda210ac3b487

data/.github/dependabot.yml

@@ -0,0 +1,20 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: weekly
+    time: "19:00"
+  open-pull-requests-limit: 10
+  ignore:
+  - dependency-name: listen
+    versions:
+    - 3.4.1
+    - 3.5.0
+  - dependency-name: rubocop
+    versions:
+    - 1.10.0
+    - 1.11.0
+    - 1.12.0
+    - 1.8.1
+    - 1.9.1

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in danger-jacoco.gemspec

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A guardfile for making Danger Plugins
 # For more info see https://github.com/guard/guard#readme
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

data/danger-jacoco.gemspec

@@ -1,22 +1,24 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'jacoco/gem_version.rb'
+require 'jacoco/gem_version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'danger-jacoco'
   spec.version       = Jacoco::VERSION
   spec.authors       = ['Anton Malinskiy']
   spec.email         = ['anton@malinskiy.com']
-  spec.description   = %q{A short description of danger-jacoco.}
-  spec.summary       = %q{A longer description of danger-jacoco.}
+  spec.description   = 'A short description of danger-jacoco.'
+  spec.summary       = 'A longer description of danger-jacoco.'
   spec.homepage      = 'https://github.com/Malinskiy/danger-jacoco'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '>= 2.6'
 
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
   spec.add_runtime_dependency 'nokogiri-happymapper', '~> 0.6'
@@ -29,15 +31,15 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.7'
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.51"
-  spec.add_development_dependency "yard", "~> 0.9"
+  spec.add_development_dependency 'rubocop', '~> 1.14'
+  spec.add_development_dependency 'yard', '~> 0.9'
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
 
   # If you want to work on older builds of ruby
-  spec.add_development_dependency 'listen', '3.2.1'
+  spec.add_development_dependency 'listen', '3.5.1'
 
   # This gives you the chance to run a REPL inside your tests
   # via:

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

data/lib/jacoco/plugin.rb

@@ -20,12 +20,8 @@ module Danger
   # @tags jacoco, coverage, java, android, kotlin
   #
   class DangerJacoco < Plugin # rubocop:disable Metrics/ClassLength
-    attr_accessor :minimum_project_coverage_percentage
-    attr_accessor :minimum_class_coverage_percentage
-    attr_accessor :files_extension
-    attr_accessor :minimum_package_coverage_map
-    attr_accessor :minimum_class_coverage_map
-    attr_accessor :fail_no_coverage_data_found
+    attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage, :files_extension,
+                  :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found, :title
 
     # Initialize the plugin with configured parameters or defaults
     def setup
@@ -34,6 +30,7 @@ module Danger
       @minimum_package_coverage_map = {} unless minimum_package_coverage_map
       @minimum_class_coverage_map = {} unless minimum_class_coverage_map
       @files_extension = ['.kt', '.java'] unless files_extension
+      @title = 'JaCoCo' unless title
     end
 
     # Parses the xml output of jacoco to Ruby model classes
@@ -62,7 +59,7 @@ module Danger
     # Java => blah/blah/java/slashed_package/Source.java
     # Kotlin => blah/blah/kotlin/slashed_package/Source.kt
     #
-    def report(path, report_url = '', delimiter = %r{\/java\/|\/kotlin\/}, fail_no_coverage_data_found: true)
+    def report(path, report_url = '', delimiter = %r{/java/|/kotlin/}, fail_no_coverage_data_found: true)
       @fail_no_coverage_data_found = fail_no_coverage_data_found
 
       setup
@@ -73,7 +70,7 @@ module Danger
 
       total_covered = total_coverage(path)
 
-      report_markdown = "### JaCoCO Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
+      report_markdown = "### #{title} Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
       report_markdown += "| Class | Covered | Meta | Status |\n"
       report_markdown += "|:---|:---:|:---:|:---:|\n"
       class_coverage_above_minimum = markdown_class(parser, report_markdown, report_url)
@@ -166,7 +163,7 @@ module Danger
       if counter.nil?
         no_coverage_data_found_message = "No coverage data found for #{jacoco_class.name}"
 
-        raise no_coverage_data_found_message if @fail_no_coverage_data_found.class == TrueClass
+        raise no_coverage_data_found_message if @fail_no_coverage_data_found.instance_of?(TrueClass)
 
         warn no_coverage_data_found_message
       end
@@ -206,7 +203,7 @@ module Danger
       if report_url.empty?
         "`#{class_name}`"
       else
-        report_filepath = class_name.gsub(%r{/(?=[^/]*/.)}, '.') + '.html'
+        report_filepath = "#{class_name.gsub(%r{/(?=[^/]*/.)}, '.')}.html"
         "[`#{class_name}`](#{report_url + report_filepath})"
       end
     end

data/lib/jacoco/sax_parser.rb

@@ -5,10 +5,10 @@ require 'nokogiri'
 module Jacoco
   # Sax parser for quickly finding class elements in Jacoco report
   class SAXParser < Nokogiri::XML::SAX::Document
-    attr_accessor :class_names
-    attr_accessor :classes
+    attr_accessor :class_names, :classes
 
     def initialize(classes)
+      super()
       @class_names      = classes
       @classes          = []
       @current_class    = nil
@@ -40,14 +40,13 @@ module Jacoco
     def start_class(attrs)
       @subelement_index = 0
 
-      if @class_names.include?(Hash[attrs]['name'])
-        c              = Jacoco::Class.new
-        c.name         = Hash[attrs]['name']
-        c.counters     = []
-        @current_class = c
-        @classes.push c
-      elsif @current_class.nil?
-      end
+      return unless @class_names.include?(Hash[attrs]['name'])
+
+      c              = Jacoco::Class.new
+      c.name         = Hash[attrs]['name']
+      c.counters     = []
+      @current_class = c
+      @classes.push c
     end
 
     def characters(string); end

data/spec/jacoco_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-# rubocop:disable LineLength
-# rubocop:disable ModuleLength
-# rubocop:disable BlockLength
+# rubocop:disable Layout/LineLength
+# rubocop:disable Metrics/ModuleLength
+# rubocop:disable Metrics/BlockLength
 
 require File.expand_path('spec_helper', __dir__)
 
@@ -37,7 +37,7 @@ module Danger
 
         expect(@dangerfile.status_report[:errors]).to eq(['Total coverage of 32.9%. Improve this to at least 50%',
                                                           'Class coverage is below minimum. Improve to at least 0%'])
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCO Code Coverage 32.9% :warning:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 32.9% :warning:')
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Meta | Status |')
         expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
@@ -162,6 +162,6 @@ module Danger
   end
 end
 
-# rubocop:enable LineLength
-# rubocop:enable ModuleLength
-# rubocop:enable BlockLength
+# rubocop:enable Layout/LineLength
+# rubocop:enable Metrics/ModuleLength
+# rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -2,8 +2,8 @@
 
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('..', __dir__))
-$LOAD_PATH.unshift((ROOT + 'lib').to_s)
-$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+$LOAD_PATH.unshift("#{ROOT}lib".to_s)
+$LOAD_PATH.unshift("#{ROOT}spec".to_s)
 
 require 'bundler/setup'
 require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Anton Malinskiy
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-12 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '1.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '1.14'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.5.1
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -171,11 +171,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yaml"
 - ".github/workflows/release.yaml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -205,7 +205,7 @@ homepage: https://github.com/Malinskiy/danger-jacoco
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -213,15 +213,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: A longer description of danger-jacoco.
 test_files:

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-cache:
-  directories:
-    - bundle
-
-rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
-
-script:
-    - bundle exec rake spec