danger-jacoco-instacart 0.1.13 → 0.1.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04b74ccc5974fdd122bb8909a71b541891e760d99f7cfd120c06d71c133c2b32
-  data.tar.gz: 9f8e75aa5cf7611307255edb1ae2119e81f5c7010700d324d1b7041cd7d5d275
+  metadata.gz: 2796b44c6c3c0252797c88e6836096d3f528524f2a3719111607df5375e00afa
+  data.tar.gz: bd5f313356ca48dc58e35a35c425b4b158686f924264fcacd1a48d54cb9a2108
 SHA512:
-  metadata.gz: da2bc98c6c2693be43e96012f0ac3b2000911fca7610fba47387046f908797eb49a4b2f04d505af4ddd359cae44703725c1216bf9716bb0cf62c58b20636dca5
-  data.tar.gz: 9f768d669d1eb720bf898ab9fbdfd6deb8fd68994a67ae490938eee2fd4c693dcfb0a06314b466fef6c9109424f037738171e77113546579986a1ca6dfce4266
+  metadata.gz: b9a81a4673b390c90b0e58626cad1a0b922a1158f6425f7e0999b03ca7c41c1d94b7b6bbe4ffc13eb0a4fb79dc2dff801f61d78b7945845b091bb79a3a71d8df
+  data.tar.gz: 283344a767f8500e3fda05291cb12c5a18c525ec8e0fd191ab8cae1f63d79c07c38f5140cb8334b5cb0449116977f653b7b00cc0d33fd0625f903c0f9253336a

data/.yardoc/checksums

@@ -1,6 +1,6 @@
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/danger_jacoco.rb 38229d934b3315bb2a5a4eec18eb65f3c54d304f
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 1c81f68cb95296bfd592c1b57e0f2e6341f56b55
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e99030c6a408c1bc77962b844d74c324daecad40
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 8f31621c2d22f454fcaacb2640694c9c6e7f1fb8
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e0262efb6d2458fa4ad4e2138c1f8a10fb11a1de
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/sax_parser.rb 370e2799f8dbdf7d642c820214e6ea84c30c9cb0
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/counter.rb 368f4a9811617b7a174ddf837a8fac49a4bc32a6
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/report.rb 7cf45ee71ff347a130320f6190ddb25525c7095d

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.13'
+  VERSION = '0.1.14'
 end

data/lib/jacoco/plugin.rb

@@ -21,7 +21,7 @@ module Danger
   #
   class DangerJacoco < Plugin # rubocop:disable Metrics/ClassLength
     attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage,
-                  :minimum_composable_class_coverage_percentage, :only_check_new_files, :files_extension,
+                  :minimum_composable_class_coverage_percentage, :files_to_check, :files_extension,
                   :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found,
                   :title, :class_column_title, :subtitle_success, :subtitle_failure, :file_to_create_on_failure
 
@@ -29,7 +29,7 @@ module Danger
     def setup
       setup_minimum_coverages
       setup_texts
-      @only_check_new_files = false unless only_check_new_files
+      @files_to_check = [] unless files_to_check
       @files_extension = ['.kt', '.java'] unless files_extension
       @file_to_create_on_failure = 'danger_jacoco_failure_status_file.txt' unless file_to_create_on_failure
     end
@@ -103,13 +103,9 @@ module Danger
     end
     # rubocop:enable Style/AbcSize
 
-    # Select either only added files or modified and added files in this PR,
-    # depending on "only_check_new_files" attribute
     def classes(delimiter)
-      git = @dangerfile.git
-      affected_files = only_check_new_files ? git.added_files : git.added_files + git.modified_files
       class_to_file_path_hash = {}
-      affected_files.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
+      files_to_check.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
                     .each do |file| # "src/java/com/example/CachedRepository.java"
                       classname = file.split('.').first.split(delimiter)[1] # "com/example/CachedRepository"
                       class_to_file_path_hash[classname] = file

data/spec/jacoco_spec.rb

@@ -20,17 +20,13 @@ module Danger
         @dangerfile = testing_dangerfile
         @my_plugin = @dangerfile.jacoco
 
-        modified_files = ['src/java/com/example/CachedRepository.java']
-        added_files = ['src/java/io/sample/UseCase.java']
-
-        allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
-        allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
         allow(File).to receive(:open).and_call_original
       end
 
       it :report do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
 
@@ -47,6 +43,7 @@ module Danger
       it 'creates supplied status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 100
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
@@ -58,6 +55,7 @@ module Danger
       it 'creates default status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 60
 
         expect(File).to receive(:open).with('danger_jacoco_failure_status_file.txt', 'w')
@@ -67,6 +65,7 @@ module Danger
       it 'does _not_ create status file upon success' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
 
@@ -77,6 +76,7 @@ module Danger
       it 'test regex class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { '.*Repository' => 60 }
 
@@ -88,6 +88,7 @@ module Danger
       it 'test with package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = { 'com/example/' => 70 }
 
@@ -99,6 +100,7 @@ module Danger
       it 'test with bigger overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 70,
@@ -113,6 +115,7 @@ module Danger
       it 'test with lower overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
@@ -127,6 +130,7 @@ module Danger
       it 'test with overlapped package coverage and bigger class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
@@ -142,6 +146,7 @@ module Danger
       it 'test with overlapped package coverage and lower class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 90,
@@ -154,24 +159,10 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 80% | :warning: |')
       end
 
-      it 'checks modified files when "only_check_new_files" attribute is false' do
-        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
-
-        @my_plugin.minimum_project_coverage_percentage = 50
-        @my_plugin.only_check_new_files = false
-
-        @my_plugin.report path_a
-
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 0% | :white_check_mark: |')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
-      end
-
       it 'defaults "only_check_new_files" attribute to false' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -180,25 +171,10 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
       end
 
-      it 'does _not_ check modified files when "only_check_new_files" attribute is true' do
-        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
-
-        @my_plugin.minimum_project_coverage_percentage = 50
-        @my_plugin.minimum_class_coverage_percentage = 70
-        @my_plugin.only_check_new_files = true
-
-        @my_plugin.report path_a
-
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
-        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 70% | :warning: |')
-        expect(@dangerfile.status_report[:markdowns][0].message).not_to include('com/example/CachedRepository')
-      end
-
       it 'adds a link to report' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -210,6 +186,7 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, it doesn\'t fail the execution' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -219,6 +196,7 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is not set, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -228,6 +206,7 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -237,6 +216,7 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally warn (not fail), the execution doesn\'t fail on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -246,6 +226,7 @@ module Danger
       it 'prints default success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
 
@@ -262,6 +243,7 @@ module Danger
       it 'prints default failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
 
@@ -278,6 +260,7 @@ module Danger
       it 'prints custom success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.subtitle_success = 'You rock! 🔥'
@@ -295,6 +278,7 @@ module Danger
       it 'prints custom failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.subtitle_failure = 'Too bad :('
@@ -312,6 +296,8 @@ module Danger
       it 'prints default class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
+
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
@@ -320,6 +306,7 @@ module Danger
       it 'prints custom class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.class_column_title = 'New files'
 
         @my_plugin.report path_a
@@ -330,6 +317,7 @@ module Danger
       it 'instruction coverage takes over all the rest coverages for classes' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_d.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -340,6 +328,7 @@ module Danger
       it 'branch coverage takes over line coverage for classes, when instruction coverage is not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_e.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -350,6 +339,7 @@ module Danger
       it 'line coverage takes over for classes, when both instruction coverage and branch coverage are not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_f.xml"
 
+        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -366,6 +356,7 @@ module Danger
         it 'applies minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 
@@ -384,6 +375,7 @@ module Danger
         it 'does not apply minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
+          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco-instacart
 version: !ruby/object:Gem::Version
-  version: 0.1.13
+  version: 0.1.14
 platform: ruby
 authors:
 - Anton Malinskiy