danger-jacoco-instacart 0.1.13.SNAPSHOT.1 → 0.1.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f29acbe4cffe4ddeae3ab9f829a1dc5310da2f837aa8afd313d3cd16ddd63ad6
-  data.tar.gz: f74387bb9bb4307342e9baff55c011d52d2e06281bf86decfbd858f6962854f3
+  metadata.gz: 04b74ccc5974fdd122bb8909a71b541891e760d99f7cfd120c06d71c133c2b32
+  data.tar.gz: 9f8e75aa5cf7611307255edb1ae2119e81f5c7010700d324d1b7041cd7d5d275
 SHA512:
-  metadata.gz: 591ee3b4094f83a2f69e152b4d5f956a1402f3ee84c932287389aa017065743c3e88017c1979b043044e6961991be05da0ca6ad74ad26f13c726ef14ea24eae3
-  data.tar.gz: 130a3e11af52b5598603edeed78e57a6039528e7bf38f7cebdd9b8427cbf7d83f3654c572a17a89e1b5329d343a59e7f1cb22a9e7df18c04e097bd4f9cf368b3
+  metadata.gz: da2bc98c6c2693be43e96012f0ac3b2000911fca7610fba47387046f908797eb49a4b2f04d505af4ddd359cae44703725c1216bf9716bb0cf62c58b20636dca5
+  data.tar.gz: 9f768d669d1eb720bf898ab9fbdfd6deb8fd68994a67ae490938eee2fd4c693dcfb0a06314b466fef6c9109424f037738171e77113546579986a1ca6dfce4266

data/.yardoc/checksums

@@ -1,6 +1,6 @@
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/danger_jacoco.rb 38229d934b3315bb2a5a4eec18eb65f3c54d304f
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 8f31621c2d22f454fcaacb2640694c9c6e7f1fb8
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e0262efb6d2458fa4ad4e2138c1f8a10fb11a1de
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 1c81f68cb95296bfd592c1b57e0f2e6341f56b55
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e99030c6a408c1bc77962b844d74c324daecad40
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/sax_parser.rb 370e2799f8dbdf7d642c820214e6ea84c30c9cb0
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/counter.rb 368f4a9811617b7a174ddf837a8fac49a4bc32a6
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/report.rb 7cf45ee71ff347a130320f6190ddb25525c7095d

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.13.SNAPSHOT.1'
+  VERSION = '0.1.13'
 end

data/lib/jacoco/plugin.rb

@@ -21,7 +21,7 @@ module Danger
   #
   class DangerJacoco < Plugin # rubocop:disable Metrics/ClassLength
     attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage,
-                  :minimum_composable_class_coverage_percentage, :files_to_check, :files_extension,
+                  :minimum_composable_class_coverage_percentage, :only_check_new_files, :files_extension,
                   :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found,
                   :title, :class_column_title, :subtitle_success, :subtitle_failure, :file_to_create_on_failure
 
@@ -29,7 +29,7 @@ module Danger
     def setup
       setup_minimum_coverages
       setup_texts
-      @files_to_check = [] unless files_to_check
+      @only_check_new_files = false unless only_check_new_files
       @files_extension = ['.kt', '.java'] unless files_extension
       @file_to_create_on_failure = 'danger_jacoco_failure_status_file.txt' unless file_to_create_on_failure
     end
@@ -103,9 +103,13 @@ module Danger
     end
     # rubocop:enable Style/AbcSize
 
+    # Select either only added files or modified and added files in this PR,
+    # depending on "only_check_new_files" attribute
     def classes(delimiter)
+      git = @dangerfile.git
+      affected_files = only_check_new_files ? git.added_files : git.added_files + git.modified_files
       class_to_file_path_hash = {}
-      files_to_check.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
+      affected_files.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
                     .each do |file| # "src/java/com/example/CachedRepository.java"
                       classname = file.split('.').first.split(delimiter)[1] # "com/example/CachedRepository"
                       class_to_file_path_hash[classname] = file

data/spec/jacoco_spec.rb

@@ -20,13 +20,17 @@ module Danger
         @dangerfile = testing_dangerfile
         @my_plugin = @dangerfile.jacoco
 
+        modified_files = ['src/java/com/example/CachedRepository.java']
+        added_files = ['src/java/io/sample/UseCase.java']
+
+        allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
+        allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
         allow(File).to receive(:open).and_call_original
       end
 
       it :report do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
 
@@ -43,7 +47,6 @@ module Danger
       it 'creates supplied status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 100
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
@@ -55,7 +58,6 @@ module Danger
       it 'creates default status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 60
 
         expect(File).to receive(:open).with('danger_jacoco_failure_status_file.txt', 'w')
@@ -65,7 +67,6 @@ module Danger
       it 'does _not_ create status file upon success' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
 
@@ -76,7 +77,6 @@ module Danger
       it 'test regex class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { '.*Repository' => 60 }
 
@@ -88,7 +88,6 @@ module Danger
       it 'test with package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = { 'com/example/' => 70 }
 
@@ -100,7 +99,6 @@ module Danger
       it 'test with bigger overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 70,
@@ -115,7 +113,6 @@ module Danger
       it 'test with lower overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
@@ -130,7 +127,6 @@ module Danger
       it 'test with overlapped package coverage and bigger class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
@@ -146,7 +142,6 @@ module Danger
       it 'test with overlapped package coverage and lower class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 90,
@@ -159,10 +154,24 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 80% | :warning: |')
       end
 
+      it 'checks modified files when "only_check_new_files" attribute is false' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.only_check_new_files = false
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 0% | :white_check_mark: |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
+      end
+
       it 'defaults "only_check_new_files" attribute to false' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -171,10 +180,25 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
       end
 
+      it 'does _not_ check modified files when "only_check_new_files" attribute is true' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_class_coverage_percentage = 70
+        @my_plugin.only_check_new_files = true
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 70% | :warning: |')
+        expect(@dangerfile.status_report[:markdowns][0].message).not_to include('com/example/CachedRepository')
+      end
+
       it 'adds a link to report' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -186,7 +210,6 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, it doesn\'t fail the execution' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -196,7 +219,6 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is not set, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -206,7 +228,6 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -216,7 +237,6 @@ module Danger
       it 'When option "fail_no_coverage_data_found" is set to optionally warn (not fail), the execution doesn\'t fail on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
@@ -226,7 +246,6 @@ module Danger
       it 'prints default success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
 
@@ -243,7 +262,6 @@ module Danger
       it 'prints default failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
 
@@ -260,7 +278,6 @@ module Danger
       it 'prints custom success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.subtitle_success = 'You rock! 🔥'
@@ -278,7 +295,6 @@ module Danger
       it 'prints custom failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.subtitle_failure = 'Too bad :('
@@ -296,8 +312,6 @@ module Danger
       it 'prints default class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
-
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
@@ -306,7 +320,6 @@ module Danger
       it 'prints custom class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.class_column_title = 'New files'
 
         @my_plugin.report path_a
@@ -317,7 +330,6 @@ module Danger
       it 'instruction coverage takes over all the rest coverages for classes' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_d.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -328,7 +340,6 @@ module Danger
       it 'branch coverage takes over line coverage for classes, when instruction coverage is not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_e.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -339,7 +350,6 @@ module Danger
       it 'line coverage takes over for classes, when both instruction coverage and branch coverage are not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_f.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
@@ -356,7 +366,6 @@ module Danger
         it 'applies minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 
@@ -375,7 +384,6 @@ module Danger
         it 'does not apply minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco-instacart
 version: !ruby/object:Gem::Version
-  version: 0.1.13.SNAPSHOT.1
+  version: 0.1.13
 platform: ruby
 authors:
 - Anton Malinskiy
@@ -228,9 +228,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.1.2
 signing_key: