danger-ikr-xcode_summary 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41a577e0180e6da6dfda10ba73ad60a971d8b057962652a30a80459781addb9d
-  data.tar.gz: b9733b8146591866849264d3dae64bd2329d5b079e4a0e68501e375a6d38fc3f
+  metadata.gz: 3cc3ecc5ea097f3d69852d4021d86e26c31c52f4a1f72437969addf8471c8e3f
+  data.tar.gz: a35b8f014bc3f719b0622e163e0ab79135483da613c506a1adabe1d9f0ff19fe
 SHA512:
-  metadata.gz: b11d9e601b7437f02bc8718a06ea158437c99d7de1db838394f431527f77609cf6f1430d668a68f78d4c7630c2c22a98f23bb7d40a07eb76ebf994c1a270ac37
-  data.tar.gz: cc1131f3bad8a88ff3257757fbaf750b3169c2b224001de2021e31f92ef9e37caeb96058e77f99e10174395568fd52362e56d8bfa24a8e226ab7670f86873130
+  metadata.gz: b8d47628e652b0ad1d2513cccd57f02e573c17b8213226f1a88937f6c12c5ab04dfa0ba4a97616f088c562d1b8ea2a2ecc975d6d25694013ff800e7c98965664
+  data.tar.gz: 11d4717315c848aca0042f9c09762c45cc8b31cd2c0b0e33015524add362f301a35cd415f3b5021480c8045e53deee2727da766ffb88141e34f16722fef32600

data/lib/xcode_summary/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module XcodeSummary
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

data/lib/xcode_summary/plugin.rb

@@ -21,6 +21,7 @@ module Danger
   class DangerXcodeSummary < Plugin
     Location = Struct.new(:file_name, :file_path, :line)
     Result = Struct.new(:message, :location)
+    Warning = Struct.new(:message, :sticky, :location)
 
     # The project root, which will be used to make the paths relative.
     # Defaults to `pwd`.
@@ -134,12 +135,18 @@ module Danger
     private
 
     def format_summary(xcode_summary)
+      # Warning = Struct.new(:message, :sticky, :location)
+      all_warnings = []
       xcode_summary.actions_invocation_record.actions.each do |action|
         warnings(action).each do |result|
           if inline_mode && result.location
-            warn(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            # warn(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            warning_object = Warning.new(result.message, false, result.location)
+            all_warnings << warning
           else
-            warn(result.message, sticky: false)
+            # warn(result.message, sticky: false)
+            warning_object = Warning.new(result.message, false, nil)
+            all_warnings << warning
           end
         end
         errors(action).each do |result|
@@ -158,6 +165,21 @@ module Danger
           end
         end
       end
+      all_warnings = all_warnings.sort_by do |warning|
+        if warning.message.include?("is deprecated:")
+          1
+        else
+          0
+        end
+      end
+
+      all_warnings.each do |warning|
+        if inline_mode && warning.location
+          warn(warning.message, sticky: warning.sticky, file: warning.location.file_path, line: warning.location.line)
+        else
+          warn(result.message, sticky: warning.sticky)
+        end
+      end
     end
 
     def warnings(action)
@@ -171,14 +193,6 @@ module Danger
         Result.new(format_warning(result), result.location)
       end
       warnings = warnings.uniq.reject { |result| result.message.nil? }
-      warnings = warnings.uniq.reject { |result| result.message.nil? }
-      warnings = warnings.sort_by do |result|
-        if result.message.include?("is deprecated:")
-          1
-        else
-          0
-        end
-      end
       warnings.delete_if(&ignored_results)
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-ikr-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Diogo Tridapalli