danger-iblinter 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4984b0985c91914d7f54a5a0cbf6197d452d90b93e6b204754bbfbf7541a8b93
-  data.tar.gz: a73307e031c892e0bcc14aa508c40364fc307d0e5b98013172b8e2feebac88b7
+  metadata.gz: f1174cb7b79c9e8cf4f310c170b6cb6df7dc6c0ab7119ad0e10c0e0bf7035469
+  data.tar.gz: 6b9e62fc4fd59797506fc21e87f25d0a8be28f575486808971a15d4bd634e734
 SHA512:
-  metadata.gz: 23eafacd0e00d2568461a2cf3412b1dab98ee1ab068c918c1e26dea52e63e0be7fd97054696a0490a17ab9c72631cb5a46e4d338a90d819fd247d09c82279b28
-  data.tar.gz: c27aa477d34ab111fa3ba46859d8d08f31eb857f629c36105bc70f237b517603f33069a7dae48359b2265a83a4eb7f95ac0ee997e691ae9ce5063875f6179b29
+  metadata.gz: d54f31751a5846db9123bea9db564e2c918c133a0efdf3d661119f8f3cdc577539c0c4d3ca45cd6e3f9ed47251bdfde92b49bd8655f4e627286d9cb1eb22e3cc
+  data.tar.gz: 4ae081e70db6111c35523a8069c98ec9c33dc49e4a751433eef6f683ed557d10b2da97a9194d9673a874f68fb85deba57ca7fe6c13ba2762fbe13bf536f7a0f4

data/Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in danger-iblinter.gemspec
 gemspec

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    danger-iblinter (0.0.4)
+    danger-iblinter (0.0.5)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
+    addressable (2.6.0)
       public_suffix (>= 2.0.2, < 4.0)
     ast (2.4.0)
     claide (1.0.2)
@@ -19,15 +19,16 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.11.1)
+    danger (6.0.9)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
+      faraday-http-cache (~> 2.0)
       git (~> 1.5)
-      kramdown (~> 1.5)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
       octokit (~> 4.7)
       terminal-table (~> 1)
@@ -36,7 +37,7 @@ GEM
     diff-lcs (1.3)
     faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
+    faraday-http-cache (2.0.0)
       faraday (~> 0.8)
     ffi (1.10.0)
     formatador (0.2.5)
@@ -56,20 +57,22 @@ GEM
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
     jaro_winkler (1.5.2)
-    kramdown (1.17.0)
+    kramdown (2.1.0)
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
     lumberjack (1.0.13)
     method_source (0.9.2)
-    multipart-post (2.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
     no_proxy_fix (0.1.2)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.13.0)
+    octokit (4.14.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.13.0)
@@ -79,7 +82,7 @@ GEM
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    public_suffix (3.0.3)
+    public_suffix (3.1.1)
     rainbow (3.0.0)
     rake (10.5.0)
     rb-fsevent (0.10.3)
@@ -107,15 +110,15 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.4.0)
     ruby-progressbar (1.10.0)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
     thor (0.20.3)
     unicode-display_width (1.4.1)
-    yard (0.9.18)
+    yard (0.9.20)
 
 PLATFORMS
   ruby
@@ -133,4 +136,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   1.16.2
+   1.17.2

data/Guardfile

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 # A guardfile for making Danger Plugins
 # For more info see https://github.com/guard/guard#readme
 
 # To run, use `bundle exec guard`.
 
-guard :rspec, cmd: 'bundle exec rspec' do
-  require 'guard/rspec/dsl'
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
   dsl = Guard::RSpec::Dsl.new(self)
 
   # RSpec files

data/README.md

@@ -1,6 +1,6 @@
 # Danger IBLinter
 
-[![Build Status](https://travis-ci.org/IBDecodable/danger-ruby-iblinter.svg?branch=master)](https://travis-ci.org/IBDecodable/danger-ruby-iblinter)
+[![Build Status](https://travis-ci.org/IBDecodable/danger-ruby-iblinter.svg?branch=master)](https://travis-ci.org/IBDecodable/danger-ruby-iblinter) [![Gem Version](https://badge.fury.io/rb/danger-iblinter.svg)](https://badge.fury.io/rb/danger-iblinter)
 
 A danger plugin for IBLinter.
 
@@ -19,6 +19,17 @@ iblinter.binary_path = "./Pods/IBLinter/bin/iblinter"
 iblinter.lint("./path/to/project", fail_on_warning: true, inline_mode: true)
 ```
 
+```ruby
+iblinter.execute_command = "swift run iblinter"
+iblinter.lint("./path/to/project", fail_on_warning: true, inline_mode: true)
+```
+
+|     parameter   | default |
+|:---------------:|:-------:|
+| fail_on_warning |  false  |
+|   inline_mode   |  true   |
+
+
 ## Development
 
 1. Clone this repo

data/Rakefile

@@ -1,23 +1,25 @@
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require 'rubocop/rake_task'
+# frozen_string_literal: true
+
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new(:specs)
 
 task default: :specs
 
 task :spec do
-  Rake::Task['specs'].invoke
-  Rake::Task['rubocop'].invoke
-  Rake::Task['spec_docs'].invoke
+  Rake::Task["specs"].invoke
+  Rake::Task["rubocop"].invoke
+  Rake::Task["spec_docs"].invoke
 end
 
-desc 'Run RuboCop on the lib/specs directory'
+desc "Run RuboCop on the lib/specs directory"
 RuboCop::RakeTask.new(:rubocop) do |task|
-  task.patterns = ['lib/**/*.rb', 'spec/**/*.rb']
+  task.patterns = ["lib/**/*.rb", "spec/**/*.rb"]
 end
 
-desc 'Ensure that the plugin passes `danger plugins lint`'
+desc "Ensure that the plugin passes `danger plugins lint`"
 task :spec_docs do
-  sh 'bundle exec danger plugins lint'
+  sh "bundle exec danger plugins lint"
 end

data/danger-iblinter.gemspec

@@ -1,42 +1,43 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'iblinter/gem_version.rb'
+require "iblinter/gem_version.rb"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'danger-iblinter'
+  spec.name          = "danger-iblinter"
   spec.version       = Iblinter::VERSION
-  spec.authors       = ['Yuta Saito']
-  spec.email         = ['kateinoigakukun@gmail.com']
-  spec.description   = %q{A danger plugin for linting Interface Builder files with IBLinter.}
-  spec.summary       = %q{A danger plugin for linting Interface Builder files with IBLinter.}
-  spec.homepage      = 'https://github.com/IBDecodable/danger-ruby-iblinter'
-  spec.license       = 'MIT'
+  spec.authors       = ["Yuta Saito"]
+  spec.email         = ["kateinoigakukun@gmail.com"]
+  spec.description   = "A danger plugin for linting Interface Builder files with IBLinter."
+  spec.summary       = "A danger plugin for linting Interface Builder files with IBLinter."
+  spec.homepage      = "https://github.com/IBDecodable/danger-ruby-iblinter"
+  spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ['lib']
+  spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
+  spec.add_runtime_dependency "danger-plugin-api", "~> 1.0"
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "rake", "~> 10.0"
 
   # Testing support
-  spec.add_development_dependency 'rspec', '~> 3.4'
+  spec.add_development_dependency "rspec", "~> 3.4"
 
   # Linting code and docs
   spec.add_development_dependency "rubocop"
   spec.add_development_dependency "yard"
 
   # Makes testing easy via `bundle exec guard`
-  spec.add_development_dependency 'guard', '~> 2.14'
-  spec.add_development_dependency 'guard-rspec', '~> 4.7'
+  spec.add_development_dependency "guard", "~> 2.14"
+  spec.add_development_dependency "guard-rspec", "~> 4.7"
 
   # If you want to work on older builds of ruby
-  spec.add_development_dependency 'listen', '3.0.7'
+  spec.add_development_dependency "listen", "3.0.7"
 
   # This gives you the chance to run a REPL inside your tests
   # via:
@@ -45,5 +46,5 @@ Gem::Specification.new do |spec|
   #    binding.pry
   #
   # This will stop test execution and let you inspect the results
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency "pry"
 end

data/lib/iblinter/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Iblinter
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/iblinter/iblinter.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
 
 class IBLinterRunner
-  def initialize(binary_path)
+  def initialize(binary_path, execute_command)
     @binary_path = binary_path
+    @execute_command = execute_command
   end
 
   def run(command)
@@ -16,8 +17,9 @@ class IBLinterRunner
   end
 
   def lint_command(options)
-    abs_binary_path = @binary_path.nil? ? "iblinter" : File.absolute_path(@binary_path)
-    "#{abs_binary_path} lint #{arguments(options.merge(reporter: 'json'))}"
+    executable = @execute_command
+    executable ||= @binary_path.nil? ? "iblinter" : File.absolute_path(@binary_path)
+    "#{executable} lint #{arguments(options.merge(reporter: 'json'))}"
   end
 
   # Parse options into shell arguments.

data/lib/iblinter/plugin.rb

@@ -18,12 +18,15 @@ module Danger
     # The path to IBLinter"s execution
     # @return  [void]
     attr_accessor :binary_path
+    attr_accessor :execute_command
 
     # Lints IB files. Will fail if `iblinter` cannot be installed correctly.
     # @return   [void]
     #
     def lint(path = Dir.pwd, fail_on_warning: false, inline_mode: true, options: {})
-      raise "iblinter is not installed" unless iblinter_installed?
+      unless @execute_command || iblinter_installed?
+        raise "iblinter is not installed"
+      end
 
       issues = iblinter.lint(path, options)
       return if issues.empty?
@@ -51,7 +54,7 @@ module Danger
     # Instantiate iblinter
     # @return     [IBLinterRunner]
     def iblinter
-      IBLinterRunner.new(@binary_path)
+      IBLinterRunner.new(@binary_path, @execute_command)
     end
 
     private

data/spec/iblinter_spec.rb

@@ -4,11 +4,35 @@ require File.expand_path("spec_helper", __dir__)
 require_relative "../lib/iblinter/iblinter"
 
 describe IBLinterRunner do
-  it "command arguments works" do
-    binary_path = File.absolute_path "path/to/binary"
-    options = {}
-    cmd = "#{binary_path} lint --reporter json"
-    iblinter = IBLinterRunner.new(binary_path)
-    expect(iblinter.lint_command(options)).to eq cmd
+  let(:options) { {} }
+  let(:cmd) { "swift run iblinter lint --reporter json" }
+  let(:binary_path) { nil }
+  let(:execute_command) { nil }
+  let(:iblinter) { IBLinterRunner.new(binary_path, execute_command) }
+
+  context "binary_path is passed" do
+    let(:binary_path) { File.absolute_path "path/to/binary" }
+    let(:cmd) { "#{binary_path} lint --reporter json" }
+
+    it "should return valid command" do
+      expect(iblinter.lint_command(options)).to eq cmd
+    end
+  end
+
+  context "execute_command is passed" do
+    let(:execute_command) { "swift run iblinter" }
+
+    it "should return valid command" do
+      expect(iblinter.lint_command(options)).to eq cmd
+    end
+  end
+
+  context "binary_path and execute_command are passed" do
+    let(:execute_command) { "swift run iblinter" }
+    let(:binary_path) { File.absolute_path "path/to/binary" }
+
+    it "should ignore binary_path" do
+      expect(iblinter.lint_command(options)).to eq cmd
+    end
   end
 end

data/spec/plugin_spec.rb

@@ -20,7 +20,7 @@ module Danger
       end
 
       it "inline comment works with relative path" do
-        linter = IBLinterRunner.new("/path/to/binary")
+        linter = IBLinterRunner.new("/path/to/binary", nil)
         allow(linter).to receive(:lint) do
           JSON.parse(File.read(File.dirname(__FILE__) + "/support/fixtures/iblinter.json"))
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-iblinter
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Yuta Saito
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-22 00:00:00.000000000 Z
+date: 2019-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -196,8 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.5
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: A danger plugin for linting Interface Builder files with IBLinter.