danger-gitlab_reviewbot 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b732c4099468c0343e8b699704319a26ed7673e10eaa8de447fa9d0f4f5314e
-  data.tar.gz: 23fcc491ac6224d9afc3fb50b5149d59568f6a94147675493c79c0a31f9eadbf
+  metadata.gz: 78868b60ea86cc9289c4a13598fe7807228c548190c02769f6a7007144c25bb9
+  data.tar.gz: c4a7efe442933e89acb1efdca5602ca5bc3742c51f8874b0d220a7fd0988cae0
 SHA512:
-  metadata.gz: e4f3a3ba3e1ea7bbf437a35412036c30e696547b35cf1ecbef85cbe491a8e0e04f0243fba5cb38dc39262d8f7398b45d1c7aa5eb2092c0bb81ca70da216e420b
-  data.tar.gz: 4ff3d2fa865e58f0b694630f489f730ade355c9c0a2165ad608aee98705ec9eb920b87a4578334be6438bc551b93b257f840a3930c28f141b05aa9d87a91337a
+  metadata.gz: 72813a9d97245481c458864a9478e0641200e529c072adb9ab4e245954c250c3ab88d64147e23d3a82896cbdadfaa0f7463454fe1db45e4072f6ab898b4090ad
+  data.tar.gz: 56a3308398621751ce1bed2efb53a1b4f82ddf29bf105a00bd5197b06210276f0cd270b273125da66ad4ecb86e3671ba61cc67c1eb05ab12f557384ffbbfd142

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-gitlab_reviewbot (1.0.0)
+    danger-gitlab_reviewbot (1.0.2)
       danger-gitlab
       danger-plugin-api (~> 1.0)
 
@@ -79,7 +79,7 @@ GEM
     method_source (1.0.0)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2020.0425)
+    mime-types-data (3.2020.0512)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
     nap (1.1.0)
@@ -98,7 +98,7 @@ GEM
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.4)
+    public_suffix (4.0.5)
     rainbow (3.0.0)
     rake (13.0.1)
     rb-fsevent (0.10.4)

data/lib/gitlab_reviewbot/gem_version.rb

@@ -1,3 +1,3 @@
 module GitlabReviewbot
-  VERSION = "1.0.1".freeze
+  VERSION = "1.0.2".freeze
 end

data/lib/gitlab_reviewbot/plugin.rb

@@ -49,10 +49,6 @@ module Danger
       @strategy || Danger::AssignStrategies::RandomStrategy
     end
 
-    # Add verbosity to the logs
-    # @return Bool
-    attr_accessor :verbose
-
     # Call this method from the Dangerfile to assign reviewers to your merge requests
     # @return   The usernames list of assigned reviewes [Array<String>]
     #
@@ -67,23 +63,25 @@ module Danger
         raise "Env variable CI_PROJECT_ID doesn't point to a valid project id"
       end
 
-      current_assignees = (ENV['CI_MERGE_REQUEST_ASSIGNEES'] || '').split(',')
-      required_assignees_count = [assignees_amount - current_assignees.length, 0].max
+      current_assignees = (ENV['CI_MERGE_REQUEST_ASSIGNEES'] || '').split(',') #buggy?
+      already_assigned_count = current_assignees.length
+      required_assignees_count = [assignees_amount - already_assigned_count, 0].max
 
-      puts "Project ID: #{project_id}" if @verbose
-      puts "MR IID: #{mr_iid}" if @verbose
-      puts "Currently assigned: #{current_assignees}" if @verbose
-      puts "Required: #{required_assignees_count}" if @verbose
-      if required_assignees_count == 0
-        puts "Nothing to do" if @verbose
-        return
-      end
+      puts "Project ID: #{project_id}" if verbose
+      puts "MR IID: #{mr_iid}" if verbose
+      puts "Currently assigned: #{current_assignees}" if verbose
+ #    puts "Required: #{required_assignees_count}" if @verbose
+
+      # if required_assignees_count == 0
+      #   puts "Nothing to do" if @verbose
+      #   return
+      # end
 
       strategy_class = strategy.new(client: gitlab.api, project: project_id, mr: mr_iid, group: gitlab_group)
 
       assignees = strategy_class.assign! assignees_amount
 
-      puts "Assigning: #{assignees}" if @verbose
+      puts "Assigning: #{assignees}" if verbose
       return assignees
     end
   end

data/spec/gitlab_reviewbot_spec.rb

@@ -27,38 +27,29 @@ module Danger
 
         @plugin.assign!
       end
-      # it "Assign one reviewer" do
-      #   @plugin.gitlab_group = 'tech/ios'
-      #
-      #   expect(@strategy_mock).to receive(:assign!).with(1).and_return(['Sam'])
-      #
-      #   @plugin.assign!
-      # end
-      #
-      # it "Assign multiple reviewers" do
-      #   @plugin.gitlab_group = 'tech/ios'
-      #   @plugin.assignees_amount = 2
-      #
-      #   expect(@strategy_mock).to receive(:assign!).with(2).and_return(['Sam, Nic'])
-      #
-      #   @plugin.assign!
-      # end
-      #
-      # it "Doesn't assign if already asssigned" do
-      #   ENV['CI_MERGE_REQUEST_ASSIGNEES'] = 'Sam'
-      #   @plugin.gitlab_group = 'tech/ios'
-      #
-      #   expect(@strategy_mock).not_to receive(:assign!)
-      #
-      #   @plugin.assign!
-      # end
-      #
-      # ['CI_PROJECT_ID', 'CI_MERGE_REQUEST_IID'].each do |var|
-      #   it "Fails when required #{var} variables are not available" do
-      #     ENV[var] = nil
-      #     expect{@plugin.assign!}.to raise_error(RuntimeError)
-      #   end
-      # end
+      it "Assign one reviewer" do
+        @plugin.gitlab_group = 'tech/ios'
+
+        expect(@strategy_mock).to receive(:assign!).with(1).and_return(['Sam'])
+
+        @plugin.assign!
+      end
+
+      it "Assign multiple reviewers" do
+        @plugin.gitlab_group = 'tech/ios'
+        @plugin.assignees_amount = 2
+
+        expect(@strategy_mock).to receive(:assign!).with(2).and_return(['Sam, Nic'])
+
+        @plugin.assign!
+      end
+
+      ['CI_PROJECT_ID', 'CI_MERGE_REQUEST_IID'].each do |var|
+        it "Fails when required #{var} variables are not available" do
+          ENV[var] = nil
+          expect{@plugin.assign!}.to raise_error(RuntimeError)
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-gitlab_reviewbot
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Fabio Gallonetto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-12 00:00:00.000000000 Z
+date: 2020-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api