danger-eslint 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7662c84b8cf4e59149bf5b1db89546f206ee42d0
-  data.tar.gz: dc030966e2fb57ced713cba5c5d48a7e2ae89845
+  metadata.gz: 6f1c2b1f5cc50b20e1fb7684a101fda696347842
+  data.tar.gz: 7ebd2562a9f5954fba18e24d9ce502d31eb642f5
 SHA512:
-  metadata.gz: 5e1d78c20be447625d058b7eb476ae6c0bd7a354101af3a40937abb7e5ea9a601b341be5eb6ae4903325ac3cea1e3197e9ddb3e13cd433bbd9cb1e5c985cbab2
-  data.tar.gz: 365b88444f32fd81840bcd4f1a03d6e2024e111c5e00f6c5359140cfc508ae9a5e7b0fd6ddb3e9878513dbe392bae21d7bc1282be5a8bd28a03746a382e05ab6
+  metadata.gz: 6dc3f8c06853abd290391b436c8551b398a3f6d07957f4977d2fbb81e1024cca4b08544e783ec00e7324979d56405134b2f6f5c9f628368d68953dd895d7b0fb
+  data.tar.gz: fb7132d0d87f09efeb9f5231e7a1575962939b9b4ca631fa7e31a364ae032ed63b294b7d28512f7a296cfc15d264f3ec83aa1cd770c5438ec29c7c8ff3c442ad

data/.rubocop.yml

@@ -1,3 +1,5 @@
+Style/FrozenStringLiteralComment:
+  Enabled: false
 
 Metrics/BlockLength:
   Exclude:

data/.travis.yml

@@ -4,9 +4,8 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
   - 2.1.3
   - 2.3.1
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/README.md

@@ -30,6 +30,18 @@ If you want to lint only new/modified files. You can achieve that with setting t
     eslint.filtering = true
     eslint.lint
 
+If you want to lint files with specified extension, you can set extensions to the `target_extensions` parameter.  
+The default value is `['.js']`. In the case of the example below, the value will be `['.js', '.es6']`.
+
+    eslint.target_extensions += %W(.es6)
+    eslint.lint
+
+If you want to specify eslint's bin file, you can set a bin path to the `bin_path` parameter.
+
+    eslint.bin_path = "/hoge/node_modules/.bin/eslint"
+    eslint.lint
+
+
 ## Development
 
 1. Clone this repo

data/lib/eslint/gem_version.rb

@@ -1,3 +1,3 @@
 module Eslint
-  VERSION = '0.1.4'.freeze
+  VERSION = '0.1.5'.freeze
 end

data/lib/eslint/plugin.rb

@@ -13,6 +13,8 @@ module Danger
   # @see  leonhartX/danger-eslint
   # @tags lint, javaxctipt
   class DangerEslint < Plugin
+    DEFAULT_BIN_PATH = './node_modules/.bin/eslint'
+
     # An path to eslint's config file
     # @return [String]
     attr_accessor :config_file
@@ -26,6 +28,20 @@ module Danger
     # @return [Boolean]
     attr_accessor :filtering
 
+    # A path of eslint's bin
+    attr_writer :bin_path
+    def bin_path
+      @bin_path ||= DEFAULT_BIN_PATH
+    end
+
+    # Specified extentions of target file
+    # Default is [".js"]
+    # @return [Array]
+    attr_writer :target_extensions
+    def target_extensions
+      @target_extensions ||= %W(.js)
+    end
+
     # Lints javascript files.
     # Generates `errors` and `warnings` due to eslint's config.
     # Will try to send inline comment if supported(Github)
@@ -45,8 +61,7 @@ module Danger
     #
     # return [String]
     def eslint_path
-      local = './node_modules/.bin/eslint'
-      File.exist?(local) ? local : find_executable('eslint')
+      File.exist?(bin_path) ? bin_path : find_executable('eslint')
     end
 
     # Get lint result regards the filtering option
@@ -57,7 +72,7 @@ module Danger
       raise 'eslint is not installed' unless bin
       return run_lint(bin, '.') unless filtering
       ((git.modified_files - git.deleted_files) + git.added_files)
-        .select { |f| f.end_with? '.js' }
+        .select { |f| target_extensions.include?(File.extname(f)) }
         .map { |f| f.gsub("#{Dir.pwd}/", '') }
         .map { |f| run_lint(bin, f).first }
     end

data/spec/eslint_spec.rb

@@ -16,7 +16,7 @@ module Danger
         allow(@eslint.git).to receive(:deleted_files).and_return([])
         allow(@eslint.git).to receive(:added_files).and_return([])
         allow(@eslint.git).to receive(:modified_files).and_return([])
-        allow(@eslint).to receive(:eslint_path).and_return('eslint')
+        stub_const("Danger::DangerEslint::DEFAULT_BIN_PATH", 'spec/fixtures/bin/dummy_eslint')
       end
 
       it 'does not make an empty message' do
@@ -81,6 +81,27 @@ module Danger
           expect(@eslint.status_report[:warnings].length).to be(0)
         end
 
+        it 'lint files with specified extention by target_extensions' do
+          allow(@eslint).to receive(:run_lint)
+            .with(anything, /error.[js|es6]/).and_return(@error_result)
+          allow(@eslint.git).to receive(:modified_files)
+            .and_return([
+              'spec/fixtures/javascript/error.es6',
+              'spec/fixtures/javascript/error.js'
+            ])
+
+          @eslint.target_extensions += %W(.es6)
+          @eslint.filtering = true
+          @eslint.lint
+
+          errors = @eslint.status_report[:errors]
+          expect(errors.length).to be(2)
+          errors.each do |error|
+            expect(error).to eq('Parsing error: Unexpected token ;')
+          end
+          expect(@eslint.status_report[:warnings].length).to be(0)
+        end
+
         it 'do not print anything if no violations' do
           allow(@eslint.git).to receive(:modified_files)
             .and_return(['spec/fixtures/javascript/empty.js'])
@@ -132,6 +153,21 @@ module Danger
           expect(@eslint.status_report[:errors].length).to be(1)
           expect(@eslint.status_report[:warnings].length).to be(2)
         end
+
+        it 'can specify eslint bin file' do
+          bin_file = 'spec/fixtures/bin/somewhere_eslint'
+          expect(@eslint).to receive(:run_lint)
+            .with(bin_file, /error.js/).and_return(@error_result)
+          allow(@eslint.git).to receive(:modified_files)
+            .and_return(['spec/fixtures/javascript/error.js'])
+
+          @eslint.bin_path = bin_file
+          @eslint.filtering = true
+          @eslint.lint
+          error = @eslint.status_report[:errors].first
+          expect(error).to eq('Parsing error: Unexpected token ;')
+          expect(@eslint.status_report[:warnings].length).to be(0)
+        end
       end
     end
   end

data/spec/fixtures/javascript/error.es6

@@ -0,0 +1 @@
+var a = ;

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-eslint
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - leonhartX
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-28 00:00:00.000000000 Z
+date: 2019-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -174,9 +174,12 @@ files:
 - lib/eslint/gem_version.rb
 - lib/eslint/plugin.rb
 - spec/eslint_spec.rb
+- spec/fixtures/bin/dummy_eslint
+- spec/fixtures/bin/somewhere_eslint
 - spec/fixtures/config/.eslintignore
 - spec/fixtures/config/.eslintrc.json
 - spec/fixtures/javascript/empty.js
+- spec/fixtures/javascript/error.es6
 - spec/fixtures/javascript/error.js
 - spec/fixtures/javascript/ignored.js
 - spec/fixtures/javascript/warning.js
@@ -207,15 +210,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for linting javascript with eslint.
 test_files:
 - spec/eslint_spec.rb
+- spec/fixtures/bin/dummy_eslint
+- spec/fixtures/bin/somewhere_eslint
 - spec/fixtures/config/.eslintignore
 - spec/fixtures/config/.eslintrc.json
 - spec/fixtures/javascript/empty.js
+- spec/fixtures/javascript/error.es6
 - spec/fixtures/javascript/error.js
 - spec/fixtures/javascript/ignored.js
 - spec/fixtures/javascript/warning.js