danger-eslint 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1180844b62ed462c63d0d4499d2a966323935fe9
-  data.tar.gz: d4d0cf2f19d4253c10155f37b0c45c33bc295745
+  metadata.gz: f75306f444e29ba6a23da7b7249efe6d1ac455aa
+  data.tar.gz: 1ff629f993c4a7ca1c5debbe9c4224173edffc78
 SHA512:
-  metadata.gz: b9da0dacc407c6399097ca0dbb508ac212f69367436d88ec0a9fb2eb4135188d497b4d81d9eb7d01517efa82cb482e2f684ca47fe60c29a34473ee48ba85e890
-  data.tar.gz: a81811c2be884c329c940361d322ca2dd57176f12ac20348e00d0ad1c689b7a66d419d2201d24d6cd31f3bf3da2d48cb3d25a95568a8f32caa91d1d0f53bfab7
+  metadata.gz: 4a6e78d3e64ddaa1b360af3b8dc0664cbebffc19f1f67b601171b3042ece4260e3ffdc620ab4af50a94bc05eee5dc2293f57ced6a3e65a1f944ba6b4dbab17bb
+  data.tar.gz: 25f1d6d34311c3bec5ee6d1a075278f903ee1bc8422eb15962e720c80704aa593faadd0266ff8480c03c79954bd2343317c2ecba75a4aab0bb763120b7644be7

data/.rubocop.yml

@@ -0,0 +1,17 @@
+
+Metrics/BlockLength:
+  Exclude:
+    - "**/*_spec.rb"
+
+Metrics/LineLength:
+  Max: 120
+  Exclude:
+    - "**/*_spec.rb"
+  
+Metrics/ModuleLength:
+  Exclude:
+    - "**/*_spec.rb"
+
+Metrics/AbcSize:
+  Enabled: true
+  Max: 25

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-eslint (0.1.0)
+    danger-eslint (0.1.1)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -19,7 +19,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.3.0)
+    danger (5.3.1)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -132,4 +132,4 @@ DEPENDENCIES
   yard (~> 0.8)
 
 BUNDLED WITH
-   1.15.0
+   1.15.1

data/README.md

@@ -1,15 +1,34 @@
+[![Gem](https://img.shields.io/gem/v/danger-eslint.svg)](https://rubygems.org/gems/danger-eslint)
+[![Gem](https://img.shields.io/gem/dt/danger-eslint.svg)](https://rubygems.org/gems/danger-eslint)
+[![Gem](https://img.shields.io/gem/dtv/danger-eslint.svg)](https://rubygems.org/gems/danger-eslint)
+[![Travis branch](https://img.shields.io/travis/leonhartX/danger-eslint/master.svg)](https://travis-ci.org/leonhartX/danger-eslint)
 # danger-eslint
 
-A description of danger-eslint.
+A [Danger](https://github.com/danger/danger) plugin for [eslint](http://eslint.org/).
 
 ## Installation
 
     $ gem install danger-eslint
+    
+`eslint` also needs to be installed(global or local) before you run Danger, Please check the [installation guide](http://eslint.org/docs/user-guide/getting-started)
+`danger-eslint` will first try local `node_module/.bin/eslint` then the global `eslint`.
 
 ## Usage
+Run lint without and configuration will do the samething as run `eslint .`  
+All lint result will send as individual comment. If your are using Github, the comment will show as a inline comment directly on the violation's position if possiable.
 
-    Methods and attributes from this plugin are available in
-    your `Dangerfile` under the `eslint` namespace.
+    eslint.lint
+
+Also, you can pass a config file or eslintignore file to danger-eslint with:
+
+    eslint.config_file = /path/yourconfig
+    eslint.ignore_file = /path/yourigonre
+    eslint.lint
+    
+If you want to lint only new/modified files. You can achieve that with setting the `filtering` parameter to `true`.
+
+    eslint.filtering = true
+    eslint.lint
 
 ## Development
 

data/danger-eslint.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Eslint::VERSION
   spec.authors       = ['leonhartX']
   spec.email         = ['leonhartx.k@gmail.com']
-  spec.description   = %q{A short description of danger-eslint.}
-  spec.summary       = %q{A longer description of danger-eslint.}
+  spec.description   = %q{A Danger plugin for linting javascript with eslint.}
+  spec.summary       = %q{A Danger plugin for linting javascript with eslint.}
   spec.homepage      = 'https://github.com/leonhartX/danger-eslint'
   spec.license       = 'MIT'
 
@@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.4'
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.41"
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "rubocop", "~> 0.49"
+  spec.add_development_dependency "yard", "~> 0.9.11"
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'

data/lib/eslint/gem_version.rb

@@ -1,3 +1,3 @@
 module Eslint
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.2'.freeze
 end

data/lib/eslint/plugin.rb

@@ -2,23 +2,16 @@ require 'mkmf'
 require 'json'
 
 module Danger
-  # This is your plugin class. Any attributes or methods you expose here will
-  # be available from within your Dangerfile.
+  # Lint javascript files using [eslint](http://eslint.org/).
+  # Results are send as inline commen.
   #
-  # To be published on the Danger plugins site, you will need to have
-  # the public interface documented. Danger uses [YARD](http://yardoc.org/)
-  # for generating documentation from your plugin source, and you can verify
-  # by running `danger plugins lint` or `bundle exec rake spec`.
+  # @example Run eslint with changed files only
   #
-  # You should replace these comments with a public description of your library.
-  #
-  # @example Ensure people are well warned about merging on Mondays
-  #
-  #          my_plugin.warn_on_mondays
+  #          eslint.filtering = true
+  #          eslint.lint
   #
   # @see  leonhartX/danger-eslint
-  # @tags monday, weekends, time, rattata
-  #
+  # @tags lint, javaxctipt
   class DangerEslint < Plugin
     # An path to eslint's config file
     # @return [String]
@@ -40,18 +33,8 @@ module Danger
     # @return  [void]
     #
     def lint
-      bin = eslint_path
-      raise 'eslint is not installed' unless bin
-      if filtering
-        results = ((git.modified_files - git.deleted_files) + git.added_files)
-                  .select { |f| f.end_with? '.js' }
-                  .map { |f| f.gsub("#{Dir.pwd}/", '') }
-                  .map { |f| run_lint(bin, f).first }
-      else
-        results = run_lint(bin, '.')
-      end
-      results
-        .reject { |r| r['messages'].length.zero? }
+      lint_results
+        .reject { |r| r.nil? || r['messages'].length.zero? }
         .reject { |r| r['messages'].first['message'].include? 'matching ignore pattern' }
         .map { |r| send_comment r }
     end
@@ -66,6 +49,19 @@ module Danger
       File.exist?(local) ? local : find_executable('eslint')
     end
 
+    # Get lint result regards the filtering option
+    #
+    # return [Hash]
+    def lint_results
+      bin = eslint_path
+      raise 'eslint is not installed' unless bin
+      return run_lint(bin, '.') unless filtering
+      ((git.modified_files - git.deleted_files) + git.added_files)
+        .select { |f| f.end_with? '.js' }
+        .map { |f| f.gsub("#{Dir.pwd}/", '') }
+        .map { |f| run_lint(bin, f).first }
+    end
+
     # Run eslint aginst a single file.
     #
     # @param   [String] bin

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-eslint
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - leonhartX
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-19 00:00:00.000000000 Z
+date: 2018-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -72,28 +72,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -150,7 +150,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A short description of danger-eslint.
+description: A Danger plugin for linting javascript with eslint.
 email:
 - leonhartx.k@gmail.com
 executables: []
@@ -160,6 +160,7 @@ files:
 - ".eslintignore"
 - ".eslintrc.json"
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
@@ -206,10 +207,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
-summary: A longer description of danger-eslint.
+summary: A Danger plugin for linting javascript with eslint.
 test_files:
 - spec/eslint_spec.rb
 - spec/fixtures/config/.eslintignore