danger-device_grid 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24146e81aec797842e6bbd8cf8f0ca32d686cda5
-  data.tar.gz: a0a6f87d66e38932239848d50cc25ff7b80c25a1
+  metadata.gz: 13371b122abdf398631b824c58ab1d05d3747e24
+  data.tar.gz: 1bb4329ead14859c5afe27bab85695e8334da349
 SHA512:
-  metadata.gz: 3213aedf934c07c464a193fe6e3b638ce3e62d3702b626f45c2605d4af007d4daf5c60b814400174fc8ec7bd48f1f56616a92cfa2cd389cd231be7873bf7f942
-  data.tar.gz: eabb6d9f4a4250b2b7f5712aae2997f9e36c581752a645b521c87c29edf4c57c565038f950a5cf54dea29f5e68bff4b6b0c66d0d915e8adb7980b3a0329d9783
+  metadata.gz: 0475d605c9337bae9f4334977ff0866e2988821929dfd3c9774132da80f8038b586f6fd55fd811edbf0187bf8cd1028b53751766a2ced51c37e9e907c1f6743b
+  data.tar.gz: 41079867a8c8a30287f25b479987928acd51e671b8677c70b8c44f7ea7ebd31ff9aeb2dc6a2befc0a7ab1a6771084be1b4a853c919409abc4ac5c3e04be643ea

data/README.md

@@ -0,0 +1,5 @@
+# Danger Device Grid plugin
+
+This is a plugin for the popular [Danger code review tool](https://danger.systems). It makes it possible to include a device grid showing all your screenshots directly inside your project's PRs.
+
+You can find the full documentation inside of the [main fastlane repo here](https://github.com/fastlane/fastlane/tree/master/fastlane/lib/fastlane/actions/device_grid). 

data/danger-device_grid.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Felix Krause', 'Boris Bügling']
   spec.email         = ['danger@krausefx.com', 'boris@icculus.org']
   spec.summary       = %q{Danger plugin for the fastlane device grid.}
-  spec.homepage      = 'https://github.com/fastlane/fastlane/tree/master/danger-device_grid'
+  spec.homepage      = 'https://github.com/fastlane/danger-device_grid'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
@@ -17,10 +17,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'fastlane', '>= 1.94.0', '< 2.0.0'
+  spec.add_dependency "fastlane", ">= 2.0.0", "< 3.0.0"
 
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rake', '< 12'
   spec.add_development_dependency 'rspec', '~> 3.1.0'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.2.3'
+  spec.add_development_dependency 'rubocop', '~> 0.44.0'
 end

data/lib/device_grid/gem_version.rb

@@ -1,3 +1,3 @@
 module DeviceGrid
-  VERSION = "0.1.2".freeze
+  VERSION = "0.2.0".freeze
 end

data/lib/device_grid/plugin.rb

@@ -15,7 +15,7 @@ module Danger
       fastlane_colors_were_disabled = ENV.key?(fastlane_colors_env)
       ENV[fastlane_colors_env] = "true"
 
-      devices ||= %w(iphone4s iphone5s iphone6s iphone6splus ipadair)
+      devices ||= %w(iphone4s iphone5s iphone6s iphone7 iphone6splus iphone7plus ipadair)
       languages ||= ["en"]
 
       prefix_command ||= ""
@@ -26,15 +26,16 @@ module Danger
       deep_link_matches = github.pr_body.match(/:link:\s(.*)/) # :link: emoji
       deep_link = deep_link_matches[1] if deep_link_matches
 
-      markdown("<table>")
+      html = ""
+      html << "<table>"
       languages.each do |current_language|
-        markdown("<tr>")
-        markdown("<td>")
-        markdown("<b>#{current_language[0..1]}</b>")
-        markdown("</td>")
+        html << "<tr>"
+        html << "<td>"
+        html << "<b>#{current_language[0..1]}</b>"
+        html << "</td>"
 
         devices.each do |current_device|
-          markdown("<td>")
+          html << "<td>"
 
           params = {
             public_key: public_key,
@@ -46,19 +47,20 @@ module Danger
           url = Fastlane::Helper.backticks("#{prefix_command}fastlane run appetize_viewing_url_generator #{params_str}")
           url = url.match(%r{Result:.*(https\:\/\/.*)})[1].strip
 
-          markdown("<a href='#{url}'>")
-          markdown("<p align='center'>")
-          markdown("<img height='130' src='#{url_for_device(current_device)}' />")
-          markdown("<br />")
-          markdown(beautiful_device_name(current_device))
-          markdown("</p>")
-          markdown("</a>")
+          html << "<a href='#{url}'>"
+          html << "<p align='center'>"
+          html << "<img height='130' src='#{url_for_device(current_device)}' />"
+          html << "<br />"
+          html << beautiful_device_name(current_device)
+          html << "</p>"
+          html << "</a>"
 
-          markdown("</td>")
+          html << "</td>"
         end
-        markdown("</tr>")
+        html << "</tr>"
       end
-      markdown("</table>")
+      html << "</table>"
+      markdown(html)
     ensure
       ENV.delete(fastlane_colors_env) unless fastlane_colors_were_disabled
     end
@@ -73,7 +75,9 @@ module Danger
         iphone6splus: "iPhone 6s Plus",
         ipadair: "iPad Air",
         iphone6: "iPhone 6",
+        iphone7: "iPhone 7",
         iphone6plus: "iPhone 6 Plus",
+        iphone7plus: "iPhone 7 Plus",
         ipadair2: "iPad Air 2",
         nexus5: "Nexus 5",
         nexus7: "Nexus 7",
@@ -88,8 +92,10 @@ module Danger
         iphone4s: host + "iphone4s.png",
         iphone5s: host + "iphone5s.png",
         iphone6: host + "iphone6s.png",
+        iphone7: host + "iphone6s.png",
         iphone6s: host + "iphone6s.png",
         iphone6plus: host + "iphone6splus.png",
+        iphone7plus: host + "iphone6splus.png",
         iphone6splus: host + "iphone6splus.png",
         ipadair: host + "ipadair.png",
         ipadair2: host + "ipadair.png"

data/spec/device_grid_spec.rb

@@ -18,7 +18,7 @@ module Danger
 
         def markdown(str)
           @current_markdown ||= ""
-          @current_markdown += "#{str}\n"
+          @current_markdown += str.to_s
         end
       end
     end
@@ -31,12 +31,17 @@ module Danger
 
     it "works" do
       public_key = "1461233806"
+      correct = File.read("spec/fixtures/device_grid_results.html")
+                    .gsub("[[version]]", Fastlane::VERSION)
+                    .delete("\n")
+
       dg = Danger::DangerDeviceGrid.new(Danger::Dangerfile::DSL::Plugin.new)
+      allow(dg).to receive(:markdown).once.with(correct).and_call_original
+
       dg.run(languages: ['en', 'de'],
              devices: ['iphone4s'],
              public_key: public_key)
 
-      correct = File.read("spec/fixtures/device_grid_results.html").gsub("[[version]]", Fastlane::VERSION)
       expect(dg.current_markdown).to eq(correct)
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-device_grid
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-02 00:00:00.000000000 Z
+date: 2016-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane
@@ -17,20 +17,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.94.0
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.94.0
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -49,16 +49,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -87,6 +87,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.3
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.44.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.44.0
 description: 
 email:
 - danger@krausefx.com
@@ -96,6 +110,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - Gemfile
+- README.md
 - Rakefile
 - danger-device_grid.gemspec
 - lib/danger_device_grid.rb
@@ -105,7 +120,7 @@ files:
 - spec/device_grid_spec.rb
 - spec/fixtures/device_grid_results.html
 - spec/spec_helper.rb
-homepage: https://github.com/fastlane/fastlane/tree/master/danger-device_grid
+homepage: https://github.com/fastlane/danger-device_grid
 licenses:
 - MIT
 metadata: {}
@@ -125,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Danger plugin for the fastlane device grid.