danger-code_coverage 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87f7da211148028a249f9cc7c7148dbb062afff5f9051ab10a61f41f9ff099fb
-  data.tar.gz: 56e1a510efb6328c2503bfe5b2d8d692e47d7e41215ea7e8db94b5f0afb7a537
+  metadata.gz: 30f8c1cbdf5d0b6864186f29788385e7b745c6b4f4fb94e9ab80ddd5c3b4a52c
+  data.tar.gz: 6fbc3bb126d30d66d8464e14d3476392506b442aa75feff0e27d3b3cae58020b
 SHA512:
-  metadata.gz: 0be58244b5414e839169c53a33e08d2578baf4b6dc576584d9bd6a5e43fa7d186171b5d6588816b9c9150dda50e187c5916096330e719a6571b4a0ae50af78a1
-  data.tar.gz: 3bd3619c9e8c63258e40d955d05666d969c3bfb48e37816f29a37914957a8829fa39801d8512be2f769354b198618eccb247b1f15e2853947540fbcd40cfddcf
+  metadata.gz: '01839299c25eb0b3c6ed3d07a27ff11a5988c72ab6ed0deddf7f44037ac478d91e2b6371bbb21ce681779ccafccefdd808882bd308f8162f32ad98021cf5cda0'
+  data.tar.gz: ad06067bcf5b764d6dff81854e087ec4a03d2391f771eaa56cc82fab78ddff23b9e8ae10df332be086e7beffd09891f4d28a218e34982b1d9c2bb3436fbcc58f

data/.rubocop.yml

@@ -1624,7 +1624,7 @@ Lint/UnifiedInteger:
   Enabled: true
   VersionAdded: '0.43'
 
-Lint/UnneededCopDisableDirective:
+Lint/RedundantCopDisableDirective:
   Description: >-
     Checks for rubocop:disable comments that can be removed.
     Note: this cop is not disabled when disabling all cops.
@@ -1632,20 +1632,19 @@ Lint/UnneededCopDisableDirective:
   Enabled: true
   VersionAdded: '0.53'
 
-Lint/UnneededCopEnableDirective:
+Lint/RedundantCopEnableDirective:
   Description: Checks for rubocop:enable comments that can be removed.
   Enabled: true
   VersionAdded: '0.53'
 
-Lint/UnneededRequireStatement:
+Lint/RedundantRequireStatement:
   Description: 'Checks for unnecessary `require` statement.'
   Enabled: true
   VersionAdded: '0.51'
 
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Description: 'Checks for splat unnecessarily being called on literals.'
   Enabled: true
-  VersionAdded: '0.43'
 
 Lint/UnreachableCode:
   Description: 'Unreachable code.'
@@ -3763,29 +3762,28 @@ Style/UnlessElse:
   Enabled: true
   VersionAdded: '0.9'
 
-Style/UnneededCapitalW:
+Style/RedundantCapitalW:
   Description: 'Checks for %W when interpolation is not needed.'
   Enabled: true
   VersionAdded: '0.21'
-  VersionChanged: '0.24'
 
-Style/UnneededCondition:
+Style/RedundantCondition:
   Description: 'Checks for unnecessary conditional expressions.'
   Enabled: true
   VersionAdded: '0.57'
 
-Style/UnneededInterpolation:
+Style/RedundantInterpolation:
   Description: 'Checks for strings that are just an interpolated expression.'
   Enabled: true
   VersionAdded: '0.36'
 
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Description: 'Checks for %q/%Q when single quotes or double quotes would do.'
   StyleGuide: '#percent-q'
   Enabled: true
   VersionAdded: '0.24'
 
-Style/UnneededSort:
+Style/RedundantSort:
   Description: >-
     Use `min` instead of `sort.first`,
     `max_by` instead of `sort_by...last`, etc.

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.1] - 2019-11-07
+### Fixed
+- Fix crash if an item has no data
+
 ## [1.0.0] - 2019-6-26
 ### Fixed
 - Catch all errors while parsing url content

data/lib/code_coverage/coverage_parser.rb

@@ -64,7 +64,7 @@ module CodeCoverage
     end
 
     def find_element_ratio(elements, name)
-      element = elements.select { |it| it['name'] == name }.first
+      element = elements.find { |it| it['name'] == name }
       element['ratio'].round(2) if element
     end
 

data/lib/code_coverage/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CodeCoverage
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/code_coverage/plugin.rb

@@ -51,8 +51,9 @@ module Danger
       options = args.first
       sort_order = options && options[:sort]
       if sort_order && !sort_order.eql?(:ascending) && !sort_order.eql?(:descending)
-        raise(ArgumentError, 'Invalid configuration, use [:ascending, :descending]')
+        raise(ArgumentError.new('Invalid configuration, use [:ascending, :descending]'))
       end
+
       check_auth(options)
 
       items = coverage_items
@@ -121,7 +122,11 @@ module Danger
         sum += convert_entry(item.instruction)
       end
 
-      (sum / count).round(2)
+      if count.zero?
+        0.0
+      else
+        (sum / count).round(2)
+      end
     end
 
     def auth_user(options)
@@ -158,7 +163,7 @@ module Danger
     end
 
     def coverage_json
-      options = {ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE}
+      options = { ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE }
       options[:http_basic_authentication] = [@auth[:user], @auth[:token]] if @auth
       OpenURI.open_uri("#{ENV['BUILD_URL']}/coverage/result/api/json?depth=5", options).read
     end

data/spec/assets/coverage_jacoco_no_data.json

@@ -0,0 +1,226 @@
+{
+  "_class": "io.jenkins.plugins.coverage.targets.CoverageResult",
+  "results": {
+    "children": [
+      {
+        "children": [
+          {
+            "children": [
+              {
+                "children": [
+                  {
+                    "children": [
+                      {},
+                      {}
+                    ],
+                    "elements": [
+                      {
+                        "denominator": 2.0,
+                        "name": "Class",
+                        "numerator": 0.0,
+                        "ratio": 0.0
+                      }
+                    ],
+                    "name": "MainActivity.java"
+                  }
+                ],
+                "elements": [
+                  {
+                    "denominator": 3.0,
+                    "name": "File",
+                    "numerator": 1.0,
+                    "ratio": 33.333332
+                  },
+                  {
+                    "denominator": 4.0,
+                    "name": "Class",
+                    "numerator": 1.0,
+                    "ratio": 25.0
+                  },
+                  {
+                    "denominator": 15.0,
+                    "name": "Method",
+                    "numerator": 1.0,
+                    "ratio": 6.6666665
+                  },
+                  {
+                    "denominator": 110.0,
+                    "name": "Instruction",
+                    "numerator": 6.0,
+                    "ratio": 5.4545455
+                  },
+                  {
+                    "denominator": 34.0,
+                    "name": "Line",
+                    "numerator": 1.0,
+                    "ratio": 2.9411764
+                  },
+                  {
+                    "denominator": 6.0,
+                    "name": "Conditional",
+                    "numerator": 2.0,
+                    "ratio": 33.333332
+                  }
+                ],
+                "name": "com/example/kyaak/myapplication"
+              }
+            ],
+            "elements": [
+              {
+                "denominator": 5.0,
+                "name": "Package",
+                "numerator": 3.0,
+                "ratio": 60.0
+              },
+              {
+                "denominator": 18.0,
+                "name": "File",
+                "numerator": 3.0,
+                "ratio": 16.666666
+              },
+              {
+                "denominator": 21.0,
+                "name": "Class",
+                "numerator": 3.0,
+                "ratio": 14.285714
+              },
+              {
+                "denominator": 193.0,
+                "name": "Method",
+                "numerator": 6.0,
+                "ratio": 3.1088083
+              },
+              {
+                "denominator": 2169.0,
+                "name": "Instruction",
+                "numerator": 52.0,
+                "ratio": 2.3974183
+              },
+              {
+                "denominator": 296.0,
+                "name": "Line",
+                "numerator": 9.0,
+                "ratio": 3.0405405
+              },
+              {
+                "denominator": 178.0,
+                "name": "Conditional",
+                "numerator": 3.0,
+                "ratio": 1.6853932
+              }
+            ],
+            "name": "project"
+          }
+        ],
+        "elements": [
+          {
+            "denominator": 1.0,
+            "name": "Group",
+            "numerator": 1.0,
+            "ratio": 100.0
+          },
+          {
+            "denominator": 5.0,
+            "name": "Package",
+            "numerator": 3.0,
+            "ratio": 60.0
+          },
+          {
+            "denominator": 18.0,
+            "name": "File",
+            "numerator": 3.0,
+            "ratio": 16.666666
+          },
+          {
+            "denominator": 21.0,
+            "name": "Class",
+            "numerator": 3.0,
+            "ratio": 14.285714
+          },
+          {
+            "denominator": 193.0,
+            "name": "Method",
+            "numerator": 6.0,
+            "ratio": 3.1088083
+          },
+          {
+            "denominator": 2169.0,
+            "name": "Instruction",
+            "numerator": 52.0,
+            "ratio": 2.3974183
+          },
+          {
+            "denominator": 296.0,
+            "name": "Line",
+            "numerator": 9.0,
+            "ratio": 3.0405405
+          },
+          {
+            "denominator": 178.0,
+            "name": "Conditional",
+            "numerator": 3.0,
+            "ratio": 1.6853932
+          }
+        ],
+        "name": "code_quality: jacoco.xml"
+      }
+    ],
+    "elements": [
+      {
+        "denominator": 1.0,
+        "name": "Report",
+        "numerator": 1.0,
+        "ratio": 100.0
+      },
+      {
+        "denominator": 1.0,
+        "name": "Group",
+        "numerator": 1.0,
+        "ratio": 100.0
+      },
+      {
+        "denominator": 5.0,
+        "name": "Package",
+        "numerator": 3.0,
+        "ratio": 60.0
+      },
+      {
+        "denominator": 18.0,
+        "name": "File",
+        "numerator": 3.0,
+        "ratio": 16.666666
+      },
+      {
+        "denominator": 21.0,
+        "name": "Class",
+        "numerator": 3.0,
+        "ratio": 14.285714
+      },
+      {
+        "denominator": 193.0,
+        "name": "Method",
+        "numerator": 6.0,
+        "ratio": 3.1088083
+      },
+      {
+        "denominator": 2169.0,
+        "name": "Instruction",
+        "numerator": 52.0,
+        "ratio": 2.3974183
+      },
+      {
+        "denominator": 296.0,
+        "name": "Line",
+        "numerator": 9.0,
+        "ratio": 3.0405405
+      },
+      {
+        "denominator": 178.0,
+        "name": "Conditional",
+        "numerator": 3.0,
+        "ratio": 1.6853932
+      }
+    ],
+    "name": "All reports"
+  }
+}

data/spec/code_coverage_spec.rb

@@ -88,6 +88,22 @@ module Danger
           expect(entries[2]).to(eq('50.94'))
         end
 
+        it 'total returns 0 if no coverage data' do
+          mock_coverage_json('/assets/coverage_jacoco_no_data.json')
+          mock_file_in_changeset(true)
+
+          @plugin.report
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to(be(1))
+          lines = markdowns.first.message.split("\n")
+          entries = lines[4].split('|')
+          expect(entries[2]).to(eq('0.0'))
+          expect(entries[3]).to(eq('-'))
+          expect(entries[4]).to(eq('-'))
+          expect(entries[5]).to(eq('-'))
+          expect(entries[6]).to(eq('-'))
+        end
+
         it 'ignores empty column in total' do
           mock_coverage_json('/assets/coverage_jacoco_no_conditional.json')
           mock_file_in_changeset(true)
@@ -157,11 +173,11 @@ module Danger
 
         it 'throws error if sort config invalid' do
           mock_coverage_json('/assets/coverage_jacoco_single.json')
-          expect {
+          expect do
             @plugin.report(
               sort: :invalid
             )
-          }.to(raise_error(%r{:ascending, :descending}))
+          end.to(raise_error(%r{:ascending, :descending}))
         end
 
         it 'finds changed file in subdirectory' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-code_coverage
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Kyaak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-26 00:00:00.000000000 Z
+date: 2019-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -194,6 +194,7 @@ files:
 - spec/assets/coverage_jacoco.json
 - spec/assets/coverage_jacoco_multiple_unordered.json
 - spec/assets/coverage_jacoco_no_conditional.json
+- spec/assets/coverage_jacoco_no_data.json
 - spec/assets/coverage_jacoco_single.json
 - spec/assets/coverage_no_files.json
 - spec/assets/missing_json.html
@@ -219,7 +220,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Read Jenkins code-coverage reports and comment pull request with coverage
@@ -231,6 +233,7 @@ test_files:
 - spec/assets/coverage_jacoco.json
 - spec/assets/coverage_jacoco_multiple_unordered.json
 - spec/assets/coverage_jacoco_no_conditional.json
+- spec/assets/coverage_jacoco_no_data.json
 - spec/assets/coverage_jacoco_single.json
 - spec/assets/coverage_no_files.json
 - spec/assets/missing_json.html