danger-clorox 0.0.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99c9aa689fb59ed8d38855f1cf54c693e67b3687
-  data.tar.gz: ad581855f505ec8341b292cf47ec8451e482a620
+  metadata.gz: 6b674b32946188d77a7316cc4effc59201f1c487
+  data.tar.gz: d41d4a774ea2a346f5608ef6728d7fd602217ed1
 SHA512:
-  metadata.gz: a16eb5f79c13def553f4e2b973f59903f318be85de34e59c379bbd1760dcb5f3351933cf2178230387f4134dccb2c21662f48c2bed10cb10ab0d3e4bb91bc521
-  data.tar.gz: 56c2ec0c04c50c484a8bbac5ee03acb02685c23ee334c1e38ae17588a3bc57b491fb7fd9eefb2be9a4ebb99e1e5aea33a18fb2246a9ed236ec08bea40e3b2369
+  metadata.gz: 4e169b4d61f39882461f8320cf4c8cc911f1e33709d0582384610fea7e338d4f337f1919b9790e9234e83bf1d15d10b7949ca8599b1f6af4d9f99a3d177b59ea
+  data.tar.gz: 8bcd4aebca1eca8c72acc5baac6562334a22b7b05d713eff6c58a51f4d83ab78ea6a5469b2d72106360a19cacef4b7b0fd92d1998c15ddef25513f3b743b3722

data/.gitignore

@@ -1,3 +1,4 @@
+*.swp
 *.gem
 *.rbc
 /.config

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-swiftlint (0.0.1)
+    danger-clorox (1.0.0)
       danger
 
 GEM
@@ -10,25 +10,37 @@ GEM
     addressable (2.4.0)
     bacon (1.2.0)
     claide (1.0.0)
+    claide-plugins (0.9.1)
+      cork
+      nap
+      open4 (~> 1.3)
     coderay (1.1.1)
     colored (1.2)
-    cork (0.1.0)
+    cork (0.2.0)
       colored (~> 1.2)
-    danger (0.8.4)
+    danger (3.1.0)
       claide (~> 1.0)
+      claide-plugins (> 0.9.0)
       colored (~> 1.2)
       cork (~> 0.1)
-      faraday (~> 0)
+      faraday (~> 0.9)
+      faraday-http-cache (~> 1.0)
       git (~> 1)
+      gitlab (~> 3.7.0)
+      kramdown (~> 1.5)
       octokit (~> 4.2)
-      redcarpet (~> 3.3)
       terminal-table (~> 1)
     diff-lcs (1.2.5)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
+    faraday-http-cache (1.3.1)
+      faraday (~> 0.8)
     ffi (1.9.10)
     formatador (0.2.5)
     git (1.3.0)
+    gitlab (3.7.0)
+      httparty (~> 0.13.0)
+      terminal-table
     guard (2.14.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -43,6 +55,11 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
+    httparty (0.13.7)
+      json (~> 1.8)
+      multi_xml (>= 0.5.2)
+    json (1.8.3)
+    kramdown (1.12.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
@@ -53,13 +70,16 @@ GEM
       metaclass (~> 0.0.1)
     mocha-on-bacon (0.2.2)
       mocha (>= 0.13.0)
+    multi_xml (0.5.5)
     multipart-post (2.0.0)
+    nap (1.1.0)
     nenv (0.3.0)
     notiffany (0.1.0)
       nenv (~> 0.1)
       shellany (~> 0.0)
     octokit (4.3.0)
       sawyer (~> 0.7.0, >= 0.5.3)
+    open4 (1.3.4)
     prettybacon (0.0.2)
       bacon (~> 1.2)
     pry (0.10.3)
@@ -70,7 +90,6 @@ GEM
     rb-fsevent (0.9.7)
     rb-inotify (0.9.7)
       ffi (>= 0.5.0)
-    redcarpet (3.3.4)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
       rspec-expectations (~> 3.5.0)
@@ -89,8 +108,10 @@ GEM
       faraday (~> 0.8, < 0.10)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.6.0)
+    terminal-table (1.7.0)
+      unicode-display_width (~> 1.1)
     thor (0.19.1)
+    unicode-display_width (1.1.0)
 
 PLATFORMS
   ruby
@@ -98,7 +119,7 @@ PLATFORMS
 DEPENDENCIES
   bacon
   bundler (~> 1.3)
-  danger-swiftlint!
+  danger-clorox!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
   listen (= 3.0.7)

data/lib/danger_plugin.rb

@@ -3,15 +3,15 @@ module Danger
 
   class DangerClorox < Plugin
 
+    # Allows you to specify a directory from where clorox will be run.
+    attr_accessor :directory
+
     # Checks presence of file header comments. Will fail if `clorox` cannot be installed correctly.
     # Generates a `markdown` list of dirty Objective-C and Swift files
     #
-    # @param   [String] files
-    #          A globbed string which should return the files that you want to check, defaults to nil.
-    #          if nil, modified and added files from the diff will be used.
     # @return  [void]
     #
-    def check_files(files=nil)
+    def check_files
       # Installs clorox if needed
       system "pip install --target /tmp/danger_clorox clorox" unless clorox_installed?
 
@@ -21,17 +21,21 @@ module Danger
         return
       end
 
-      # Either use files provided, or use the modified + added
-      files = files ? Dir.glob(files) : (git.modified_files + git.added_files).uniq
+      clorox_command = "python /tmp/danger_clorox/clorox/clorox.py "
+      clorox_command += "--path #{directory ? directory : '.'} "
+      clorox_command += "--inspection "
+      clorox_command += "--report json"
 
       require 'json'
-      result = JSON.parse(`python /tmp/danger_clorox/clorox/clorox.py -p #{files.join(" ")} -i -r json`)
+      result_json = JSON.parse(`(#{clorox_command})`)
 
       message = ''
-      if result['status'] == 'dirty'
+      if result_json['status'] == 'dirty'
         message = "### Clorox has found issues\n"
         message << "Please, remove the header from the files below (those comments on the top of your file):\n\n"
-        message << parse_results(result['files'])
+        result_json['files'].each do |r|
+          message << "- #{r}\n"
+        end
         markdown message
       end
     end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerClorox
-  VERSION = "0.0.1".freeze
+  VERSION = "1.0.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-clorox
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-14 00:00:00.000000000 Z
+date: 2016-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger