danger-checkstyle_formatter 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2fa439c0c2eacb8943b28f8620970be83bf74702710da4c22f39100af3cb9174
-  data.tar.gz: b08d08d063db89ddf5dd2c52f0fda97f14cb9e16e9c5b8f5dd0ee8b59a95f6f2
+  metadata.gz: 313c129a86402d906ec66558913984510f2ee2383f10f953cf49329605f9a28d
+  data.tar.gz: 40c72d863de1a76f9966fb40cba03a6d3db8632496c1fd80aaed479d70617c0c
 SHA512:
-  metadata.gz: 75f20cc610cc65ba1e82a085d7fc53b03b2f1a7dc45529b3aea381e832d18046ec211aa24c3633443acd8c5bdf54219cb42e36f3713d04e46cc724205eaff9cb
-  data.tar.gz: 6321330dd3d017ea3f604ad3f347b4be18467065d7af96ad054e1edbfb982500b0894e68b7226dfa40e2c65cd145f540d5a4b26dbaba7637345a4ea6f4c01058
+  metadata.gz: 573f0b33bbdd9426d6dacc97909bc4fa829ae11bd487c416ace88ee91baf662b073471326d09ea00f224a0730570f68e72d787134fafe8770c8beae209669f38
+  data.tar.gz: 2cb06bef03beeb8085b9fa22533e0ae4664dedd42b4eb0bd35385545e24f154d39ce6f841ce5f293734cf1aa7e1aab3fca938948dbb9a72ea5c9dbdc36965e38

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-checkstyle_formatter (0.0.1)
+    danger-checkstyle_formatter (0.0.2)
       danger-plugin-api (~> 1.0)
       ox (~> 2.0)
 

data/lib/checkstyle_formatter/gem_version.rb

@@ -1,3 +1,3 @@
 module CheckstyleFormatter
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/checkstyle_formatter/plugin.rb

@@ -73,7 +73,7 @@ module Danger
 
     def send_inline_comment(errors)
       errors.each do |error|
-        fail(error.message, file: error.file_name, line: error.line)
+        warn(error.message, file: error.file_name, line: error.line)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-checkstyle_formatter
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - noboru-i
@@ -182,8 +182,6 @@ files:
 - README.md
 - Rakefile
 - danger-checkstyle_format.gemspec
-- lib/checkstyle_format/gem_version.rb
-- lib/checkstyle_format/plugin.rb
 - lib/checkstyle_formatter/checkstyle_error.rb
 - lib/checkstyle_formatter/gem_version.rb
 - lib/checkstyle_formatter/plugin.rb

data/lib/checkstyle_format/gem_version.rb

@@ -1,3 +0,0 @@
-module CheckstyleFormatter
-  VERSION = "0.0.1"
-end

data/lib/checkstyle_format/plugin.rb

@@ -1,80 +0,0 @@
-require_relative "checkstyle_error"
-
-module Danger
-  # Danger plugin for checkstyle formatted xml file.
-  #
-  # @example Parse the XML file, and let the plugin do your reporting
-  #
-  #          checkstyle_format.base_path = Dir.pwd
-  #          checkstyle_format.report 'app/build/reports/checkstyle/checkstyle.xml'
-  #
-  # @example Parse the XML text, and let the plugin do your reporting
-  #
-  #          checkstyle_format.base_path = Dir.pwd
-  #          checkstyle_format.report_by_text '<?xml ...'
-  #
-  # @see  noboru-i/danger-checkstyle_format
-  # @tags lint, reporting
-  #
-  class DangerCheckstyleFormatter < Plugin
-    # Base path of `name` attributes in `file` tag.
-    # Defaults to nil.
-    # @return [String]
-    attr_accessor :base_path
-
-    # Report checkstyle warnings
-    #
-    # @return   [void]
-    def report(file, inline_mode = true)
-      raise "Please specify file name." if file.empty?
-      raise "No checkstyle file was found at #{file}" unless File.exist? file
-      errors = parse(File.read(file))
-
-      send_comment(errors, inline_mode)
-    end
-
-    # Report checkstyle warnings by XML text
-    #
-    # @return   [void]
-    def report_by_text(text, inline_mode = true)
-      raise "Please specify xml text." if text.empty?
-      errors = parse(text)
-
-      send_comment(errors, inline_mode)
-    end
-
-    private
-
-    def parse(text)
-      require "ox"
-
-      doc = Ox.parse(text)
-      present_elements = doc.nodes.first.nodes.reject do |test|
-        test.nodes.empty?
-      end
-      base_path_suffix = @base_path.end_with?("/") ? "" : "/"
-      base_path = @base_path + base_path_suffix
-      elements = present_elements.flat_map do |parent|
-        parent.nodes.map do |child|
-          CheckstyleError.generate(child, parent, base_path)
-        end
-      end
-
-      elements
-    end
-
-    def send_comment(errors, inline_mode)
-      if inline_mode
-        send_inline_comment(errors)
-      else
-        raise "not implemented." # TODO: not implemented.
-      end
-    end
-
-    def send_inline_comment(errors)
-      errors.each do |error|
-        fail(error.message, file: error.file_name, line: error.line)
-      end
-    end
-  end
-end