danger-checkstyle_format 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ddb72081274d10636f6d556a7fe7501da811b07
-  data.tar.gz: 1159684bfdadea14876e58bdcb0a821d567f6342
+  metadata.gz: 245382d3418dad68da9c0b7a78e43e12a3c37539
+  data.tar.gz: d873072e053cccae270afc39a9b246a53afe7ce5
 SHA512:
-  metadata.gz: 402f2c09db9fe9aff340eaa673de83064695f8eddc7679624c3859f5c9659850b21b0cd532e8a6b09486064e50173a638db09b3484efb37d91e6f0180c28bc58
-  data.tar.gz: c7bb3b01c6e03bc309077d88a820a051af9fbbdbad1da88564e90c0e10eac991ec7a3a0b9f75f45b9e294fd465d233888811e3f7e1e2f3203a45602e6846c775
+  metadata.gz: 15416beb75052d6cb3ba27a1e83fee925c60005210907fe49d1bda606c4ec0da5ced05a5267a10134f9077483f20249cbc8ef65be2c12099895e7b2013f1f69b
+  data.tar.gz: 06a4c73c61416644fca82a477436968fcf940d6f42f3dcc7879d51f7e628c6299a0b7c33eadbe8eac91d0f6f71cebc9d709bbdbf8972ae5f7d94981f0a164399

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-checkstyle_format (0.0.1)
+    danger-checkstyle_format (0.0.3)
       danger-plugin-api (~> 1.0)
       ox (~> 2.0)
 

data/README.md

@@ -12,7 +12,8 @@ Danger plugin for checkstyle formatted xml file.
 
 <blockquote>Parse the XML file, and let the plugin do your reporting
   <pre>
-checkstyle_format.report "/path/to/output.xml"</pre>
+checkstyle_format.base_path = Dir.pwd
+checkstyle_format.report 'app/build/reports/checkstyle/checkstyle.xml'</pre>
 </blockquote>
 
 ## Development

data/lib/checkstyle_format/gem_version.rb

@@ -1,3 +1,3 @@
 module CheckstyleFormat
-  VERSION = "0.0.1".freeze
+  VERSION = "0.0.3".freeze
 end

data/lib/checkstyle_format/plugin.rb

@@ -3,7 +3,8 @@ module Danger
   #
   # @example Parse the XML file, and let the plugin do your reporting
   #
-  #          checkstyle_format.report
+  #          checkstyle_format.base_path = Dir.pwd
+  #          checkstyle_format.report 'app/build/reports/checkstyle/checkstyle.xml'
   #
   # @see  noboru-i/danger-checkstyle_format
   # @tags lint, reporting
@@ -22,8 +23,6 @@ module Danger
       raise "No checkstyle file was found at #{file}" unless File.exist? file
       errors = parse(file)
 
-      puts errors.size
-
       if inline_mode
         send_inline_comment(errors)
       else
@@ -53,9 +52,11 @@ module Danger
       present_elements = doc.nodes.first.nodes.reject do |test|
         test.nodes.empty?
       end
+      base_path_suffix = @base_path.end_with?("/") ? "" : "/"
+      base_path = @base_path + base_path_suffix
       elements = present_elements.flat_map do |parent|
         parent.nodes.map do |child|
-          CheckstyleError.generate(child, parent, @base_path)
+          CheckstyleError.generate(child, parent, base_path)
         end
       end
 

data/spec/checkstyle_format_spec.rb

@@ -27,7 +27,7 @@ module Danger
 
       describe ".parse" do
         subject(:errors) do
-          @checkstyle_format.base_path = "/path/to/"
+          @checkstyle_format.base_path = "/path/to"
           @checkstyle_format.send(:parse, "spec/fixtures/checkstyle.xml")
         end
         it "have 4 items" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-checkstyle_format
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - noboru-i