danger-changelog 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23ffe294b89bbc0ab12ea04d4ec4047537296e946185c8c429d2a0342b99f5f3
-  data.tar.gz: 12d61d6e00b7bafda8f4007b12219f33a11b0b3e12b5442404fb2ff419b263e8
+  metadata.gz: 450307fc09c7eaaa1c231f41cd538c3a77ec15b466bcfb0f1e0bd0bbe5948376
+  data.tar.gz: 5c59cc348309c6f0b244ee9316ebe9d95b4850bb6a33d4aaf9588947866d3702
 SHA512:
-  metadata.gz: 844b03efdd6dbda1f354d0473471ff768d0fe39774521f5e5d092b8b2cc1febcbae5bda93fef8f9da6488e3c4b13c1fb385303b10e37debd7d546a953687875d
-  data.tar.gz: 94016cf396222b1b0c06eb78b3c940eddc7bf3b4f7fd0114ee5a7779317067f8f33ca4e58348ff629a6c99f470977878676c9c803b47c56ef83d267b3196fbd2
+  metadata.gz: 3b117b228586220f9ca929114e838d6811837daff83c0b5822de7283806d607ba66be2f37f393bb0d7b630914487b18b55b74ac79ce52ea2bffb94193b53b671
+  data.tar.gz: a4538cb355fa4039ce90715456b16b850fc9e9fc7713b73fd411e8c1f3070ed486c8ab725548921940d762c7af42a35ed43ac305b62e75983933ff4d9763b2e5

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-12-20 12:04:45 -0500 using RuboCop version 0.61.1.
+# on 2018-12-20 16:02:35 -0500 using RuboCop version 0.61.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Changelog
 
+### 0.4.2 (2018/12/21)
+
+* [#37](https://github.com/dblock/danger-changelog/issues/37): Allow for parenthesis and brackets around headers - [@dblock](https://github.com/dblock).
+
 ### 0.4.1 (2018/12/20)
 
 * [#37](https://github.com/dblock/danger-changelog/issues/37): Allow for parenthesis and brackets around versions and dates - [@dblock](https://github.com/dblock).

data/danger-changelog.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
 
+  spec.add_development_dependency 'activesupport'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'guard', '~> 2.14'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'

data/lib/changelog/changelog_line/changelog_header_line.rb

@@ -12,7 +12,7 @@ module Danger
       def valid?
         stripped_line = line.strip
 
-        m = stripped_line.match(/^#{HASHES}\s[\w\s\:]*$/) # title
+        m = stripped_line.match(/^#{HASHES}\s#{OPEN_PARENS}[\w\s\:]*#{CLOSE_PARENS}$/) # title
         m ||= stripped_line.match(/^#{HASHES}\s#{OPEN_PARENS}#{SEMVER}#{CLOSE_PARENS}$/) # semver only
         m ||= stripped_line.match(/^#{HASHES}\s#{OPEN_PARENS}#{SEMVER}#{CLOSE_PARENS}[\s\-]+#{OPEN_PARENS}(#{ISO8601_DATE}|\w*)#{CLOSE_PARENS}$/) # semver and iso 8601 date or next version description
 

data/lib/changelog/gem_version.rb

@@ -1,3 +1,3 @@
 module Changelog
-  VERSION = '0.4.1'.freeze
+  VERSION = '0.4.2'.freeze
 end

data/spec/changelog_entry_line_spec.rb

@@ -1,163 +1,109 @@
 require File.expand_path('spec_helper', __dir__)
 
 describe Danger::Changelog::ChangelogEntryLine do
-  context 'changelog line' do
-    it 'validates as changelog line' do
-      expect(described_class.validates_as_changelog_line?('* Valid without PR link - [@dblock](https://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): Valid with PR link - [@dblock](https://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('Missing star - [@dblock](https://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1) - Not a colon - [@dblock](https://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): No dash [@dblock](https://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): No final period - [@dblock](https://github.com/dblock)')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): No name.')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): No https in github - [@dblock](http://github.com/dblock).')).to be true
-      expect(described_class.validates_as_changelog_line?('* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra trailing slash - [@dblock](https://github.com/dblock/).')).to be true
-      expect(described_class.validates_as_changelog_line?('# [#1](https://github.com/dblock/danger-changelog/pull/1): Hash instead of star - [@dblock](https://github.com/dblock).')).to be true
-    end
-
-    it 'doesnt validate as changelog line' do
-      expect(described_class.validates_as_changelog_line?('Missing star, PR and author link.')).to be false
-      expect(described_class.validates_as_changelog_line?('* ')).to be false
-      expect(described_class.validates_as_changelog_line?('[@dblock](https://github.com/dblock).')).to be false
-      expect(described_class.validates_as_changelog_line?(' - [@dblock](https://github.com/dblock).')).to be false
-      expect(described_class.validates_as_changelog_line?('[#1](https://github.com/dblock/danger-changelog/pull/1).')).to be false
-      expect(described_class.validates_as_changelog_line?('[#1](https://github.com/dblock/danger-changelog/pull/1):  ')).to be false
-    end
-  end
+  it_behaves_like 'validates as changelog entry line', '* Valid without PR link - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* Valid without PR link - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Valid with PR link - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', 'Missing star - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1) - Not a colon - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No dash [@dblock](https://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No final period - [@dblock](https://github.com/dblock)'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No name.'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No https in github - [@dblock](http://github.com/dblock).'
+  it_behaves_like 'validates as changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra trailing slash - [@dblock](https://github.com/dblock/).'
+  it_behaves_like 'validates as changelog entry line', '# [#1](https://github.com/dblock/danger-changelog/pull/1): Hash instead of star - [@dblock](https://github.com/dblock).'
+
+  it_behaves_like 'does not validate as changelog entry line', 'Missing star, PR and author link.'
+  it_behaves_like 'does not validate as changelog entry line', '* '
+  it_behaves_like 'does not validate as changelog entry line', '[@dblock](https://github.com/dblock).'
+  it_behaves_like 'does not validate as changelog entry line', ' - [@dblock](https://github.com/dblock).'
+  it_behaves_like 'does not validate as changelog entry line', '[#1](https://github.com/dblock/danger-changelog/pull/1).'
+  it_behaves_like 'does not validate as changelog entry line', '[#1](https://github.com/dblock/danger-changelog/pull/1):  '
 
   context 'changelog entry line' do
     context 'when without PR link' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* Valid without PR link - [@antondomashnev](https://github.com/antondomashnev).') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
+      it_behaves_like 'valid changelog entry line', '* Valid without PR link - [@antondomashnev](https://github.com/antondomashnev).'
     end
 
     context 'when with PR link' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): Valid with PR link - [@dblock](https://github.com/dblock).') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
+      it_behaves_like 'valid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Valid with PR link - [@dblock](https://github.com/dblock).'
     end
 
     context 'when missing star' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('Missing star - [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', 'Missing star - [@dblock](https://github.com/dblock).'
     end
 
     context 'when not a colon' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1) - Not a colon - [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1) - Not a colon - [@dblock](https://github.com/dblock).'
     end
 
     context 'when no dash' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): No dash [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No dash [@dblock](https://github.com/dblock).'
     end
 
     context 'when no final period' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): No final period - [@dblock](https://github.com/dblock)') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No final period - [@dblock](https://github.com/dblock)'
     end
 
     context 'when no name' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): No name.') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No name.'
     end
 
     context 'when no https in GitHub' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): No https in github - [@dblock](http://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): No https in github - [@dblock](http://github.com/dblock).'
     end
 
     context 'when extra trailing slash' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra trailing slash - [@dblock](https://github.com/dblock/).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra trailing slash - [@dblock](https://github.com/dblock/).'
     end
 
     context 'when extra period' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra period. - [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra period. - [@dblock](https://github.com/dblock).'
     end
 
     context 'when extra colon' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra colon, - [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra colon, - [@dblock](https://github.com/dblock).'
     end
 
     context 'when extra hash' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): With # - [@dblock](https://github.com/dblock).') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
+      it_behaves_like 'valid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): With # - [@dblock](https://github.com/dblock).'
     end
 
     context 'when with question mark' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('* [#1](https://github.com/dblock/danger-changelog/pull/1): With ? - [@dblock](https://github.com/dblock).') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
+      it_behaves_like 'valid changelog entry line', '* [#1](https://github.com/dblock/danger-changelog/pull/1): With ? - [@dblock](https://github.com/dblock).'
     end
 
     context 'when hash instead of star' do
-      subject { Danger::Changelog::ChangelogEntryLine.new('# [#1](https://github.com/dblock/danger-changelog/pull/1): Hash instead of star - [@dblock](https://github.com/dblock).') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
+      it_behaves_like 'invalid changelog entry line', '# [#1](https://github.com/dblock/danger-changelog/pull/1): Hash instead of star - [@dblock](https://github.com/dblock).'
     end
   end
 
   context 'example' do
     let(:github) do
-      double(Danger::RequestSources::GitHub,
-             pr_json: { 'number' => 123, 'html_url' => 'https://github.com/dblock/danger-changelog/pull/123' },
-             pr_author: 'dblock',
-             pr_title: pr_title)
+      double(
+        Danger::RequestSources::GitHub,
+        pr_json: {
+          'number' => 123, 'html_url' => 'https://github.com/dblock/danger-changelog/pull/123'
+        },
+        pr_author: 'dblock',
+        pr_title: pr_title
+      )
     end
+
     context 'no transformation required' do
       let(:pr_title) { 'Test' }
       it 'uses title as is' do
         expect(described_class.example(github)).to eq '* [#123](https://github.com/dblock/danger-changelog/pull/123): Test - [@dblock](https://github.com/dblock).'
       end
     end
+
     context 'with lowercase title' do
       let(:pr_title) { 'test' }
       it 'capitalizes it' do
         expect(described_class.example(github)).to eq '* [#123](https://github.com/dblock/danger-changelog/pull/123): Test - [@dblock](https://github.com/dblock).'
       end
     end
+
     context 'with a trailing period' do
       let(:pr_title) { 'Test.' }
       it 'removes it' do

data/spec/changelog_header_line_spec.rb

@@ -1,145 +1,93 @@
 require File.expand_path('spec_helper', __dir__)
 
 describe Danger::Changelog::ChangelogHeaderLine do
-  context 'changelog line' do
-    it 'validates as changelog line' do
-      expect(described_class.validates_as_changelog_line?('# 1.0.1')).to be true
-      expect(described_class.validates_as_changelog_line?('## Version 1.0.1')).to be true
-      expect(described_class.validates_as_changelog_line?('### Lollypop')).to be true
-      expect(described_class.validates_as_changelog_line?('#### Four hashes is too much')).to be true
-      expect(described_class.validates_as_changelog_line?('# 1.0.1 (1/2/3)')).to be true
-    end
-
-    it 'doesnt validate as changelog line' do
-      expect(described_class.validates_as_changelog_line?('* Star is invalid.')).to be false
-      expect(described_class.validates_as_changelog_line?('It requires a hash symbol')).to be false
-      expect(described_class.validates_as_changelog_line?('1.1.1')).to be false
-      expect(described_class.validates_as_changelog_line?('Version 2.0.1')).to be false
-      expect(described_class.validates_as_changelog_line?('#')).to be false
-      expect(described_class.validates_as_changelog_line?('## ')).to be false
-      expect(described_class.validates_as_changelog_line?('##### I can not validate five')).to be false
-    end
-  end
-
-  context 'changelog header line' do
-    context 'when one hash symbol' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# 1.0.1') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'with a Next date' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# 1.0.1 (Next)') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'with a date in ISO 8601 format' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# 1.0.1 (2018/1/2)') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'with a date not in ISO 8601 format' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# 1.0.1 (1/2/2018)') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be false
-      end
-    end
-
-    context 'when two hash symbols' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('## 1.0.1') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'when three hash symbols' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('### Lollypop') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'when four hash symbols' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('#### Four hashes is too much') }
-
-      it 'is valid' do
-        expect(subject.valid?).to be true
-      end
-    end
-
-    context 'when no hash symbol' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('* Star is invalid.') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
-
-    context 'when star instead of hash symbol' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('* Star is invalid.') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
-
-    context 'when no hash symbol' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('It requires hash symbol.') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
-
-    context 'when hash symbol without space' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('###Lollypop') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
-
-    context 'when hash symbol without header title' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('### ') }
-
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
+  it_behaves_like 'validates as changelog header line', '# 1.0.1'
+  it_behaves_like 'validates as changelog header line', '## Version 1.0.1'
+  it_behaves_like 'validates as changelog header line', '### three hashes'
+  it_behaves_like 'validates as changelog header line', '#### Four hashes is too much'
+  it_behaves_like 'does not validate as changelog header line', 'something else'
+
+  it_behaves_like 'valid changelog header line', '# 1.0.1'
+  it_behaves_like 'valid changelog header line', '### Lollypop'
+
+  it_behaves_like 'invalid changelog header line', '# 1.0.1 (1/2/3)'
+  it_behaves_like 'invalid changelog header line', '* Star is invalid.'
+  it_behaves_like 'invalid changelog header line', '* Star is invalid.'
+  it_behaves_like 'invalid changelog header line', 'It requires a hash symbol'
+  it_behaves_like 'invalid changelog header line', '1.1.1'
+  it_behaves_like 'invalid changelog header line', 'Version 2.0.1'
+  it_behaves_like 'invalid changelog header line', '#'
+  it_behaves_like 'invalid changelog header line', '## '
+  it_behaves_like 'invalid changelog header line', '##### I can not validate five'
+
+  it_behaves_like 'valid changelog header line', '# 1.0.1 (Next)'
+
+  context 'ISO 8601 format date' do
+    it_behaves_like 'valid changelog header line', '# 1.0.1 (2018/1/2)'
+  end
+
+  context 'date not in ISO 8601 format' do
+    it_behaves_like 'invalid changelog header line', '# 1.0.1 (1/2/2018)'
+  end
+
+  context 'two hash symbols' do
+    it_behaves_like 'valid changelog header line', '## 1.0.1'
+  end
+
+  context 'three hash symbols' do
+    it_behaves_like 'valid changelog header line', '### Lollypop'
+  end
+
+  context 'four hash symbols' do
+    it_behaves_like 'valid changelog header line', '#### Four hashes is too much'
+  end
+
+  context 'when no hash symbol' do
+    it_behaves_like 'invalid changelog header line', '* Star is invalid.'
+  end
+
+  context 'when star instead of hash symbol' do
+    it_behaves_like 'invalid changelog header line', '* Star is invalid.'
+  end
 
-    context 'when five hash symbols' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('##### Tooooo much') }
+  context 'when no hash symbol' do
+    it_behaves_like 'invalid changelog header line', 'It requires hash symbol.'
+  end
+
+  context 'when hash symbol without space' do
+    it_behaves_like 'invalid changelog header line', '###Lollypop'
+  end
 
-      it 'is invalid' do
-        expect(subject.invalid?).to be true
-      end
-    end
-
-    context 'with a string as semver' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# Invalid (Next)') }
+  context 'when hash symbol without header title' do
+    it_behaves_like 'invalid changelog header line', '### '
+  end
 
-      it 'is invalid' do
-        expect(subject.valid?).to be false
-      end
-    end
-
-    context 'with an invalid semver' do
-      subject { Danger::Changelog::ChangelogHeaderLine.new('# 0.1.') }
+  context 'when five hash symbols' do
+    it_behaves_like 'invalid changelog header line', '##### Tooooo much'
+  end
+
+  context 'with a string as semver' do
+    it_behaves_like 'invalid changelog header line', '# Invalid (Next)'
+  end
+
+  context 'with an invalid semver' do
+    it_behaves_like 'invalid changelog header line', '# 0.1.'
+  end
+
+  context 'with a colon' do
+    it_behaves_like 'valid changelog header line', '### Changed:'
+  end
+
+  context 'in brackets' do
+    it_behaves_like 'valid changelog header line', '### [Unreleased]'
+  end
 
-      it 'is invalid' do
-        expect(subject.valid?).to be false
-      end
-    end
+  context 'in parenthesis' do
+    it_behaves_like 'valid changelog header line', '### (Unreleased)'
+    it_behaves_like 'invalid changelog header line', '### (Unreleased'
+    it_behaves_like 'invalid changelog header line', '### Unreleased)'
+    it_behaves_like 'invalid changelog header line', '### [Unreleased'
+    it_behaves_like 'invalid changelog header line', '### (Unreleased]'
+    it_behaves_like 'invalid changelog header line', '### Unreleased]'
   end
 end

data/spec/changelog_placeholder_line_spec.rb

@@ -8,36 +8,14 @@ describe Danger::Changelog::ChangelogPlaceholderLine do
       end
     end
 
-    describe 'validates_as_changelog_line?' do
-      context 'when line is equal to placeholder_line from config' do
-        it 'validates as changelog line' do
-          expect(described_class.validates_as_changelog_line?("* Nothing yet here.\n")).to be true
-        end
-      end
-
-      context 'when line is not equal to placeholder_line from config' do
-        it 'validates as changelog line' do
-          expect(described_class.validates_as_changelog_line?("* Put your contribution here.\n")).to be false
-        end
-      end
+    context 'when line is equal to placeholder_line from config' do
+      it_behaves_like 'validates as changelog placeholder line', "* Nothing yet here.\n"
+      it_behaves_like 'valid changelog placeholder line', "* Nothing yet here.\n"
     end
 
-    describe 'valid?' do
-      context 'when is equal to config placeholder line' do
-        subject { Danger::Changelog::ChangelogPlaceholderLine.new("* Nothing yet here.\n") }
-
-        it 'is valid' do
-          expect(subject.valid?).to be true
-        end
-      end
-
-      context 'when is not equal to config placeholder line' do
-        subject { Danger::Changelog::ChangelogPlaceholderLine.new("* Your change here.\n") }
-
-        it 'is not valid' do
-          expect(subject.valid?).to be false
-        end
-      end
+    context 'when line is not equal to placeholder_line from config' do
+      it_behaves_like 'does not validate as changelog placeholder line', "* Put your contribution here.\n"
+      it_behaves_like 'invalid changelog placeholder line', "* Put your contribution here.\n"
     end
   end
 
@@ -48,22 +26,9 @@ describe Danger::Changelog::ChangelogPlaceholderLine do
       end
     end
 
-    describe 'validates_as_changelog_line?' do
-      context 'when line is not blank' do
-        it 'validates as changelog line' do
-          expect(described_class.validates_as_changelog_line?("* Whatever.\n")).to be false
-        end
-      end
-    end
-
-    describe 'valid?' do
-      context 'when is not blank' do
-        subject { Danger::Changelog::ChangelogPlaceholderLine.new("* Your change here.\n") }
-
-        it 'is not valid' do
-          expect(subject.valid?).to be false
-        end
-      end
+    context 'when line is not blank' do
+      it_behaves_like 'does not validate as changelog placeholder line', "* Whatever.\n"
+      it_behaves_like 'invalid changelog placeholder line', "* Whatever.\n"
     end
   end
 end

data/spec/fixtures/changelogs/semver.md

@@ -1,8 +1,3 @@
-## Changelog
-
-### Changed:
-### Fixed:
-
 ### 0.0.0
 ### 0.0.1
 ### 1.2.3 (2018/1/1)
@@ -13,7 +8,6 @@
 ### 0.0.4
 ### 10.2.3-DEV-SNAPSHOT
 ### 99999999999999999999999.999999999999999999.99999999999999999
-
 ### 0.1.1 [2018/1/1]
 ### [0.1.1] [2018/1/1]
 ## [0.2.2] - 2017-06-20

data/spec/spec_helper.rb

@@ -39,3 +39,9 @@ def testing_dangerfile
   env = Danger::EnvironmentManager.new(testing_env)
   Danger::Dangerfile.new(env, testing_ui)
 end
+
+require 'active_support'
+
+Dir[File.join(File.dirname(__FILE__), 'support', '**/*.rb')].each do |file|
+  require file
+end

data/spec/support/shared/changelog.rb

@@ -0,0 +1,41 @@
+[
+  Danger::Changelog::ChangelogHeaderLine,
+  Danger::Changelog::ChangelogPlaceholderLine,
+  Danger::Changelog::ChangelogEntryLine
+].each do |klass|
+  desc = ActiveSupport::Inflector.titleize(klass.name.split(':').last).downcase
+
+  RSpec.shared_examples "validates as #{desc}" do |line|
+    describe line do
+      it 'correctly' do
+        expect(klass.validates_as_changelog_line?(line)).to be true
+      end
+    end
+  end
+
+  RSpec.shared_examples "does not validate as #{desc}" do |line|
+    describe line do
+      it 'correctly' do
+        expect(klass.validates_as_changelog_line?(line)).to be false
+      end
+    end
+  end
+
+  RSpec.shared_examples "valid #{desc}" do |line|
+    describe line do
+      subject { klass.new(line) }
+      it 'is valid' do
+        expect(subject.valid?).to be true
+      end
+    end
+  end
+
+  RSpec.shared_examples "invalid #{desc}" do |line|
+    describe line do
+      subject { klass.new(line) }
+      it 'is valid' do
+        expect(subject.valid?).to be false
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-changelog
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - dblock
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-20 00:00:00.000000000 Z
+date: 2018-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -200,6 +214,7 @@ files:
 - spec/fixtures/changelogs/missing_your_contribution_here.md
 - spec/fixtures/changelogs/semver.md
 - spec/spec_helper.rb
+- spec/support/shared/changelog.rb
 homepage: https://github.com/dblock/danger-changelog
 licenses:
 - MIT
@@ -240,3 +255,4 @@ test_files:
 - spec/fixtures/changelogs/missing_your_contribution_here.md
 - spec/fixtures/changelogs/semver.md
 - spec/spec_helper.rb
+- spec/support/shared/changelog.rb