danger-asana 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a08597c1b35076c3e6b00e4f519d6736a15d4a1a381655cebc2f48b08e3000c2
-  data.tar.gz: 2903569370a64fbfbab7c9a0da76f995eaabc3313ec497a4651d5004c4be481a
+  metadata.gz: 7fd2a029a6612a185a1acfe4e9043e049ec23ea3229f12ddfe9cb367b96eab6e
+  data.tar.gz: c49087935482f104f4cf7583913a7f48f25e390c75ce7abfc9623955a1591b81
 SHA512:
-  metadata.gz: 6b7bb26a5fe32a13230f21cdae687671ee9fbdf87bb3e045628bc7b256be7ad42760522ef0b171272b6bde6a8ae20e0d58f5f685bfe6ae39c341af9999b8011e
-  data.tar.gz: 5e17d09e8fefc432348ce41ab5b002971a5b00bd711ddd0c5e28ea9e59fc35d6d065ae6695feee4541732e3212fc2b96c39da6ac6deb8dd369eac57035682c46
+  metadata.gz: 10b2090a71a1d19aaa099057cc76655bfbdc98165356397bb2c606132178e371194c5c7e52f70905928aa7988e49b1af214a93c81ccfe9e2b0c504a73a324a0f
+  data.tar.gz: 95a423be06e499ae47ee23fd691b8be75c7c1edfffbc77fc77d4c28b5f7ed5763cee24beb010f3195bda9253672ab5154e860f24ea5293591bebb3473ad77f15

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-asana (0.0.2)
+    danger-asana (0.0.3)
       asana (~> 0.10)
       danger-plugin-api (~> 1.0)
 

data/lib/asana/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Asana
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/asana/plugin.rb

@@ -34,7 +34,10 @@ module Danger
         task = find_by_id(issue)
 
         unless task.nil?
-          messages << "**[#{task.name}](#{task.permalink_url})**\n#{task.notes} |"
+          name = task.name[0..300].gsub("\n", "<br />").strip
+          notes = task.notes[0..300].gsub("\n", "<br />").strip
+
+          messages << "**[#{name}](#{task.permalink_url})**\n#{notes} |"
         end
       end
 

data/spec/asana_spec.rb

@@ -12,15 +12,26 @@ module Danger
       before do
         @dangerfile = testing_dangerfile
         @asana = @dangerfile.asana
+
+        @task1 = double("Task 1", {
+          name: "task 1",
+          notes: "description 1",
+          permalink_url: "https://app.asana.com/0/1"
+        })
+
+        @task2 = double("Task 2", {
+          name: "task 2",
+          notes: "description 2",
+          permalink_url: "https://app.asana.com/0/2"
+        })
       end
 
       it "Finds multiple Asana tasks ids in body and title" do
         allow(@asana).to receive_message_chain("github.pr_title").and_return("[#1200084894659941] Test PR")
         allow(@asana).to receive_message_chain("github.pr_body").and_return("[#1200084894659949]")
 
-        allow(@asana).to receive_message_chain("find_by_id.name").and_return("task 1", "task 2")
-        allow(@asana).to receive_message_chain("find_by_id.notes").and_return("description 1", "description 2")
-        allow(@asana).to receive_message_chain("find_by_id.permalink_url").and_return("https://app.asana.com/0/1", "https://app.asana.com/0/2")
+        allow(@asana).to receive("find_by_id").with("1200084894659941").and_return(@task1)
+        allow(@asana).to receive("find_by_id").with("1200084894659949").and_return(@task2)
 
         @asana.check
 
@@ -36,9 +47,8 @@ description 2 |))
         allow(@asana).to receive_message_chain("github.pr_title").and_return("Test PR")
         allow(@asana).to receive_message_chain("github.pr_body").and_return("testing\n\nhttps://app.asana.com/0/1199918955119300/1200084193308092]\nhttps://app.asana.com/0/1199972814069143/1199619253751287")
 
-        allow(@asana).to receive_message_chain("find_by_id.name").and_return("task 1", "task 2")
-        allow(@asana).to receive_message_chain("find_by_id.notes").and_return("description 1", "description 2")
-        allow(@asana).to receive_message_chain("find_by_id.permalink_url").and_return("https://app.asana.com/0/1", "https://app.asana.com/0/2")
+        allow(@asana).to receive("find_by_id").with("1200084193308092").and_return(@task1)
+        allow(@asana).to receive("find_by_id").with("1199619253751287").and_return(@task2)
 
         @asana.check
 
@@ -54,9 +64,7 @@ description 2 |))
         allow(@asana).to receive_message_chain("github.pr_title").and_return("[#1200084894659941]")
         allow(@asana).to receive_message_chain("github.pr_body").and_return("https://app.asana.com/0/1199972814069143/1200084894659941")
 
-        allow(@asana).to receive_message_chain("find_by_id.name").and_return("task 1")
-        allow(@asana).to receive_message_chain("find_by_id.notes").and_return("description 1")
-        allow(@asana).to receive_message_chain("find_by_id.permalink_url").and_return("https://app.asana.com/0/1")
+        allow(@asana).to receive("find_by_id").with("1200084894659941").and_return(@task1)
 
         @asana.check
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-asana
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Thomas Joulin