danger-apkstats 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 7fc3dfd87e810a6c84f051e5be3f35d26670364e4a2a5ee8ecab8671d4c1f4ec
-  data.tar.gz: 224097d040e3560e5168c78754ee0b88e4078e4682a7858180e8b90f096e9588
+SHA1:
+  metadata.gz: 6aa65759eac00e6bdc2a9a745455a10d07a40c9e
+  data.tar.gz: 49efc61524d8d75eeef95050977fb4d0e1a08ca7
 SHA512:
-  metadata.gz: c4bb340f489244e20e62cd3b61fde090b98143b91795b8068be7e07dbf94f8a2cef33041c6c021c3094426520c27c2b4cf90c6fefc5623d42655291bed2d80f0
-  data.tar.gz: 53d786b5eab9d48c1221aee736f5a3278bbcd5f552d0f00c5a0b4c1a58592f1907c596db082f91e42d92c89ad9ccfb437eef2b2b48cb31ebe19d0dd966dfe643
+  metadata.gz: 0cf8e9d23c34f2af359cb01c18b36ca2e556e613e6bc7757421b1fc19ff115be7f4055b54f73ffa68e84a95932af847d15bc720f2c83b237caee57085296cac1
+  data.tar.gz: e1a15a138f9f446b4c8be024ae8bae0545f09fd7857ea7c01cbb90aa323368416dba9bdb9d758ce3d1869d1c1fa34b5f8d39482c586b225618d427be13589c0a

data/Dangerfile.sample

@@ -11,5 +11,7 @@ message(apkstats.non_required_features)
 message(apkstats.permissions)
 message(apkstats.min_sdk)
 message(apkstats.target_sdk)
+message("#{apkstats.reference_count}")
+message("#{apkstats.dex_count}")
 
 apkstats.compare_with('/spec/fixture/app-other5.apk', do_report: true)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-apkstats (0.1.2)
+    danger-apkstats (0.2.0)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -40,7 +40,7 @@ GEM
       faraday (~> 0.8)
     ffi (1.9.25)
     formatador (0.2.5)
-    git (1.4.0)
+    git (1.5.0)
     guard (2.14.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -69,7 +69,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.9.0)
+    octokit (4.10.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.12.1)
@@ -79,7 +79,7 @@ GEM
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    public_suffix (3.0.2)
+    public_suffix (3.0.3)
     rainbow (3.0.0)
     rake (10.5.0)
     rb-fsevent (0.10.3)

data/README.md

@@ -31,6 +31,8 @@ apkstats.non_required_features #=> Array<String> | Nil
 apkstats.permissions #=> Array<String> | Nil
 apkstats.min_sdk #=> String | Nil
 apkstats.target_sdk #=> String | Nils
+apkstats.reference_count #=> Fixnum
+apkstats.dex_count #=> Fixnum
 ```
 
 ### Get a comparison report
@@ -43,12 +45,14 @@ For example, the report will be like below.
 
 Property | Summary  
 :--- | :---
-New File Size | 1621248 Bytes. (1.55 MB
+New File Size | 1621248 Bytes. (1.55 MB)
 File Size Change | -13352 Bytes. (-13.04 KB)
 Download Size Change | +41141 Bytes. (+40.18 KB)
 Removed Required Features | - android.hardware.camera
 Removed Non-required Features | - android.hardware.camera.front (not-required)
 Removed Permissions | - android.permission.INTERNET<br>- android.permission.CAMERA
+New Number of dex file(s) | 15720
+Number of dex file(s) Change | 1
 
 ## Development
 

data/lib/apkstats/command/apk_analyzer.rb

@@ -37,6 +37,17 @@ module Apkstats::Command
       run_command("manifest", "target-sdk", apk_filepath)
     end
 
+    def method_reference_count(apk_filepath)
+      ApkAnalyzer.parse_reference_to_map(run_command("dex", "references", apk_filepath))
+        .values
+        .map(&:to_i)
+        .inject(:+)
+    end
+
+    def dex_count(apk_filepath)
+      ApkAnalyzer.parse_reference_to_map(run_command("dex", "references", apk_filepath)).size
+    end
+
     def self.parse_permissions(command_output)
       command_output.split(/\r?\n/).map { |s| to_permission(s) }
     end
@@ -59,6 +70,13 @@ module Apkstats::Command
       ::Apkstats::Entity::Feature.new(name, not_required: kind == "not-required", implied_reason: kind == "implied:" && tail)
     end
 
+    def self.parse_reference_to_map(command_output)
+      command_output.split(/\r?\n/).each_with_object({}) do |s, acc|
+        dex_file, method_count = s.strip.split(/\t/, 2)
+        acc[dex_file] = method_count
+      end
+    end
+
     private
 
     def run_command(*args)

data/lib/apkstats/command/executable.rb

@@ -21,6 +21,8 @@ module Apkstats::Command
     #     permissions: Array<String>,
     #     min_sdk: String,
     #     target_sdk: String,
+    #     method_reference_count: Integer,
+    #     dex_count: Integer,
     #   },
     #   other: {
     #     file_size: Integer,
@@ -30,6 +32,8 @@ module Apkstats::Command
     #     permissions: Array<String>,
     #     min_sdk: String,
     #     target_sdk: String,
+    #     method_reference_count: Integer,
+    #     dex_count: Integer,
     #   },
     #   diff: {
     #     file_size: Integer,
@@ -48,6 +52,8 @@ module Apkstats::Command
     #     },
     #     min_sdk: Array<String>,
     #     target_sdk: Array<String>,
+    #     method_reference_count: Integer,
+    #     dex_count: Integer,
     #   }
     # }
     #

data/lib/apkstats/entity/apk_info.rb

@@ -10,10 +10,12 @@ module Apkstats::Entity
       permissions
       min_sdk
       target_sdk
+      method_reference_count
+      dex_count
     ).freeze
 
     # Integer
-    attr_accessor :file_size, :download_size
+    attr_accessor :file_size, :download_size, :method_reference_count, :dex_count
 
     # String
     attr_accessor :min_sdk, :target_sdk

data/lib/apkstats/entity/apk_info_diff.rb

@@ -63,5 +63,15 @@ module Apkstats::Entity
       # String
       [@base[__method__], @other[__method__]].uniq
     end
+
+    def method_reference_count
+      # Integer
+      @base[__method__].to_i - @other[__method__].to_i
+    end
+
+    def dex_count
+      # Integer
+      @base[__method__].to_i - @other[__method__].to_i
+    end
   end
 end

data/lib/apkstats/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Apkstats
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/lib/apkstats/plugin.rb

@@ -52,6 +52,14 @@ module Danger
   #
   #         apkstats.target_sdk
   #
+  # @example Show the methods reference count of your apk file.
+  #
+  #         apkstats.method_reference_count
+  #
+  # @example Show the number of dex of your apk file.
+  #
+  #         apkstats.dex_count
+  #
   # @see  Jumpei Matsuda/danger-apkstats
   # @tags android, apk_stats
   #
@@ -81,7 +89,7 @@ module Danger
     # @return [String]
     attr_accessor :apk_filepath
 
-    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
 
     # Get stats of two apk files and calculate diffs between them.
     #
@@ -122,7 +130,7 @@ module Danger
         result[:base][:file_size].tap do |file_size|
           size = Apkstats::Helper::Bytes.from_b(file_size)
 
-          md << "New File Size | #{size.to_b} Bytes. (#{size.to_mb} MB " << "\n"
+          md << "New File Size | #{size.to_b} Bytes. (#{size.to_mb} MB) " << "\n"
         end
 
         diff[:file_size].tap do |file_size|
@@ -137,6 +145,22 @@ module Danger
           md << "Download Size Change | #{size.to_s_b} Bytes. (#{size.to_s_kb} KB) " << "\n"
         end
 
+        result[:base][:method_reference_count].tap do |method_reference_count|
+          md << "New Method Reference Count | #{method_reference_count}" << "\n"
+        end
+
+        diff[:method_reference_count].tap do |method_reference_count|
+          md << "Method Reference Count Change | #{method_reference_count}" << "\n"
+        end
+
+        result[:base][:dex_count].tap do |dex_count|
+          md << "New Number of dex file(s) | #{dex_count}" << "\n"
+        end
+
+        diff[:dex_count].tap do |dex_count|
+          md << "Number of dex file(s) Change | #{dex_count}" << "\n"
+        end
+
         report_hash_and_arrays = lambda { |key, name|
           list_up_entities = lambda { |type_key, label|
             diff[key][type_key].tap do |features|
@@ -162,7 +186,7 @@ module Danger
       e.backtrace&.each { |line| STDOUT.puts line }
     end
 
-    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     # Show the file size of your apk file.
     #
@@ -220,6 +244,22 @@ module Danger
       run_command(__method__)
     end
 
+    # Show the methods reference count of your apk file.
+    #
+    # @return [Fixnum] return positive value if exists, otherwise -1.
+    def method_reference_count(_opts = {})
+      result = run_command(__method__)
+      result || -1
+    end
+
+    # Show the number of dex of your apk file.
+    #
+    # @return [Fixnum] return positive value if exists, otherwise -1.
+    def dex_count(_opts = {})
+      result = run_command(__method__)
+      result || -1
+    end
+
     private
 
     def run_command(name)

data/spec/command/apk_analyzer_spec.rb

@@ -10,6 +10,7 @@ module Apkstats::Command
     let(:apk_other3) { fixture_path + "app-other3.apk" }
     let(:apk_other4) { fixture_path + "app-other4.apk" }
     let(:apk_other5) { fixture_path + "app-other5.apk" }
+    let(:apk_method64k) { fixture_path + "app-method64k.apk" }
 
     it "should use custom path if set" do
       expect(ApkAnalyzer.new({}).command_path).to eq("#{ENV.fetch('ANDROID_HOME')}/tools/bin/apkanalyzer")
@@ -55,6 +56,16 @@ module Apkstats::Command
       it "target_sdk should return target sdk" do
         expect(command.target_sdk(apk_base)).to eq("28")
       end
+
+      it "method_reference_count should return reference count" do
+        expect(command.method_reference_count(apk_base)).to eq(15_720)
+        expect(command.method_reference_count(apk_method64k)).to eq(124_304)
+      end
+
+      it "dex_count should return dex count" do
+        expect(command.dex_count(apk_base)).to eq(1)
+        expect(command.dex_count(apk_method64k)).to eq(2)
+      end
     end
 
     context "to_permission" do

data/spec/entity/apk_info_diff_spec.rb

@@ -31,6 +31,8 @@ module Apkstats::Entity
                                        ]),
           min_sdk: "16",
           target_sdk: "26",
+          method_reference_count: 20_000,
+          dex_count: 1,
       }
     end
 
@@ -57,6 +59,8 @@ module Apkstats::Entity
                                        ]),
           min_sdk: "21",
           target_sdk: "27",
+          method_reference_count: base_apk_values[:method_reference_count] + 2000,
+          dex_count: base_apk_values[:dex_count] + 1,
       }
     end
 
@@ -105,6 +109,8 @@ module Apkstats::Entity
       )
       expect(diff.min_sdk).to eq(%w(16 21))
       expect(diff.target_sdk).to eq(%w(26 27))
+      expect(diff.method_reference_count).to eq(-2000)
+      expect(diff.dex_count).to eq(-1)
     end
   end
 end

data/spec/entity/apk_info_spec.rb

@@ -22,6 +22,8 @@ module Apkstats::Entity
                                        ]),
           min_sdk: "16",
           target_sdk: "26",
+          method_reference_count: 20_000,
+          dex_count: 1,
       }
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-apkstats
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Jumpei Matsuda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2018-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: This is a danger plugin to inspect android application file.